Merge branch 'develop'

abdes · abdes · commit cdad79ddd19b · 2019-11-01T22:02:35.000+04:00
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
@@ -39,15 +39,16 @@ variables:
     - make install
     - ctest -C $BUILD_TYPE --output-on-failure
 
-build:ubuntu:trusty:gcc-6:
+build:ubuntu:trusty:gcc-7:
   <<: *build_definition
   image: ubuntu:trusty
   before_script:
     - apt-get update -qq
     - apt-get install -y -qq software-properties-common python-software-properties
     - add-apt-repository ppa:ubuntu-toolchain-r/test
     - apt-get update -qq
-    - apt-get install -y -qq wget git build-essential gcc-6 g++-6
+    - apt-get install -y -qq wget git build-essential gcc-7 g++-7
+    - apt-get install -y -qq xorg-dev libglu1-mesa-dev
   variables:
-    CC: gcc-6
-    CXX: g++-6
+    CC: gcc-7
+    CXX: g++-7
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -58,7 +58,7 @@ set(META_AUTHOR_DOMAIN       "https://github.com/abdes/asap")
 set(META_AUTHOR_MAINTAINER   "Abdessattar Sassi (abde.sassi gmail account)")
 set(META_VERSION_MAJOR       "0")
 set(META_VERSION_MINOR       "9")
-set(META_VERSION_PATCH       "2")
+set(META_VERSION_PATCH       "3")
 set(META_VERSION_REVISION    "${GIT_REV}")
 set(META_VERSION             "${META_VERSION_MAJOR}.${META_VERSION_MINOR}.${META_VERSION_PATCH}")
 set(META_NAME_VERSION        "${META_PROJECT_NAME} v${META_VERSION} (${META_VERSION_REVISION})")
diff --git a/README.md b/README.md
@@ -11,13 +11,13 @@
 | Windows | [![Windows][21]][20] |
 
 [0]: https://travis-ci.org/abdes/asap_app_imgui
-[9]: https://travis-matrix-badges.herokuapp.com/repos/abdes/asap_app_imgui/branches/master/9
-[10]: https://travis-matrix-badges.herokuapp.com/repos/abdes/asap_app_imgui/branches/master/10
-[11]: https://travis-matrix-badges.herokuapp.com/repos/abdes/asap_app_imgui/branches/master/11
-[12]: https://travis-matrix-badges.herokuapp.com/repos/abdes/asap_app_imgui/branches/master/12
-[13]: https://travis-matrix-badges.herokuapp.com/repos/abdes/asap_app_imgui/branches/master/13
+[9]: https://travis-matrix-badges.herokuapp.com/repos/abdes/asap_app_imgui/branches/develop/9
+[10]: https://travis-matrix-badges.herokuapp.com/repos/abdes/asap_app_imgui/branches/develop/10
+[11]: https://travis-matrix-badges.herokuapp.com/repos/abdes/asap_app_imgui/branches/develop/11
+[12]: https://travis-matrix-badges.herokuapp.com/repos/abdes/asap_app_imgui/branches/develop/12
+[13]: https://travis-matrix-badges.herokuapp.com/repos/abdes/asap_app_imgui/branches/develop/13
 [20]: https://ci.appveyor.com/project/abdes/asap-app-imgui
-[21]: https://ci.appveyor.com/api/projects/status/qoaae14rw3cyivgq/branch/master?svg=true
+[21]: https://ci.appveyor.com/api/projects/status/qoaae14rw3cyivgq/branch/develop?svg=true
 
 # Starter project with minimum necessary functionality
   - use cmake for the build system
diff --git a/common b/common
@@ -1 +1 @@
-Subproject commit 85cb5e676eef6a5a1168c3d5489cda3becbbf269
+Subproject commit a9cbe84b17d30fe4c38af779033aca333d1847a2
diff --git a/filesystem b/filesystem
@@ -1 +1 @@
-Subproject commit 26395a2d4a0da94757160070907ddb609e2eed57
+Subproject commit 57c6d859cad46cddbbb3d0cb7541756f61e773a6
diff --git a/imgui b/imgui
@@ -1 +1 @@
-Subproject commit f8c37b17d4e993661d422363dc6f9c0f2a619d37
+Subproject commit 4d7988bb64dc2d422ebf492939442d9c65633431
diff --git a/main/src/imgui_runner.cpp b/main/src/imgui_runner.cpp
@@ -490,14 +490,14 @@ void ImGuiRunner::LoadSetting() {
   if (asap::filesystem::exists(display_settings)) {
     try {
       config = cpptoml::parse_file(display_settings.string());
-      ASLOG(info, "display settings loaded from {}", display_settings);
+      ASLOG(info, "display settings loaded from {}", display_settings.string());
       has_config = true;
     } catch (std::exception const &ex) {
       ASLOG(error, "error () while loading settings from {}", ex.what(),
-            display_settings);
+            display_settings.string());
     }
   } else {
-    ASLOG(info, "file {} does not exist", display_settings);
+    ASLOG(info, "file {} does not exist", display_settings.string());
   }
 
   int width = 800;
diff --git a/main/src/ui/application_base.cpp b/main/src/ui/application_base.cpp
@@ -191,8 +191,8 @@ float ApplicationBase::DrawMainMenu() {
 void ApplicationBase::DrawStatusBar(float width, float height, float pos_x,
                                     float pos_y) {
   // Draw status bar (no docking)
-  ImGui::SetNextWindowSize(ImVec2(width, height), ImGuiSetCond_Always);
-  ImGui::SetNextWindowPos(ImVec2(pos_x, pos_y), ImGuiSetCond_Always);
+  ImGui::SetNextWindowSize(ImVec2(width, height), ImGuiCond_Always);
+  ImGui::SetNextWindowPos(ImVec2(pos_x, pos_y), ImGuiCond_Always);
   ImGui::Begin("statusbar", nullptr,
                ImGuiWindowFlags_NoTitleBar | ImGuiWindowFlags_NoSavedSettings |
                    ImGuiWindowFlags_NoBringToFrontOnFocus |
diff --git a/main/src/ui/log/sink.cpp b/main/src/ui/log/sink.cpp
@@ -290,7 +290,7 @@ namespace asap {
       color_range_end = static_cast<std::size_t>(ostr.tellp());
     }
     if (show_logger_) {
-      ostr << "[" << *msg.logger_name << "] ";
+      ostr.put('[').write(msg.logger_name.data(), msg.logger_name.size()).write("] ", 2);
     }
     auto properties = ostr.str();
 
@@ -431,7 +431,7 @@ namespace asap {
               log_settings.string());
       }
     } else {
-      ASLOG(info, "file {} does not exist", log_settings);
+      ASLOG(info, "file {} does not exist", log_settings.string());
     }
 
     if (has_config) {
diff --git a/main/src/ui/style/theme.cpp b/main/src/ui/style/theme.cpp
@@ -668,15 +668,15 @@ void Theme::LoadStyle() {
     try {
       config = cpptoml::parse_file(theme_settings.string());
       ASLOG_TO_LOGGER(logger, info, "theme settings loaded from {}",
-                      theme_settings);
+                      theme_settings.string());
       has_config = true;
     } catch (std::exception const &ex) {
       ASLOG_TO_LOGGER(logger, error,
                       "error () while loading theme settings from {}",
-                      ex.what(), theme_settings);
+                      ex.what(), theme_settings.string());
     }
   } else {
-    ASLOG_TO_LOGGER(logger, info, "file {} does not exist", theme_settings);
+    ASLOG_TO_LOGGER(logger, info, "file {} does not exist", theme_settings.string());
   }
 
   if (has_config) {
diff --git a/third_party/CMakeLists.txt b/third_party/CMakeLists.txt
@@ -5,17 +5,16 @@
 
 message("=> [third-party modules]")
 
-# Boost
-#set(BOOST_URL https://dl.bintray.com/boostorg/release/1.67.0/source/boost_1_67_0.tar.bz2 CACHE STRING "Boost download URL" FORCE)
-#set(BOOST_URL_SHA256 2684c972994ee57fc5632e03bf044746f6eb45d4920c343937a465fd67a5adba CACHE STRING "Boost download URL SHA256 checksum" FORCE)
-#add_subdirectory(boost-cmake)
-
 # Catch2
 # EXCLUDE_FROM_ALL to not have it install its files during install
 add_subdirectory(catch2 EXCLUDE_FROM_ALL)
 
 # spdlog
 SET(SPDLOG_BUILD_TESTING OFF CACHE BOOL "Build spdlog tests")
+SET(SPDLOG_INSTALL ON CACHE BOOL "Generate the spdlog install target")
+if(NOT (WIN32 OR MINGW))
+  SET(SPDLOG_BUILD_SHARED ${BUILD_SHARED_LIBS} CACHE BOOL "Build spdlog as a shared library")
+endif()
 add_subdirectory(spdlog)
 
 # GLFW
diff --git a/third_party/catch2 b/third_party/catch2
@@ -1 +1 @@
-Subproject commit 6ccd467094973824d89efb16cbc553e279f79823
+Subproject commit a2c8dce85c554aa30607914c57be300feaa3b05f
diff --git a/third_party/cxxopts b/third_party/cxxopts
@@ -1 +1 @@
-Subproject commit 287d1e39e0c9e804e5b23809e3b77ef119d3f830
+Subproject commit e6858d3429e0ba5fe6f42ce2018069ce992f3d26
diff --git a/third_party/date b/third_party/date
@@ -1 +1 @@
-Subproject commit 5f34c4052377b390976dc93efaa143c678b7ee59
+Subproject commit e7e1482087f58913b80a20b04d5c58d9d6d90155
diff --git a/third_party/spdlog b/third_party/spdlog
@@ -1 +1 @@
-Subproject commit 57c3023881877d009ff8317caf070680d93eae4a
+Subproject commit 1549ff12f1aa61ffc4d9a8727c519034724392a0

Original file line number	Diff line number	Diff line change
`@@ -290,7 +290,7 @@ namespace asap {`
`290`	`290`	`color_range_end = static_cast<std::size_t>(ostr.tellp());`
`291`	`291`	`}`
`292`	`292`	`if (show_logger_) {`
`293`		`- ostr << "[" << *msg.logger_name << "] ";`
	`293`	`+ ostr.put('[').write(msg.logger_name.data(), msg.logger_name.size()).write("] ", 2);`
`294`	`294`	`}`
`295`	`295`	`auto properties = ostr.str();`
`296`	`296`
`@@ -431,7 +431,7 @@ namespace asap {`
`431`	`431`	`log_settings.string());`
`432`	`432`	`}`
`433`	`433`	`} else {`
`434`		`- ASLOG(info, "file {} does not exist", log_settings);`
	`434`	`+ ASLOG(info, "file {} does not exist", log_settings.string());`
`435`	`435`	`}`
`436`	`436`
`437`	`437`	`if (has_config) {`