chore: cleanup and optimization

Author: genadyb

Adjust/Internal/ADJActivityHandler.m

@@ -2937,16 +2937,13 @@ - (BOOL)shouldWaitForAttStatus {
 
     // check current ATT status
     int attStatus = [self attStatus];
-    // App Tracking Transparency framework usage is disabled
-    if (attStatus == -1) {
-        // Just in case it's there from the previous init where
-        // App Tracking Transparency framework usage was enabled,
-        // remove ATT Waiting related stuff.
-        [ADJUserDefaults removeAttWaitingRemainingSeconds];
-        return NO;
-    }
-
-    // return if the status is not ATTrackingManagerAuthorizationStatusNotDetermined
+    // if attStatus is !=0 means:
+    // - consent changed from ATTrackingManagerAuthorizationStatusNotDetermined ( attStatus > 0 )
+    // or
+    // - App Tracking Transparency framework usage is disabled ( attStatus == -1 )
+    // In these cases:
+    // 1. NO returned
+    // 2. ATT Waiting related stuff is removed from UserDefaults as irrelevant.
     if (attStatus != 0) {
         // Delete att_waiting_seconds key from UserDefaults.
         [ADJUserDefaults removeAttWaitingRemainingSeconds];

Adjust/Internal/ADJRequestHandler.m

@@ -189,11 +189,9 @@ - (nonnull NSString *)urlWithParams:(nonnull NSMutableDictionary *)params
 
     // checking consent related parameters at the package creation moment
     NSString *attStatusString = [responseData.sdkPackage.parameters objectForKey:@"att_status"];
-    BOOL wasConsentWhenCreated = NO;
-    if (attStatusString != nil) {
-        wasConsentWhenCreated = [ADJUtil shouldUseConsentParamsForActivityKind:responseData.activityKind
-                                                                       andAttStatus:attStatusString.intValue];
-    }
+    int paramsAttStatus = (attStatusString != nil) ? attStatusString.intValue : -1;
+    BOOL wasConsentWhenCreated = [ADJUtil shouldUseConsentParamsForActivityKind:responseData.activityKind
+                                                                   andAttStatus:paramsAttStatus];
 
     // checking consent related parameters at the package sending moment
     int attStatus = -1;
@@ -460,8 +458,6 @@ - (void)handleResponseWithData:(NSData *)data
     [self injectParameters:mergedParameters kvArray:kvParameters];
 
     NSString *bodyString = [kvParameters componentsJoinedByString:@"&"];
-    [self.logger verbose:@"Body (String) to send: [%@]", bodyString];
-
     NSData *body = [NSData dataWithBytes:bodyString.UTF8String length:bodyString.length];
     [request setHTTPBody:body];
     return request;