Skip to content

Commit 6841938

Browse files
committed
Add test cleanup from #16
1 parent 095cdfa commit 6841938

File tree

7 files changed

+353
-379
lines changed

7 files changed

+353
-379
lines changed

.rspec

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1-
--color
1+
--color
2+
--require spec_helper

spec/checkbox_examples_spec.rb

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
1-
# encoding: utf-8
2-
$LOAD_PATH << File.join(File.dirname(__FILE__), '..', 'lib')
3-
require 'html2confluence'
4-
51
describe HTMLToConfluenceParser, "when running checkbox examples" do
2+
let(:parser) { HTMLToConfluenceParser.new }
63

74
it "should match checkboxes" do
85
html = <<-END
@@ -17,16 +14,14 @@
1714
END
1815

1916
markup = <<-END
20-
* (/) Example 1
21-
* (/) Example 2
22-
* (x) Example 3
23-
* (/) Example 4
24-
* (x) Example 5
17+
* (/) Example 1
18+
* (/) Example 2
19+
* (x) Example 3
20+
* (/) Example 4
21+
* (x) Example 5
2522
END
2623

27-
parser = HTMLToConfluenceParser.new
2824
parser.feed(html)
2925
expect(parser.to_wiki_markup.strip).to include(markup.strip)
3026
end
31-
3227
end

spec/combination_examples_spec.rb

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
1-
# encoding: utf-8
2-
$LOAD_PATH << File.join(File.dirname(__FILE__), '..', 'lib')
3-
require 'html2confluence'
4-
51
describe HTMLToConfluenceParser, "when running combination examples" do
2+
let(:parser) { HTMLToConfluenceParser.new }
3+
64
it "should match complex examples" do
75
html = <<-END
86
<ol>
@@ -17,9 +15,7 @@
1715
# numbered *item* that is +underlined+.
1816
# list
1917
END
20-
21-
22-
parser = HTMLToConfluenceParser.new
18+
2319
parser.feed(html)
2420
expect(parser.to_wiki_markup.strip).to include(markup.strip)
2521
end
@@ -94,7 +90,6 @@
9490
h1. With +nice+ formatting.
9591
END
9692

97-
parser = HTMLToConfluenceParser.new
9893
parser.feed(html)
9994
expect(parser.to_wiki_markup.strip).to include(markup.strip)
10095
end
@@ -114,7 +109,6 @@
114109
{quote}
115110
END
116111

117-
parser = HTMLToConfluenceParser.new
118112
parser.feed(html)
119113
expect(parser.to_wiki_markup.strip).to include(markup.strip)
120114
end
@@ -127,7 +121,6 @@
127121

128122
markup = "Previous\n\n*Scenario 4a: Existing deletes their ID*\n*Given* I am an existing user"
129123

130-
parser = HTMLToConfluenceParser.new
131124
parser.feed(html)
132125
expect(parser.to_wiki_markup.strip).to eq(markup)
133126
end
@@ -141,7 +134,6 @@
141134

142135
markup = "Previous line\n\n*Scenario 4a: Existing deletes their ID*\n*Given* I am an existing user"
143136

144-
parser = HTMLToConfluenceParser.new
145137
parser.feed(html)
146138
expect(parser.to_wiki_markup.strip).to eq(markup)
147139
end
@@ -151,7 +143,6 @@
151143

152144
markup = "*And* first line\n\n*second line*"
153145

154-
parser = HTMLToConfluenceParser.new
155146
parser.feed(html)
156147
expect(parser.to_wiki_markup.strip).to eq(markup)
157148
end
@@ -161,7 +152,6 @@
161152

162153
markup = "!a source!"
163154

164-
parser = HTMLToConfluenceParser.new
165155
parser.feed(html)
166156
expect(parser.to_wiki_markup.strip).to eq(markup)
167157
end
@@ -170,7 +160,6 @@
170160
html = "<div>familiar with the XML<wbr>Http<wbr>Request Object</div>\n\n"
171161

172162
markup = "familiar with the XMLHttpRequest Object"
173-
parser = HTMLToConfluenceParser.new
174163
parser.feed(html)
175164
expect(parser.to_wiki_markup.strip).to eq(markup)
176165

@@ -184,7 +173,6 @@
184173

185174
markup = "Previous line\n\n----"
186175

187-
parser = HTMLToConfluenceParser.new
188176
parser.feed(html)
189177
expect(parser.to_wiki_markup.strip).to eq(markup)
190178
end
@@ -196,7 +184,6 @@
196184

197185
markup = "A"
198186

199-
parser = HTMLToConfluenceParser.new
200187
parser.feed(html)
201188
expect(parser.to_wiki_markup.strip).to eq(markup)
202189
end
@@ -209,7 +196,6 @@
209196

210197
markup = "A"
211198

212-
parser = HTMLToConfluenceParser.new
213199
parser.feed(html)
214200
expect(parser.to_wiki_markup.strip).to eq(markup)
215201
end

spec/complex_tables_spec.rb

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
1-
# encoding: utf-8
2-
$LOAD_PATH << File.join(File.dirname(__FILE__), '..', 'lib')
3-
require 'html2confluence'
4-
51
describe HTMLToConfluenceParser, "when running complex tables examples" do
6-
it "should handle table with newlines" do
2+
let(:parser) { HTMLToConfluenceParser.new }
3+
4+
it "should handle table with newlines" do
75
html = <<-END
86
<table class="mce-item-table"><tbody><tr><td>As a...</td><td>I would like...</td><td>Because...</td></tr><tr><td><p>Student<br>or</p><p>Teacher</p></td><td>There to be more candy</td><td><p>Candy is:</p><ul><li>Delicious</li><li>Shiny</li><li>Good for my teeth</li></ul></td></tr></tbody></table>
97
END
@@ -20,12 +18,11 @@
2018
* Good for my teeth|
2119
END
2220

23-
parser = HTMLToConfluenceParser.new
2421
parser.feed(html)
2522
expect(parser.to_wiki_markup.strip).to include(markup.strip)
2623
end
2724

28-
it "should handle table empty cells" do
25+
it "should handle table empty cells" do
2926
html = <<-END
3027
<table class="mce-item-table"><tbody><tr><td><p><br data-mce-bogus="1"></p></td><td>Empty</td><td><p><br data-mce-bogus="1"></p></td></tr></tbody></table>
3128
END
@@ -34,12 +31,11 @@
3431
| |Empty| |
3532
END
3633

37-
parser = HTMLToConfluenceParser.new
3834
parser.feed(html)
3935
expect(parser.to_wiki_markup.strip).to include(markup.strip)
4036
end
4137

42-
it "should handle pre in table empty cells" do
38+
it "should handle pre in table empty cells" do
4339
html = <<-END
4440
<table><tbody><tr><td><pre>a</pre></td><td>d</td></tr><tr><td><pre>b</pre></td><td>c</td></tr></tbody></table>
4541
END
@@ -51,12 +47,11 @@
5147
b{noformat} |c |
5248
END
5349

54-
parser = HTMLToConfluenceParser.new
5550
parser.feed(html)
5651
expect(parser.to_wiki_markup.strip).to include(markup.strip)
5752
end
5853

59-
it "should handle pre in table" do
54+
it "should handle pre in table" do
6055
html = <<-END
6156
<table><tbody>
6257
<tr>
@@ -78,7 +73,6 @@
7873
2{noformat} |3 |
7974
END
8075

81-
parser = HTMLToConfluenceParser.new
8276
parser.feed(html)
8377
expect(parser.to_wiki_markup.strip).to include(markup.strip)
8478
end

0 commit comments

Comments
 (0)