Skip to content

ci: Updated the linter from pedantic to flutter_lints #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2025
Merged

ci: Updated the linter from pedantic to flutter_lints #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c1f1d5
ci: Updated the linter from pedantic to flutter_lints
ymmtyuhei Oct 23, 2025
dd16f57
refactor: simplify string interpolation in SmartNetworkAssetLoader
ymmtyuhei Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#https://dart.dev/guides/language/analysis-options
include: package:pedantic/analysis_options.yaml
include: package:lints/recommended.yaml
6 changes: 2 additions & 4 deletions lib/src/smart_network_asset_loader.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ class SmartNetworkAssetLoader extends AssetLoader {

// still nothing? Load from assets
if (string == '') {
string = await rootBundle
.loadString(assetsPath + '/' + locale.toString() + '.json');
string = await rootBundle.loadString('$assetsPath/$locale.json');
}

// then returns the json file
Expand Down Expand Up @@ -85,8 +84,7 @@ class SmartNetworkAssetLoader extends AssetLoader {
Future<String> loadFromNetwork(String localeName) async {
String url = localeUrl(localeName);

url = url + '' + localeName + '.json';

url = '$url$localeName.json';
try {
final response =
await Future.any([http.get(Uri.parse(url)), Future.delayed(timeout)]);
Expand Down