Actually use the base fee from the block header for txn validity

Author: jannotti

cmd/tealdbg/local.go

@@ -536,7 +536,7 @@ func (r *LocalRunner) RunAll() error {
 	start := time.Now()
 
 	sep := logic.NewSigEvalParams(r.txnGroup, &r.proto, &logic.NoHeaderLedger{})
-	aep := logic.NewAppEvalParams(txngroup, &r.proto, &transactions.SpecialAddresses{})
+	aep := logic.NewAppEvalParams(txngroup, &r.proto, &transactions.SpecialAddresses{}, basics.MicroAlgos{Raw: r.proto.MinTxnFee})
 	if r.debugger != nil {
 		t := logic.MakeEvalTracerDebuggerAdaptor(r.debugger)
 		sep.Tracer = t

cmd/tealdbg/localLedger_test.go

@@ -112,7 +112,7 @@ int 2
 	a.NoError(err)
 
 	proto := config.Consensus[protocol.ConsensusCurrentVersion]
-	ep := logic.NewAppEvalParams([]transactions.SignedTxnWithAD{{SignedTxn: txn}}, &proto, &transactions.SpecialAddresses{})
+	ep := logic.NewAppEvalParams([]transactions.SignedTxnWithAD{{SignedTxn: txn}}, &proto, &transactions.SpecialAddresses{}, basics.MicroAlgos{Raw: proto.MinTxnFee})
 	pass, delta, err := ba.StatefulEval(0, ep, appIdx, program)
 	a.NoError(err)
 	a.True(pass)

daemon/algod/api/algod.oas2.json

@@ -4710,7 +4710,7 @@
             "type": "string"
           },
           "fee": {
-            "description": "Fee id deprecated. It used to express the per-byte fee escalation.",
+            "description": "Fee is deprecated. It used to express the per-byte fee escalation.",
             "type": "integer",
             "x-go-type": "uint64"
           },

daemon/algod/api/algod.oas3.yml

@@ -932,7 +932,7 @@
                   "type": "string"
                 },
                 "fee": {
-                  "description": "Fee id deprecated. It used to express the per-byte fee escalation.",
+                  "description": "Fee is deprecated. It used to express the per-byte fee escalation.",
                   "type": "integer",
                   "x-go-type": "uint64"
                 },
@@ -7272,7 +7272,7 @@
                       "type": "string"
                     },
                     "fee": {
-                      "description": "Fee id deprecated. It used to express the per-byte fee escalation.",
+                      "description": "Fee is deprecated. It used to express the per-byte fee escalation.",
                       "type": "integer",
                       "x-go-type": "uint64"
                     },

daemon/algod/api/server/v2/dryrun.go

@@ -433,7 +433,7 @@ func doDryrunRequest(dr *DryrunRequest, response *model.DryrunResponse) {
 	proto := config.Consensus[protocol.ConsensusVersion(dr.ProtocolVersion)]
 	txgroup := transactions.WrapSignedTxnsWithAD(dr.Txns)
 	specials := transactions.SpecialAddresses{}
-	ep := logic.NewAppEvalParams(txgroup, &proto, &specials)
+	ep := logic.NewAppEvalParams(txgroup, &proto, &specials, basics.MicroAlgos{Raw: uint64(proto.MinTxnFee)})
 	sep := logic.NewSigEvalParams(dr.Txns, &proto, &dl)
 
 	origEnableAppCostPooling := proto.EnableAppCostPooling