Remove the old "out of protocol" congestion checking

Author: jannotti

cmd/algod/main.go

@@ -478,7 +478,6 @@ var startupConfigCheckFields = []string{
 	"OutgoingMessageFilterBucketSize",
 	"ProposalAssemblyTime",
 	"ReservedFDs",
-	"TxPoolExponentialIncreaseFactor",
 	"TxPoolSize",
 	"VerifiedTranscationsCacheSize",
 	"EnableP2P",

cmd/goal/clerk.go

@@ -432,7 +432,7 @@ var sendCmd = &cobra.Command{
 
 		// ConstructPayment fills in the suggested fee when fee=0. But if the user actually used --fee=0 on the
 		// commandline, we ought to do what they asked (especially now that zero or low fees make sense in
-		// combination with other txns that cover the groups's fee.
+		// combination with other txns that cover the groups's fee).
 		explicitFee := cmd.Flags().Changed("fee")
 		if explicitFee {
 			payment.Fee = basics.MicroAlgos{Raw: fee}

config/localTemplate.go

@@ -228,7 +228,7 @@ type Local struct {
 	// FallbackDNSResolverAddress defines the fallback DNS resolver address that would be used if the system resolver would fail to retrieve SRV records.
 	FallbackDNSResolverAddress string `version[0]:""`
 
-	// TxPoolExponentialIncreaseFactor exponential increase factor of transaction pool's fee threshold, should always be 2 in production.
+	// TxPoolExponentialIncreaseFactor is deprecated and unused.
 	TxPoolExponentialIncreaseFactor uint64 `version[0]:"2"`
 
 	// SuggestedFeeBlockHistory is deprecated and unused.

daemon/algod/api/algod.oas2.json

@@ -3403,7 +3403,7 @@
     "Box": {
       "description": "Box name and its content.",
       "type": "object",
-      "required": ["round","name","value"],
+      "required": ["round", "name", "value"],
       "properties": {
         "round": {
           "description": "The round for which this information is relevant",
@@ -3425,9 +3425,7 @@
     "BoxDescriptor": {
       "description": "Box descriptor describes a Box.",
       "type": "object",
-      "required": [
-        "name"
-      ],
+      "required": ["name"],
       "properties": {
         "name": {
           "description": "Base64 encoded box name",
@@ -4712,7 +4710,7 @@
             "type": "string"
           },
           "fee": {
-            "description": "Fee is the suggested transaction fee\nFee is in units of micro-Algos per byte.\nFee may fall to zero but transactions must still have a fee of\nat least MinTxnFee for the current network protocol.",
+            "description": "Fee id deprecated. It used to express the per-byte fee escalation.",
             "type": "integer",
             "x-go-type": "uint64"
           },
@@ -4734,6 +4732,11 @@
             "description": "The minimum transaction fee (not per byte) required for the\ntxn to validate for the current network protocol.",
             "type": "integer",
             "x-go-type": "uint64"
+          },
+          "base-fee": {
+            "description": "The current base transaction fee (not per byte) required for the\ntxn to validate.",
+            "type": "integer",
+            "x-go-type": "uint64"
           }
         }
       }

daemon/algod/api/algod.oas3.yml

@@ -922,12 +922,17 @@
             "schema": {
               "description": "TransactionParams contains the parameters that help a client construct\na new transaction.",
               "properties": {
+                "base-fee": {
+                  "description": "The current base transaction fee (not per byte) required for the\ntxn to validate.",
+                  "type": "integer",
+                  "x-go-type": "uint64"
+                },
                 "consensus-version": {
                   "description": "ConsensusVersion indicates the consensus protocol version\nas of LastRound.",
                   "type": "string"
                 },
                 "fee": {
-                  "description": "Fee is the suggested transaction fee\nFee is in units of micro-Algos per byte.\nFee may fall to zero but transactions must still have a fee of\nat least MinTxnFee for the current network protocol.",
+                  "description": "Fee id deprecated. It used to express the per-byte fee escalation.",
                   "type": "integer",
                   "x-go-type": "uint64"
                 },
@@ -7257,12 +7262,17 @@
                 "schema": {
                   "description": "TransactionParams contains the parameters that help a client construct\na new transaction.",
                   "properties": {
+                    "base-fee": {
+                      "description": "The current base transaction fee (not per byte) required for the\ntxn to validate.",
+                      "type": "integer",
+                      "x-go-type": "uint64"
+                    },
                     "consensus-version": {
                       "description": "ConsensusVersion indicates the consensus protocol version\nas of LastRound.",
                       "type": "string"
                     },
                     "fee": {
-                      "description": "Fee is the suggested transaction fee\nFee is in units of micro-Algos per byte.\nFee may fall to zero but transactions must still have a fee of\nat least MinTxnFee for the current network protocol.",
+                      "description": "Fee id deprecated. It used to express the per-byte fee escalation.",
                       "type": "integer",
                       "x-go-type": "uint64"
                     },