chore: make clippy happy again

Author: ArjixWasTaken

src/modules/function/invocation.rs

@@ -148,10 +148,13 @@ impl TranslateModule for FunctionInvocation {
                 arg.get_var_translated_name().unwrap()
             } else {
                 let translation = arg.translate_eval(meta, false);
+
                 // If the argument is an array, we have to get just the "name[@]" part
-                (translation.starts_with("\"${") && translation.ends_with("[@]}\""))
-                    .then(|| translation.get(3..translation.len() - 2).unwrap().to_string())
-                    .unwrap_or(translation)
+                if translation.starts_with("\"${") && translation.ends_with("[@]}\"") {
+                    translation.get(3..translation.len() - 2).unwrap().to_string()
+                } else {
+                    translation
+                }
             }
         }).collect::<Vec<String>>().join(" ");
 

src/modules/variable/init.rs

@@ -96,8 +96,8 @@ impl SyntaxModule<ParserMetadata> for VariableInit {
                     panic!("Expected array type for destructured variable");
                 }
 
-                for mut def in &mut definitions {
-                    self.handle_add_variable(meta, &mut def)?;
+                for def in &mut definitions {
+                    self.handle_add_variable(meta, def)?;
                 }
 
                 self.is_global_ctx = definitions.iter().any(|x| x.global_id.is_some());
@@ -124,7 +124,6 @@ impl TranslateModule for VariableInit {
             expr = format!("({expr})");
         }
 
-        let mut idx = 0;
         let is_destructured = self.definitions.len() > 1;
         let mut out = String::new();
 
@@ -160,11 +159,11 @@ impl TranslateModule for VariableInit {
             );
         }
 
-        for def in &self.definitions {
+        for (idx, def) in self.definitions.iter().enumerate() {
             let expr = if is_destructured {
                 format!("${{{}[{}]}};\n", reference.clone().unwrap(), idx)
             } else {
-                format!("{}", expr)
+                expr.clone()
             };
 
             if let Some(id) = def.global_id {
@@ -174,8 +173,6 @@ impl TranslateModule for VariableInit {
             } else {
                 out.push_str(format!("{name}={expr}", name = def.name).as_str())
             }
-
-            idx += 1;
         }
 
         out