.github: Allow individual steps to fail

So we can show a pretty red X on the GUI, by returning error codes from
the bash methods, beyond the fail environment variable.

Signed-off-by: Jorge Marques <[email protected]>

Author: gastmaier

.github/workflows/build.yml

@@ -37,6 +37,7 @@ jobs:
   build:
     timeout-minutes: 7200
     runs-on: [self-hosted, v1]
+    continue-on-error: true
 
     outputs:
       fail: ${{ steps.assert.outputs.fail }}
@@ -101,54 +102,63 @@ jobs:
         source ci/build.sh
         compile_kernel
 
+    - name: Prepare dist
+      run: |
+        if [[ -d dist ]]; then
+          rm -r dist
+        fi
+        mkdir -p dist/modules
+        cp defconfig dist
+        cp arch/${{ inputs.ARCH }}/boot/*Image dist
+        find . -type f -name *.ko | \
+          xargs -I % cp --parents % dist/modules
+
     - name: Assert compiled
       if: ${{ env.AUTO_FROM_RANGE == 'true' }}
       run: |
         source ci/build.sh
         assert_compiled
 
+    - name: Assert state
+      if: ${{ failure() }}
+      run: |
+        source ci/build.sh
+        set_step_fail "assert_state"
+        echo "fatal=true" >> "$GITHUB_ENV"
+
     - name: Sparse
-      if: ${{ env.CHECKS_SPARCE == 'true' }}
+      if: ${{ !cancelled() && env.fatal != 'true' && env.CHECKS_SPARCE == 'true' }}
       run: |
         source ci/build.sh
         compile_kernel_sparse
 
     - name: GCC fanalyzer
-      if: ${{ env.CHECKS_GCC_FANALYZER == 'true' }}
+      if: ${{ !cancelled() && env.fatal != 'true' && env.CHECKS_GCC_FANALYZER == 'true' }}
       run: |
         source ci/build.sh
         compile_gcc_fanalyzer
 
     - name: Clang analyzer
-      if: ${{ env.CHECKS_CLANG_ANALYZER == 'true' }}
+      if: ${{ !cancelled() && env.fatal != 'true' && env.CHECKS_CLANG_ANALYZER == 'true' }}
       run: |
         source ci/build.sh
         compile_clang_analyzer
 
     - name: Smatch
-      if: ${{ env.CHECKS_SMATCH == 'true' }}
+      if: ${{ !cancelled() && env.fatal != 'true' && env.CHECKS_SMATCH == 'true' }}
       run: |
         source ci/build.sh
         compile_kernel_smatch
 
-    - name: Prepare dist
-      run: |
-        if [[ -d dist ]]; then
-          rm -r dist
-        fi
-        mkdir -p dist/modules
-        cp defconfig dist
-        cp arch/${{ inputs.ARCH }}/boot/*Image dist
-        find . -type f -name *.ko | \
-          xargs -I % cp --parents % dist/modules
-
     - name: Store the distribution packages
+      if: ${{ !cancelled() }}
       uses: actions/upload-artifact@v4
       with:
         name: dist-${{ inputs.DEFCONFIG }}-${{ env.CID }}-${{ inputs.ARCH }}
         path: dist
 
-    - name: Assert compile
+    - name: Export labels
+      if: ${{ !cancelled() }}
       id: assert
       run: |
         source ci/runner_env.sh

.github/workflows/checks.yml

@@ -7,6 +7,8 @@ on:
         required: true
         type: string
     outputs:
+      fatal:
+        value: ${{ jobs.checks.outputs.fatal}}
       fail:
         value: ${{ jobs.checks.outputs.fail }}
       warn:
@@ -16,8 +18,10 @@ jobs:
   checks:
     timeout-minutes: 7200
     runs-on: [self-hosted, v1]
+    continue-on-error: true
 
     outputs:
+      fatal: ${{ steps.assert.outputs.fatal }}
       fail: ${{ steps.assert.outputs.fail }}
       warn: ${{ steps.assert.outputs.warn }}
 
@@ -29,32 +33,45 @@ jobs:
         source ci/build.sh
         apply_prerun
 
+    - name: Assert state
+      if: ${{ failure() }}
+      run: |
+        source ci/build.sh
+        set_step_fail "assert_state"
+        echo "fatal=true" >> "$GITHUB_ENV"
+
     - name: License
+      if: ${{ !cancelled() && env.fatal != 'true' }}
       run: |
         source ci/build.sh
         check_license
 
     - name: Check patch
+      if: ${{ !cancelled() && env.fatal != 'true' }}
       run: |
         source ci/build.sh
         export -f check_checkpatch set_step_fail set_step_warn
-        timeout 1d bash -c "check_checkpatch" || \
-          echo "step_fail_checkpatch_timeout=true" >> "$GITHUB_ENV"
+        status=0; timeout 1d bash -c "check_checkpatch" || status=$?
+        [ $status -eq 124 ] && echo "step_fail_checkpatch_timeout=true" >> "$GITHUB_ENV"
+        exit $status
 
     - name: Coccicheck
+      if: ${{ !cancelled() && env.fatal != 'true' }}
       run: |
         source ci/build.sh
         export -f check_coccicheck set_step_fail set_step_warn
-        timeout 1d bash -c "check_coccicheck" || \
-          echo "step_fail_coccicheck_timeout=true" >> "$GITHUB_ENV"
+        status=0; timeout 1d bash -c "check_coccicheck" || status=$?
+        [ $status -eq 124 ] && echo "step_fail_coccicheck_timeout=true" >> "$GITHUB_ENV"
+        exit $status
 
     - name: CPP Check
+      if: ${{ !cancelled() && env.fatal != 'true' }}
       run: |
         source ci/build.sh
         check_cppcheck
 
     - name: Checkout and patch reference branch
-      if: ${{ !startsWith(github.base_ref, 'mirror/') && !startsWith(github.ref_name, 'mirror/') }}
+      if: ${{ !cancelled() && env.fatal != 'true' && !startsWith(github.base_ref, 'mirror/') && !startsWith(github.ref_name, 'mirror/') }}
       run: |
         git fetch origin --depth=1 "${{ inputs.ref_branch }}" &&
         git reset --hard origin/${{ inputs.ref_branch }} ||
@@ -90,18 +107,21 @@ jobs:
         done <<< "$files"
 
     - name: Check dt-bindings
+      if: ${{ !cancelled() && env.fatal != 'true' }}
       run: |
         source ci/build.sh
         check_dt_binding_check
 
     - name: Revert patch reference branch
-      if: ${{ !startsWith(github.base_ref, 'mirror/') && !startsWith(github.ref_name, 'mirror/') }}
+      if: ${{ !cancelled() && env.fatal != 'true' && !startsWith(github.base_ref, 'mirror/') && !startsWith(github.ref_name, 'mirror/') }}
       run: |
         git reset --hard $head_sha
 
-    - name: Assert checks
+    - name: Export labels
+      if: ${{ !cancelled() }}
       id: assert
       run: |
-        echo "warn=$(printenv | grep ^step_warn_ | grep -v =$ | tr '\n' ',' | sed 's/,$//')" >> "$GITHUB_OUTPUT"
-        echo "fail=$(printenv | grep ^step_fail_ | grep -v =$ | tr '\n' ',' | sed 's/,$//')" >> "$GITHUB_OUTPUT"
+        echo "fatal=$fatal" >> "$GITHUB_OUTPUT"
+        source ci/runner_env.sh
+        export_labels
 

.github/workflows/top-level.yml

@@ -27,6 +27,7 @@ jobs:
   build_gcc_x86_64:
     uses: ./.github/workflows/build.yml
     needs: [checks]
+    if: needs.checks.outputs.fatal != 'true'
     secrets: inherit
     with:
       CXX: "14"
@@ -35,6 +36,7 @@ jobs:
   build_llvm_x86_64:
     uses: ./.github/workflows/build.yml
     needs: [checks]
+    if: needs.checks.outputs.fatal != 'true'
     secrets: inherit
     with:
       LLVM: "19"
@@ -44,6 +46,7 @@ jobs:
   build_gcc_aarch64:
     uses: ./.github/workflows/build.yml
     needs: [checks]
+    if: needs.checks.outputs.fatal != 'true'
     secrets: inherit
     with:
       CXX: "14"
@@ -52,7 +55,6 @@ jobs:
       DEFCONFIG: "adi_ci_defconfig"
   build_gcc_arm:
     uses: ./.github/workflows/build.yml
-    #needs: [checks]
     secrets: inherit
     with:
       CXX: "14"