Change to pytest

Author: andrewrabert

pyproject.toml

@@ -35,4 +35,12 @@ source = "vcs"
 packages = ["harmonize"]
 
 [dependency-groups]
-dev = []
+dev = [
+    "pytest>=6.0.0",
+]
+
+[tool.pytest.ini_options]
+testpaths = ["tests"]
+python_files = ["test_*.py"]
+python_classes = ["Test*"]
+python_functions = ["test_*"]

tests/test_app.py

@@ -1,145 +1,139 @@
 import pathlib
 import shutil
 import subprocess
-import unittest
+
+import pytest
 
 from tests import helpers
 
 TMP = pathlib.Path(__file__).parent.joinpath('tmp')
 
 
-class TestApp(unittest.TestCase):
-
-    def setUp(self):
-        try:
-            shutil.rmtree(TMP)
-        except FileNotFoundError:
-            pass
-        TMP.mkdir()
-
-    def test_copies_other_file_type(self):
-        source_dir = TMP / 'source'
-        source_dir.mkdir()
-        target_dir = TMP / 'target'
-        text_file = source_dir / 'other.txt'
-        text_file.write_text('test file')
-
-        proc = subprocess.run(
-            ['harmonize', str(source_dir), str(target_dir)],
-            stderr=subprocess.PIPE,
-            stdout=subprocess.PIPE,
-            check=True)
-        self.assertEqual(proc.stdout, b'')
-        self.assertEqual(
-            proc.stderr.decode(),
-            (f'Scanning "{source_dir}"\n'
-             'Scanned 1 items\n'
-             f'Copying {text_file}\n'
-             'Processing complete\n'))
-
-        self.assertEqual(
-            text_file.read_text(),
-            (target_dir / 'other.txt').read_text())
-
-    def test_transcodes_flac_to_mp3(self):
-        source_dir = TMP / 'source'
-        source_dir.mkdir()
-        target_dir = TMP / 'target'
-        audio_file = source_dir / 'audio.flac'
-        helpers.ffmpeg.generate_silence(1, audio_file)
-
-        proc = subprocess.run(
-            ['harmonize', str(source_dir), str(target_dir)],
-            stderr=subprocess.PIPE,
-            stdout=subprocess.PIPE,
-            check=True)
-        self.assertEqual(proc.stdout, b'')
-        self.assertEqual(
-            proc.stderr.decode(),
-            (f'Scanning "{source_dir}"\n'
-             'Scanned 1 items\n'
-             f'Transcoding {audio_file}\n'
-             'Processing complete\n'))
-
-        metadata = helpers.ffprobe.get_metadata(target_dir / 'audio.mp3')
-
-        self.assertEqual('mp3', metadata['format']['format_name'])
-        self.assertEqual(1, len(metadata['streams']))
-        self.assertEqual('mp3', metadata['streams'][0]['codec_name'])
-        # mp3 will not be exact duration as input
-        self.assertTrue(1 <= float(metadata['format']['duration']) <= 1.1)
-
-    def test_transcodes_flac_to_opus(self):
-        source_dir = TMP / 'source'
-        source_dir.mkdir()
-        target_dir = TMP / 'target'
-        helpers.ffmpeg.generate_silence(1, source_dir / 'audio.flac')
-
-        proc = subprocess.run(
-            ['harmonize', '--codec', 'opus', str(source_dir), str(target_dir)],
-            stderr=subprocess.PIPE,
-            stdout=subprocess.PIPE,
-            check=True)
-        self.assertEqual(proc.stdout, b'')
-        self.assertEqual(
-            proc.stderr.decode(),
-            (f'Scanning "{source_dir}"\n'
-             'Scanned 1 items\n'
-             f'Transcoding {source_dir}/audio.flac\n'
-             'Processing complete\n'))
-
-        metadata = helpers.ffprobe.get_metadata(target_dir / 'audio.opus')
-
-        self.assertEqual('ogg', metadata['format']['format_name'])
-        self.assertEqual(1, len(metadata['streams']))
-        self.assertEqual('opus', metadata['streams'][0]['codec_name'])
+@pytest.fixture(autouse=True)
+def setup_tmp_dir():
+    try:
+        shutil.rmtree(TMP)
+    except FileNotFoundError:
+        pass
+    TMP.mkdir()
+    yield
+    try:
+        shutil.rmtree(TMP)
+    except FileNotFoundError:
+        pass
+
+def test_copies_other_file_type():
+    source_dir = TMP / 'source'
+    source_dir.mkdir()
+    target_dir = TMP / 'target'
+    text_file = source_dir / 'other.txt'
+    text_file.write_text('test file')
+
+    proc = subprocess.run(
+        ['harmonize', str(source_dir), str(target_dir)],
+        stderr=subprocess.PIPE,
+        stdout=subprocess.PIPE,
+        check=True)
+    assert proc.stdout == b''
+    assert proc.stderr.decode() == (
+        f'Scanning "{source_dir}"\n'
+        'Scanned 1 items\n'
+        f'Copying {text_file}\n'
+        'Processing complete\n')
+
+    assert text_file.read_text() == (target_dir / 'other.txt').read_text()
+
+def test_transcodes_flac_to_mp3():
+    source_dir = TMP / 'source'
+    source_dir.mkdir()
+    target_dir = TMP / 'target'
+    audio_file = source_dir / 'audio.flac'
+    helpers.ffmpeg.generate_silence(1, audio_file)
+
+    proc = subprocess.run(
+        ['harmonize', str(source_dir), str(target_dir)],
+        stderr=subprocess.PIPE,
+        stdout=subprocess.PIPE,
+        check=True)
+    assert proc.stdout == b''
+    assert proc.stderr.decode() == (
+        f'Scanning "{source_dir}"\n'
+        'Scanned 1 items\n'
+        f'Transcoding {audio_file}\n'
+        'Processing complete\n')
+
+    metadata = helpers.ffprobe.get_metadata(target_dir / 'audio.mp3')
+
+    assert metadata['format']['format_name'] == 'mp3'
+    assert len(metadata['streams']) == 1
+    assert metadata['streams'][0]['codec_name'] == 'mp3'
+    # mp3 will not be exact duration as input
+    assert 1 <= float(metadata['format']['duration']) <= 1.1
+
+def test_transcodes_flac_to_opus():
+    source_dir = TMP / 'source'
+    source_dir.mkdir()
+    target_dir = TMP / 'target'
+    helpers.ffmpeg.generate_silence(1, source_dir / 'audio.flac')
+
+    proc = subprocess.run(
+        ['harmonize', '--codec', 'opus', str(source_dir), str(target_dir)],
+        stderr=subprocess.PIPE,
+        stdout=subprocess.PIPE,
+        check=True)
+    assert proc.stdout == b''
+    assert proc.stderr.decode() == (
+        f'Scanning "{source_dir}"\n'
+        'Scanned 1 items\n'
+        f'Transcoding {source_dir}/audio.flac\n'
+        'Processing complete\n')
+
+    metadata = helpers.ffprobe.get_metadata(target_dir / 'audio.opus')
+
+    assert metadata['format']['format_name'] == 'ogg'
+    assert len(metadata['streams']) == 1
+    assert metadata['streams'][0]['codec_name'] == 'opus'
+    # mp3 will not be exact duration as input
+    assert 1 <= float(metadata['format']['duration']) <= 1.1
+
+def test_multiple_mixed_audio_and_other_files():
+    source_dir = TMP / 'source'
+    source_dir.mkdir()
+    target_dir = TMP / 'target'
+
+    text_file = source_dir / 'other.txt'
+    text_file.write_text('test file')
+
+    for duration in range(1, 4):
+        helpers.ffmpeg.generate_silence(
+            duration, source_dir / f'{duration}.flac')
+
+    proc = subprocess.run(
+        ['harmonize', str(source_dir), str(target_dir)],
+        stderr=subprocess.PIPE,
+        stdout=subprocess.PIPE,
+        check=True)
+    assert proc.stdout == b''
+
+    stderr = proc.stderr.decode().splitlines()
+    assert stderr[0:2] == [
+        f'Scanning "{source_dir}"',
+        'Scanned 4 items']
+    assert sorted(stderr[2:6]) == [
+        f'Copying {source_dir}/other.txt',
+        f'Transcoding {source_dir}/1.flac',
+        f'Transcoding {source_dir}/2.flac',
+        f'Transcoding {source_dir}/3.flac']
+    assert stderr[6] == 'Processing complete'
+
+    for duration in range(1, 4):
+        metadata = helpers.ffprobe.get_metadata(
+            target_dir / f'{duration}.mp3')
+
+        assert metadata['format']['format_name'] == 'mp3'
+        assert len(metadata['streams']) == 1
+        assert metadata['streams'][0]['codec_name'] == 'mp3'
         # mp3 will not be exact duration as input
-        self.assertTrue(1 <= float(metadata['format']['duration']) <= 1.1)
-
-    def test_multiple_mixed_audio_and_other_files(self):
-        source_dir = TMP / 'source'
-        source_dir.mkdir()
-        target_dir = TMP / 'target'
-
-        text_file = source_dir / 'other.txt'
-        text_file.write_text('test file')
-
-        for duration in range(1, 4):
-            helpers.ffmpeg.generate_silence(
-                duration, source_dir / f'{duration}.flac')
-
-        proc = subprocess.run(
-            ['harmonize', str(source_dir), str(target_dir)],
-            stderr=subprocess.PIPE,
-            stdout=subprocess.PIPE,
-            check=True)
-        self.assertEqual(proc.stdout, b'')
-
-        stderr = proc.stderr.decode().splitlines()
-        self.assertEqual(
-            stderr[0:2],
-            [f'Scanning "{source_dir}"',
-             'Scanned 4 items'])
-        self.assertEqual(
-            sorted(stderr[2:6]),
-            [f'Copying {source_dir}/other.txt',
-             f'Transcoding {source_dir}/1.flac',
-             f'Transcoding {source_dir}/2.flac',
-             f'Transcoding {source_dir}/3.flac'])
-        self.assertEqual(
-            stderr[6],
-            'Processing complete')
-
-        for duration in range(1, 4):
-            metadata = helpers.ffprobe.get_metadata(
-                target_dir / f'{duration}.mp3')
-
-            self.assertEqual('mp3', metadata['format']['format_name'])
-            self.assertEqual(1, len(metadata['streams']))
-            self.assertEqual('mp3', metadata['streams'][0]['codec_name'])
-            # mp3 will not be exact duration as input
-            self.assertTrue(duration <= float(metadata['format']['duration']) <= duration + 0.1)  # noqa: E501
-
-        self.assertEqual(
-            text_file.read_text(),
-            (target_dir / 'other.txt').read_text())
+        assert duration <= float(metadata['format']['duration']) <= duration + 0.1
+
+    assert text_file.read_text() == (target_dir / 'other.txt').read_text()