Skip to content

Commit 7b8d93e

Browse files
committed
fix: use explicit outputs for host directive
1 parent 848d451 commit 7b8d93e

File tree

2 files changed

+20
-9
lines changed

2 files changed

+20
-9
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angular-three-gltf",
3-
"version": "1.0.16",
3+
"version": "1.0.17",
44
"description": "GLTF to Angular Three converter",
55
"scripts": {
66
"cleanup": "rimraf node_modules"

src/utils/parser.js

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -641,8 +641,21 @@ ${printTypes(objects, animations)}
641641
hostDirectives: [
642642
{
643643
directive: NgtObjectEvents,
644-
inputs: NgtObjectEventsInputs,
645-
outputs: NgtObjectEventsOutputs,
644+
outputs: [
645+
'click',
646+
'dblclick',
647+
'contextmenu',
648+
'pointerup',
649+
'pointerdown',
650+
'pointerover',
651+
'pointerout',
652+
'pointerenter',
653+
'pointerleave',
654+
'pointermove',
655+
'pointermissed',
656+
'pointercancel',
657+
'wheel',
658+
],
646659
},
647660
],
648661
schemas: [CUSTOM_ELEMENTS_SCHEMA],
@@ -667,9 +680,6 @@ export class ${componentName} {
667680
: ""
668681
}
669682
670-
671-
private objectEvents = inject(NgtObjectEvents, { host: true });
672-
673683
constructor() {
674684
extend({ Group${ngtTypesArr.length ? ", " + ngtTypesArr.join(", ") : ""} });
675685
@@ -686,11 +696,12 @@ export class ${componentName} {
686696
: ""
687697
}
688698
699+
const objectEvents = inject(NgtObjectEvents, { host: true });
689700
effect(() => {
690-
const modelRef = this.modelRef()?.nativeElement;
691-
if (!modelRef) return;
701+
const model = this.modelRef()?.nativeElement;
702+
if (!model) return;
692703
693-
this.objectEvents.ngtObjectEvents.set(modelRef);
704+
this.objectEvents.ngtObjectEvents.set(model);
694705
}, { allowSignalWrites: true });
695706
}
696707
}`;

0 commit comments

Comments
 (0)