Merge pull request #83 from TomasTomecek/fix-78

sanity check container backend before using it

Author: TomasTomecek

ansible_bender/api.py

@@ -65,12 +65,15 @@ def build(self, build):
         self.db.record_build(build)
 
         builder = self.get_builder(build)
+        builder.sanity_check()
 
         # before we start messing with the base image, we need to check for its presence first
         if not builder.is_base_image_present():
             builder.pull()
             build.pulled = True
 
+        builder.check_container_creation()
+
         # let's record base image as a first layer
         base_image_id = builder.get_image_id(build.base_image)
         build.record_layer(None, base_image_id, None, cached=True)

ansible_bender/builders/base.py

@@ -104,3 +104,13 @@ def get_logs(self):
 
         :return: list of str
         """
+
+    def sanity_check(self):
+        """
+        invoke container tooling and thus verify they work well
+        """
+
+    def check_container_creation(self):
+        """
+        check that containers can be created
+        """

ansible_bender/builders/buildah_builder.py

@@ -273,3 +273,20 @@ def get_logs(self):
 
         :return: list of str
         """
+
+    def sanity_check(self):
+        """
+        invoke container tooling and thus verify they work well
+        """
+        # doing podman info would be super-handy, but it will immensely clutter the output
+        logger.debug("checking that podman command works")
+        run_cmd(["podman", "version"], log_stderr=True, log_output=True)
+        logger.debug("checking that buildah command works")
+        run_cmd(["buildah", "version"], log_stderr=True, log_output=True)
+
+    def check_container_creation(self):
+        """
+        check that containers can be created
+        """
+        logger.debug("trying to create a dummy container using podman")
+        podman_run_cmd(self.build.base_image, ["true"], log_stderr=True)

tests/unit/test_api.py

@@ -16,6 +16,7 @@ def test_build_pulls_base_img_if_not_present(application, build, is_base_present
     flexmock(BuildahBuilder)
     BuildahBuilder.should_receive("is_base_image_present").and_return(is_base_present).once()
     BuildahBuilder.should_receive("pull").times(times_called)
+    BuildahBuilder.should_receive("check_container_creation").and_return(None).once()
     BuildahBuilder.should_receive("get_image_id").and_return("1").once()
     BuildahBuilder.should_receive("find_python_interpreter").and_return("").once()
     BuildahBuilder.should_receive("create").once()