Community PRs Seem Ignored #4403
-
|
I’ve noticed that many pull requests from the community appear to be ignored, while only contributions from the core team are being reviewed and merged. If the project isn’t going to consider external contributions, why not disable the feature or clarify that in the repo. Are community PRs welcome at all? I made a simple one adding just a single query, and I see there are many such simple QOL pull requests being ignored. |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment
-
|
Hello @Digital39999 Generally the external contributions are welcome, but there is a problem that our team includes just a few members while the hundreds of issues, pull requests and discussions pending to be reviewed. The volume is overwhelming for the small team, so that the main reason of delay between contributions and reaction. Especially taking into account that right now I'm the only one online there and working on the project only sometimes when having free hours. I have just a collaborator role with low access rights, I can't even approve and merge my own pull request, let alone invite other people in the team. That why I'm focused on just keeping the project in working state (fixing critical bugs, documentation enhancements, updating deps, etc.) rather than adding new features. I hope on your understanding about that. Also note that we're not merging random features, because more endpoints basically means more maintenance efforts and more expenses on the hosting, This should be something good, smart and useful, or at least highly requested from the community to make decision about the merge. Anyway users can implement anything and deploy any branch from other users on their own instances. Regarding your pull request (#4303), I quickly checked it and seeing two problems: First of all. I thing that creating the JSON API will be redundant, since we are not providing any unique data. All the data we're showing on the cards is fetched directly from the GitHub API which can be performed by any other developer as well. So there is basically no much sense in that addition, I will be open to consider it only in case I would have an approval from another core team member or the enough high community request (at least 25-30 upvotes). The second reason is the state of code, it contains the redundant changes not related to the point (for example returning docs translations to the repository?) and the current implementation with query string parameter looks inconsistent increasing code complexity. In case we're going to merge it one day it definitely should be implemented as separate endpoints. I hope that this is comprehensive answer to your question. Feel free to contact me in case you'll have more. |
Beta Was this translation helpful? Give feedback.
Hello @Digital39999
Generally the external contributions are welcome, but there is a problem that our team includes just a few members while the hundreds of issues, pull requests and discussions pending to be reviewed. The volume is overwhelming for the small team, so that the main reason of delay between contributions and reaction. Especially taking into account that right now I'm the only one online there and working on the project only sometimes when having free hours. I have just a collaborator role with low access rights, I can't even approve and merge my own pull request, let alone invite other people in the team. That why I'm focused on just keeping the project in working state (fi…