Skip to content
This repository was archived by the owner on Nov 8, 2024. It is now read-only.

Commit d0980b1

Browse files
committed
fix: remove use of restrictred for-of syntax
Fixes #27
1 parent 48d4f94 commit d0980b1

File tree

4 files changed

+24
-25
lines changed

4 files changed

+24
-25
lines changed

.eslintrc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
"env": {
44
"mocha": true
55
},
6-
"rules": {
7-
"no-restricted-syntax": "off"
8-
},
96
"overrides": [
107
{
118
"files": "*-test.js",

src/APIBlueprintImporter.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,15 @@ export default class APIBlueprintImporter {
2828
}
2929

3030
canImport(context, items) {
31-
for (const item of items) {
31+
let isAPIBlueprint = false;
32+
33+
items.forEach((item) => {
3234
if (APIBlueprintParser.detect(item.content)) {
33-
return true
35+
isAPIBlueprint = true;
3436
}
35-
}
37+
});
3638

37-
return false;
39+
return isAPIBlueprint;
3840
}
3941

4042
async import(context, items, options) {

src/APIElementImporter.js

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -24,20 +24,20 @@ export default class APIElementImporter {
2424
// FIXME: Minim is treating object (array of member) as array
2525
const meta = api.attributes.get('metadata');
2626
if (meta) {
27-
for (const member of meta) {
27+
meta.forEach((member) => {
2828
if (member.key.content === 'HOST') {
2929
this.base = member.value.toValue();
3030
}
31-
}
31+
});
3232
}
3333

34-
for (const resourceGroup of api.resourceGroups) {
34+
api.resourceGroups.forEach((resourceGroup) => {
3535
this.importResourceGroup(resourceGroup);
36-
}
36+
});
3737

38-
for (const resource of api.resources) {
38+
api.resources.forEach((resource) => {
3939
this.importResource(resource);
40-
}
40+
});
4141
}
4242

4343
importResourceGroup(resourceGroup) {
@@ -46,14 +46,14 @@ export default class APIElementImporter {
4646
if (resourceGroup.title) {
4747
const group = this.context.createRequestGroup(coalesceElementValue(resourceGroup.title, 'Resource Group'));
4848

49-
for (const resource of resourceGroup.resources) {
49+
resourceGroup.resources.forEach((resource) => {
5050
const item = this.importResource(resource);
5151
group.appendChild(item);
52-
}
52+
});
5353
} else {
54-
for (const resource of resourceGroup.resources) {
54+
resourceGroup.resources.forEach((resource) => {
5555
this.importResource(resource);
56-
}
56+
});
5757
}
5858
}
5959

@@ -62,10 +62,10 @@ export default class APIElementImporter {
6262

6363
const group = this.context.createRequestGroup(coalesceElementValue(resource.title, 'Resource'));
6464

65-
for (const transition of resource.transitions) {
65+
resource.transitions.forEach((transition) => {
6666
const item = this.importTransition(resource, transition);
6767
group.appendChild(item);
68-
}
68+
});
6969

7070
return group;
7171
}
@@ -80,10 +80,10 @@ export default class APIElementImporter {
8080

8181
const group = this.context.createRequestGroup(coalesceElementValue(transition.title, 'Transition'));
8282

83-
for (const transaction of transition.transactions) {
83+
transition.transactions.forEach((transaction) => {
8484
const item = this.importTransaction(resource, transition, transaction);
8585
group.appendChild(item);
86-
}
86+
});
8787

8888
return group;
8989
}
@@ -108,9 +108,9 @@ export default class APIElementImporter {
108108
const pawRequest = this.context.createRequest(coalesceElementValue(request.title, transition.title, 'Transaction'), request.method.toValue(), url);
109109

110110
if (request.headers) {
111-
for (const header of request.headers) {
111+
request.headers.forEach((header) => {
112112
pawRequest.setHeader(header.key.toValue(), header.value.toValue());
113-
}
113+
});
114114
}
115115

116116
if (request.messageBody) {

test/importer-test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ fury.use(apibParser);
1616
describe('API Blueprint Importer', () => {
1717
const filenames = glob.sync(path.join(__dirname, 'fixtures', '*.apib'));
1818

19-
for (const filename of filenames) {
19+
filenames.forEach((filename) => {
2020
const name = path.basename(filename, path.extname(filename));
2121

2222
it(`can import ${name} fixture`, (done) => {
@@ -47,5 +47,5 @@ describe('API Blueprint Importer', () => {
4747
done();
4848
});
4949
});
50-
}
50+
});
5151
});

0 commit comments

Comments
 (0)