Upgrade Coding Standard

natanfelles · natanfelles · commit 33f47e39b7a2 · 2023-09-29T06:14:28.000-03:00
diff --git a/composer.json b/composer.json
@@ -63,7 +63,7 @@
     },
     "require-dev": {
         "ext-xdebug": "*",
-        "aplus/coding-standard": "^1.14",
+        "aplus/coding-standard": "^2.0",
         "ergebnis/composer-normalize": "^2.28",
         "jetbrains/phpstorm-attributes": "^1.0",
         "phpmd/phpmd": "^2.13",
diff --git a/src/App.php b/src/App.php
@@ -117,7 +117,7 @@ public function __construct(Config | array | string $config = null, bool $debug
         if (isset(static::$config)) {
             throw new LogicException('App already initialized');
         }
-        if ( ! $config instanceof Config) {
+        if (!$config instanceof Config) {
             $config = new Config($config);
         }
         static::$config = $config;
@@ -178,7 +178,7 @@ protected function loadExceptionHandler() : void
         if ($config->getDir() !== null) {
             $exceptionHandlerConfigs ??= $this->loadConfigs('exceptionHandler');
         }
-        if ( ! isset($exceptionHandlerConfigs['default'])) {
+        if (!isset($exceptionHandlerConfigs['default'])) {
             $environment = static::isDebugging()
                 ? ExceptionHandler::DEVELOPMENT
                 : ExceptionHandler::PRODUCTION;
@@ -230,8 +230,8 @@ protected function debugEnd() : void
     {
         static::$debugCollector->setEndTime()->setEndMemory();
         $response = static::router()->getResponse();
-        if ( ! $response->hasDownload()
-            && ! $response->getRequest()->isAjax()
+        if (!$response->hasDownload()
+            && !$response->getRequest()->isAjax()
             && \str_contains(
                 (string) $response->getHeader('Content-Type'),
                 'text/html'
@@ -492,7 +492,7 @@ protected static function addCommand(string $file, Console $console, Locator $lo
         if ($className === null) {
             return false;
         }
-        if ( ! \class_exists($className)) {
+        if (!\class_exists($className)) {
             Isolation::require($file);
         }
         $class = new ReflectionClass($className); // @phpstan-ignore-line
@@ -1033,7 +1033,7 @@ protected static function setRouter(string $instance, array $config = null) : Ro
         if (isset($config['auto_methods']) && $config['auto_methods'] === true) {
             $service->setAutoMethods();
         }
-        if ( ! empty($config['placeholders'])) {
+        if (!empty($config['placeholders'])) {
             $service->addPlaceholder($config['placeholders']);
         }
         if ($requireFiles && isset($config['files'])) {
@@ -1050,7 +1050,7 @@ protected static function setRouter(string $instance, array $config = null) : Ro
     protected static function requireRouterFiles(array $files) : void
     {
         foreach ($files as $file) {
-            if ( ! \is_file($file)) {
+            if (!\is_file($file)) {
                 throw new LogicException('Invalid router file: ' . $file);
             }
             Isolation::require($file);
@@ -1158,10 +1158,10 @@ protected static function setResponse(string $instance) : Response
     {
         $config = static::config()->get('response', $instance);
         $service = new Response(static::request($config['request_instance'] ?? 'default'));
-        if ( ! empty($config['headers'])) {
+        if (!empty($config['headers'])) {
             $service->setHeaders($config['headers']);
         }
-        if ( ! empty($config['auto_etag'])) {
+        if (!empty($config['auto_etag'])) {
             $service->setAutoEtag(
                 $config['auto_etag']['active'] ?? true,
                 $config['auto_etag']['hash_algo'] ?? null
diff --git a/src/Debug/AppCollector.php b/src/Debug/AppCollector.php
@@ -31,10 +31,10 @@ class AppCollector extends Collector
     public function setApp(App $app) : static
     {
         $this->app = $app;
-        if ( ! isset($this->startTime)) {
+        if (!isset($this->startTime)) {
             $this->setStartTime();
         }
-        if ( ! isset($this->startMemory)) {
+        if (!isset($this->startMemory)) {
             $this->setStartMemory();
         }
         return $this;
@@ -90,10 +90,10 @@ public function getActivities() : array
 
     public function getContents() : string
     {
-        if ( ! isset($this->endTime)) {
+        if (!isset($this->endTime)) {
             $this->setEndTime(\microtime(true));
         }
-        if ( ! isset($this->endMemory)) {
+        if (!isset($this->endMemory)) {
             $this->setEndMemory(\memory_get_usage());
         }
         \ob_start(); ?>
@@ -161,7 +161,7 @@ protected function getServices() : array
     {
         $result = [];
         foreach ($this->getData() as $data) {
-            if ( ! isset($result[$data['service']])) {
+            if (!isset($result[$data['service']])) {
                 $result[$data['service']] = [];
             }
             $result[$data['service']][] = [
@@ -180,7 +180,7 @@ protected function renderAvailableServices() : string
         $class = new ReflectionClass($this->app);
         $methods = $class->getMethods(ReflectionMethod::IS_STATIC);
         foreach ($methods as $method) {
-            if ( ! $method->isPublic()) {
+            if (!$method->isPublic()) {
                 continue;
             }
             $name = $method->getName();
@@ -196,7 +196,7 @@ protected function renderAvailableServices() : string
                 continue;
             }
             $param = $method->getParameters()[0] ?? null;
-            if ( ! $param || $param->getName() !== 'instance') {
+            if (!$param || $param->getName() !== 'instance') {
                 continue;
             }
             if ($param->getType()?->getName() !== 'string') { // @phpstan-ignore-line
diff --git a/src/Debug/ViewCollector.php b/src/Debug/ViewCollector.php
@@ -73,7 +73,7 @@ public function getContents() : string
 
     protected function renderRenderedViews() : string
     {
-        if ( ! $this->hasData()) {
+        if (!$this->hasData()) {
             return '<p>No view has been rendered.</p>';
         }
         $data = $this->getSortedData();
diff --git a/src/Entity.php b/src/Entity.php
@@ -140,7 +140,7 @@ protected function populate(array $properties) : void
 
     protected function setProperty(string $name, mixed $value) : void
     {
-        if ( ! \property_exists($this, $name)) {
+        if (!\property_exists($this, $name)) {
             throw $this->propertyNotDefined($name);
         }
         if ($value !== null) {
@@ -251,7 +251,7 @@ public function toModel() : array
 
     public function jsonSerialize() : stdClass
     {
-        if ( ! $this->getJsonVars()) {
+        if (!$this->getJsonVars()) {
             return new stdClass();
         }
         $allowed = \array_flip($this->getJsonVars());
@@ -268,7 +268,7 @@ protected function getObjectVars() : array
     {
         $result = [];
         foreach (\get_object_vars($this) as $key => $value) {
-            if ( ! \str_starts_with($key, '_')) {
+            if (!\str_starts_with($key, '_')) {
                 $result[$key] = $value;
             }
         }
diff --git a/src/Model.php b/src/Model.php
@@ -825,7 +825,7 @@ public function getValidationMessages() : array
      */
     protected function getValidationRules() : array
     {
-        if ( ! isset($this->validationRules)) {
+        if (!isset($this->validationRules)) {
             throw new RuntimeException('Validation rules are not set');
         }
         return $this->validationRules;
diff --git a/src/Validator.php b/src/Validator.php
@@ -38,7 +38,7 @@ public static function notUnique(
         int | string $ignoreValue = '',
         string $connection = 'default'
     ) : bool {
-        return ! static::unique(
+        return !static::unique(
             $field,
             $data,
             $tableColumn,
@@ -90,7 +90,7 @@ public static function unique(
             ->expressions(['count' => static fn () => 'COUNT(*)'])
             ->from($table)
             ->whereEqual($column, $value);
-        if ($ignoreColumn !== '' && ! \preg_match('#^{(\w+)}$#', $ignoreValue)) {
+        if ($ignoreColumn !== '' && !\preg_match('#^{(\w+)}$#', $ignoreValue)) {
             $statement->whereNotEqual($ignoreColumn, $ignoreValue);
         }
         return $statement->limit(1)->run()->fetch()->count < 1; // @phpstan-ignore-line
diff --git a/src/View.php b/src/View.php
@@ -66,7 +66,7 @@ public function __destruct()
     public function setBaseDir(string $baseDir) : static
     {
         $real = \realpath($baseDir);
-        if ( ! $real || ! \is_dir($real)) {
+        if (!$real || !\is_dir($real)) {
             throw new InvalidArgumentException("View base dir is not a valid directory: {$baseDir} ");
         }
         $this->baseDir = \rtrim($real, '\\/ ') . \DIRECTORY_SEPARATOR;
@@ -150,10 +150,10 @@ protected function getFilepath(string $view) : string
         }
         $view = $this->getBaseDir() . $view . $this->getExtension();
         $real = \realpath($view);
-        if ( ! $real || ! \is_file($real)) {
+        if (!$real || !\is_file($real)) {
             throw new InvalidArgumentException("View path does not match a file: {$view}");
         }
-        if ($this->getBaseDir() && ! \str_starts_with($real, $this->getBaseDir())) {
+        if ($this->getBaseDir() && !\str_starts_with($real, $this->getBaseDir())) {
             throw new InvalidArgumentException("View path out of base directory: {$real}");
         }
         return $real;
@@ -255,7 +255,7 @@ public function endBlock() : static
             echo \PHP_EOL . '<!-- Block end: ' . $block . ' -->' . \PHP_EOL;
         }
         $contents = \ob_get_clean();
-        if ( ! isset($this->blocks[$name])) {
+        if (!isset($this->blocks[$name])) {
             $this->blocks[$name] = $contents; // @phpstan-ignore-line
         }
         return $this;
@@ -367,7 +367,7 @@ protected function getContents(string $view, array $data) : string
         $data['view'] = $this;
         \ob_start();
         Isolation::require($this->getFilepath($view), $data);
-        if (isset($this->openBlock) && ! $this->inInclude) {
+        if (isset($this->openBlock) && !$this->inInclude) {
             $this->openBlock = null;
             $this->endBlock();
         }

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ public function __construct(Config \| array \| string $config = null, bool $debug`
`117`	`117`	`if (isset(static::$config)) {`
`118`	`118`	`throw new LogicException('App already initialized');`
`119`	`119`	`}`
`120`		`- if ( ! $config instanceof Config) {`
	`120`	`+ if (!$config instanceof Config) {`
`121`	`121`	`$config = new Config($config);`
`122`	`122`	`}`
`123`	`123`	`static::$config = $config;`
`@@ -178,7 +178,7 @@ protected function loadExceptionHandler() : void`
`178`	`178`	`if ($config->getDir() !== null) {`
`179`	`179`	`$exceptionHandlerConfigs ??= $this->loadConfigs('exceptionHandler');`
`180`	`180`	`}`
`181`		`- if ( ! isset($exceptionHandlerConfigs['default'])) {`
	`181`	`+ if (!isset($exceptionHandlerConfigs['default'])) {`
`182`	`182`	`$environment = static::isDebugging()`
`183`	`183`	`? ExceptionHandler::DEVELOPMENT`
`184`	`184`	`: ExceptionHandler::PRODUCTION;`
`@@ -230,8 +230,8 @@ protected function debugEnd() : void`
`230`	`230`	`{`
`231`	`231`	`static::$debugCollector->setEndTime()->setEndMemory();`
`232`	`232`	`$response = static::router()->getResponse();`
`233`		`- if ( ! $response->hasDownload()`
`234`		`- && ! $response->getRequest()->isAjax()`
	`233`	`+ if (!$response->hasDownload()`
	`234`	`+ && !$response->getRequest()->isAjax()`
`235`	`235`	`&& \str_contains(`
`236`	`236`	`(string) $response->getHeader('Content-Type'),`
`237`	`237`	`'text/html'`
`@@ -492,7 +492,7 @@ protected static function addCommand(string $file, Console $console, Locator $lo`
`492`	`492`	`if ($className === null) {`
`493`	`493`	`return false;`
`494`	`494`	`}`
`495`		`- if ( ! \class_exists($className)) {`
	`495`	`+ if (!\class_exists($className)) {`
`496`	`496`	`Isolation::require($file);`
`497`	`497`	`}`
`498`	`498`	`$class = new ReflectionClass($className); // @phpstan-ignore-line`
`@@ -1033,7 +1033,7 @@ protected static function setRouter(string $instance, array $config = null) : Ro`
`1033`	`1033`	`if (isset($config['auto_methods']) && $config['auto_methods'] === true) {`
`1034`	`1034`	`$service->setAutoMethods();`
`1035`	`1035`	`}`
`1036`		`- if ( ! empty($config['placeholders'])) {`
	`1036`	`+ if (!empty($config['placeholders'])) {`
`1037`	`1037`	`$service->addPlaceholder($config['placeholders']);`
`1038`	`1038`	`}`
`1039`	`1039`	`if ($requireFiles && isset($config['files'])) {`
`@@ -1050,7 +1050,7 @@ protected static function setRouter(string $instance, array $config = null) : Ro`
`1050`	`1050`	`protected static function requireRouterFiles(array $files) : void`
`1051`	`1051`	`{`
`1052`	`1052`	`foreach ($files as $file) {`
`1053`		`- if ( ! \is_file($file)) {`
	`1053`	`+ if (!\is_file($file)) {`
`1054`	`1054`	`throw new LogicException('Invalid router file: ' . $file);`
`1055`	`1055`	`}`
`1056`	`1056`	`Isolation::require($file);`
`@@ -1158,10 +1158,10 @@ protected static function setResponse(string $instance) : Response`
`1158`	`1158`	`{`
`1159`	`1159`	`$config = static::config()->get('response', $instance);`
`1160`	`1160`	`$service = new Response(static::request($config['request_instance'] ?? 'default'));`
`1161`		`- if ( ! empty($config['headers'])) {`
	`1161`	`+ if (!empty($config['headers'])) {`
`1162`	`1162`	`$service->setHeaders($config['headers']);`
`1163`	`1163`	`}`
`1164`		`- if ( ! empty($config['auto_etag'])) {`
	`1164`	`+ if (!empty($config['auto_etag'])) {`
`1165`	`1165`	`$service->setAutoEtag(`
`1166`	`1166`	`$config['auto_etag']['active'] ?? true,`
`1167`	`1167`	`$config['auto_etag']['hash_algo'] ?? null`
Original file line number	Diff line number	Diff line change
`@@ -31,10 +31,10 @@ class AppCollector extends Collector`
`31`	`31`	`public function setApp(App $app) : static`
`32`	`32`	`{`
`33`	`33`	`$this->app = $app;`
`34`		`- if ( ! isset($this->startTime)) {`
	`34`	`+ if (!isset($this->startTime)) {`
`35`	`35`	`$this->setStartTime();`
`36`	`36`	`}`
`37`		`- if ( ! isset($this->startMemory)) {`
	`37`	`+ if (!isset($this->startMemory)) {`
`38`	`38`	`$this->setStartMemory();`
`39`	`39`	`}`
`40`	`40`	`return $this;`
`@@ -90,10 +90,10 @@ public function getActivities() : array`
`90`	`90`
`91`	`91`	`public function getContents() : string`
`92`	`92`	`{`
`93`		`- if ( ! isset($this->endTime)) {`
	`93`	`+ if (!isset($this->endTime)) {`
`94`	`94`	`$this->setEndTime(\microtime(true));`
`95`	`95`	`}`
`96`		`- if ( ! isset($this->endMemory)) {`
	`96`	`+ if (!isset($this->endMemory)) {`
`97`	`97`	`$this->setEndMemory(\memory_get_usage());`
`98`	`98`	`}`
`99`	`99`	`\ob_start(); ?>`
`@@ -161,7 +161,7 @@ protected function getServices() : array`
`161`	`161`	`{`
`162`	`162`	`$result = [];`
`163`	`163`	`foreach ($this->getData() as $data) {`
`164`		`- if ( ! isset($result[$data['service']])) {`
	`164`	`+ if (!isset($result[$data['service']])) {`
`165`	`165`	`$result[$data['service']] = [];`
`166`	`166`	`}`
`167`	`167`	`$result[$data['service']][] = [`
`@@ -180,7 +180,7 @@ protected function renderAvailableServices() : string`
`180`	`180`	`$class = new ReflectionClass($this->app);`
`181`	`181`	`$methods = $class->getMethods(ReflectionMethod::IS_STATIC);`
`182`	`182`	`foreach ($methods as $method) {`
`183`		`- if ( ! $method->isPublic()) {`
	`183`	`+ if (!$method->isPublic()) {`
`184`	`184`	`continue;`
`185`	`185`	`}`
`186`	`186`	`$name = $method->getName();`
`@@ -196,7 +196,7 @@ protected function renderAvailableServices() : string`
`196`	`196`	`continue;`
`197`	`197`	`}`
`198`	`198`	`$param = $method->getParameters()[0] ?? null;`
`199`		`- if ( ! $param \|\| $param->getName() !== 'instance') {`
	`199`	`+ if (!$param \|\| $param->getName() !== 'instance') {`
`200`	`200`	`continue;`
`201`	`201`	`}`
`202`	`202`	`if ($param->getType()?->getName() !== 'string') { // @phpstan-ignore-line`
Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ public function getContents() : string`
`73`	`73`
`74`	`74`	`protected function renderRenderedViews() : string`
`75`	`75`	`{`
`76`		`- if ( ! $this->hasData()) {`
	`76`	`+ if (!$this->hasData()) {`
`77`	`77`	`return '<p>No view has been rendered.</p>';`
`78`	`78`	`}`
`79`	`79`	`$data = $this->getSortedData();`
Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ protected function populate(array $properties) : void`
`140`	`140`
`141`	`141`	`protected function setProperty(string $name, mixed $value) : void`
`142`	`142`	`{`
`143`		`- if ( ! \property_exists($this, $name)) {`
	`143`	`+ if (!\property_exists($this, $name)) {`
`144`	`144`	`throw $this->propertyNotDefined($name);`
`145`	`145`	`}`
`146`	`146`	`if ($value !== null) {`
`@@ -251,7 +251,7 @@ public function toModel() : array`
`251`	`251`
`252`	`252`	`public function jsonSerialize() : stdClass`
`253`	`253`	`{`
`254`		`- if ( ! $this->getJsonVars()) {`
	`254`	`+ if (!$this->getJsonVars()) {`
`255`	`255`	`return new stdClass();`
`256`	`256`	`}`
`257`	`257`	`$allowed = \array_flip($this->getJsonVars());`
`@@ -268,7 +268,7 @@ protected function getObjectVars() : array`
`268`	`268`	`{`
`269`	`269`	`$result = [];`
`270`	`270`	`foreach (\get_object_vars($this) as $key => $value) {`
`271`		`- if ( ! \str_starts_with($key, '_')) {`
	`271`	`+ if (!\str_starts_with($key, '_')) {`
`272`	`272`	`$result[$key] = $value;`
`273`	`273`	`}`
`274`	`274`	`}`
Original file line number	Diff line number	Diff line change
`@@ -825,7 +825,7 @@ public function getValidationMessages() : array`
`825`	`825`	`*/`
`826`	`826`	`protected function getValidationRules() : array`
`827`	`827`	`{`
`828`		`- if ( ! isset($this->validationRules)) {`
	`828`	`+ if (!isset($this->validationRules)) {`
`829`	`829`	`throw new RuntimeException('Validation rules are not set');`
`830`	`830`	`}`
`831`	`831`	`return $this->validationRules;`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ public function __destruct()`
`66`	`66`	`public function setBaseDir(string $baseDir) : static`
`67`	`67`	`{`
`68`	`68`	`$real = \realpath($baseDir);`
`69`		`- if ( ! $real \|\| ! \is_dir($real)) {`
	`69`	`+ if (!$real \|\| !\is_dir($real)) {`
`70`	`70`	`throw new InvalidArgumentException("View base dir is not a valid directory: {$baseDir} ");`
`71`	`71`	`}`
`72`	`72`	`$this->baseDir = \rtrim($real, '\\/ ') . \DIRECTORY_SEPARATOR;`
`@@ -150,10 +150,10 @@ protected function getFilepath(string $view) : string`
`150`	`150`	`}`
`151`	`151`	`$view = $this->getBaseDir() . $view . $this->getExtension();`
`152`	`152`	`$real = \realpath($view);`
`153`		`- if ( ! $real \|\| ! \is_file($real)) {`
	`153`	`+ if (!$real \|\| !\is_file($real)) {`
`154`	`154`	`throw new InvalidArgumentException("View path does not match a file: {$view}");`
`155`	`155`	`}`
`156`		`- if ($this->getBaseDir() && ! \str_starts_with($real, $this->getBaseDir())) {`
	`156`	`+ if ($this->getBaseDir() && !\str_starts_with($real, $this->getBaseDir())) {`
`157`	`157`	`throw new InvalidArgumentException("View path out of base directory: {$real}");`
`158`	`158`	`}`
`159`	`159`	`return $real;`
`@@ -255,7 +255,7 @@ public function endBlock() : static`
`255`	`255`	`echo \PHP_EOL . '<!-- Block end: ' . $block . ' -->' . \PHP_EOL;`
`256`	`256`	`}`
`257`	`257`	`$contents = \ob_get_clean();`
`258`		`- if ( ! isset($this->blocks[$name])) {`
	`258`	`+ if (!isset($this->blocks[$name])) {`
`259`	`259`	`$this->blocks[$name] = $contents; // @phpstan-ignore-line`
`260`	`260`	`}`
`261`	`261`	`return $this;`
`@@ -367,7 +367,7 @@ protected function getContents(string $view, array $data) : string`
`367`	`367`	`$data['view'] = $this;`
`368`	`368`	`\ob_start();`
`369`	`369`	`Isolation::require($this->getFilepath($view), $data);`
`370`		`- if (isset($this->openBlock) && ! $this->inInclude) {`
	`370`	`+ if (isset($this->openBlock) && !$this->inInclude) {`
`371`	`371`	`$this->openBlock = null;`
`372`	`372`	`$this->endBlock();`
`373`	`373`	`}`