No lint warnings; fix the one that existed (#105)

Also fix an error message with lots of whitespace.

Author: glasser

.eslintrc.yml

@@ -62,15 +62,15 @@ rules:
     '@typescript-eslint/no-inferrable-types': 'error',
     '@typescript-eslint/no-misused-new': 'error',
     '@typescript-eslint/no-namespace': 'error',
-    '@typescript-eslint/no-non-null-assertion': 'warn',
+    '@typescript-eslint/no-non-null-assertion': 'error',
     '@typescript-eslint/no-require-imports': 'error',
     '@typescript-eslint/no-unnecessary-qualifier': 'error',
     '@typescript-eslint/no-unnecessary-type-assertion': 'error',
     '@typescript-eslint/no-unused-vars': 'error',
     '@typescript-eslint/no-useless-constructor': 'error',
     '@typescript-eslint/no-var-requires': 'error',
-    '@typescript-eslint/prefer-for-of': 'warn',
-    '@typescript-eslint/prefer-function-type': 'warn',
+    '@typescript-eslint/prefer-for-of': 'error',
+    '@typescript-eslint/prefer-function-type': 'error',
     '@typescript-eslint/prefer-includes': 'error',
     '@typescript-eslint/prefer-string-starts-ends-with': 'error',
     '@typescript-eslint/promise-function-async': 'error',

dist/index.js

@@ -83,8 +83,9 @@ export class ArtifactRegistryDockerRegistryClient {
     const [tag] = await this.client.getTag({ name: tagPath });
 
     if (!tag || !tag.version) {
-      throw new Error(`The tag '${tagName}' on the image '${packageName}'
-        does not exist. Check that both the image and tag are spelled correctly.`);
+      throw new Error(
+        `The tag '${tagName}' on the image '${packageName}' does not exist. Check that both the image and tag are spelled correctly.`,
+      );
     }
     // version.name is like projects/.../versions/{versionId}, but digest is in version metadata field
     return tag.version;

src/artifactRegistry.ts

@@ -147,7 +147,11 @@ async function checkTagsAgainstArtifactRegistryAndModifyScalars(
           packageName: trackable.imageName,
           tagName: trackable.tag,
         });
-        return reference.match(/sha256:[a-f0-9]{64}/)![0]; // will always have sha256 because it is returned from OCI registry
+        const match = reference.match(/sha256:[a-f0-9]{64}/);
+        if (!match) {
+          throw new Error(`Docker digest is not valid sha256: ${reference}`);
+        }
+        return match[0];
       } catch (e) {
         if (e instanceof Error) {
           let message = e.message;