-
Notifications
You must be signed in to change notification settings - Fork 11
Open
Description
Some approval file names have the first letter of method in uppercase and are not matching the corresponding method name.
There are also some methods with uppercase first letter (one is related to approval files, others not).
These are not following the Java convention and also causes mismatching methods and files.
Wrong file names:
src/main/java/org/approvaltests/koans/lesson01/GettingStarted.SometimeYouNeedABetterToString.approved.txt
src/main/java/org/approvaltests/koans/lesson01/GettingStarted.ChangingTheGoldenMaster.approved.txt
src/main/java/org/approvaltests/koans/lesson01/GettingStarted.VerifyObjects.approved.txt
src/main/java/org/approvaltests/koans/lesson02/Collections.MapsAreSortedBeforeDisplay.approved.txt
src/main/java/org/approvaltests/koans/lesson02/Collections.TransformingArraysManually.approved.txt
src/main/java/org/approvaltests/koans/lesson02/Collections.ArrayToStringsSuck.approved.txt
src/main/java/org/approvaltests/koans/lesson02/Collections.TransformingArraysWithFunctions.approved.txt
src/main/java/org/approvaltests/koans/lesson02/Collections.Lists.approved.txt
src/main/java/org/approvaltests/koans/lesson02/Collections.ApprovalHelpShowWhenThingsHaveBeenRemoved.approved.txt
src/main/java/org/approvaltests/koans/lesson02/Collections.SimpleArrays.approved.txt
src/main/java/org/approvaltests/koans/lesson02/Collections.TheUseOfTheLabel.approved.txt
src/main/java/org/approvaltests/koans/lesson02/Collections.ApprovalHelpShowWhenThingsHaveBeenAdded.approved.txt
src/main/java/org/approvaltests/koans/lesson02/Collections.HeadersHelpExplainTheContextWhenThingsAreConfusing.approved.txt
src/main/java/org/approvaltests/koans/lesson02/Collections.ListsWorkTheSameAsArrays.approved.txt
src/main/java/org/approvaltests/koans/lesson03/ApprovingTheResult.UseWholeFileInADiffReporter.approved.txt
Wrong method name:
src/main/java/org/approvaltests/koans/lesson03/ApprovingTheResult.java
public void RenameTheApproved() throws Exception
public void SaveAsApproved() throws Exception
public void MoveTheFileViaCommandLine() throws Exception
public void UseWholeFileInADiffReporter() throws Exception
src/main/java/org/approvaltests/koans/lesson04/UsingReporters.java
public void ConfiguringTheFileLauncherReporter() throws Exception
public void ConfiguringAClassLevelDefault() throws Exception
public void ConfiguringMultipleReporters() throws Exception
public void UsingTextReportersForInsight() throws Exception
public void UsingImageForInsight() throws Exception
siwonpawel
Metadata
Metadata
Assignees
Labels
No labels