Add comment to empty catch block

vermakhushboo · vermakhushboo · commit 2b68cf9f6a5a · 2025-09-22T12:46:20.000+05:30
diff --git a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/+page.svelte b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/+page.svelte
@@ -56,7 +56,9 @@
                     teamId: $project.teamId,
                     domain: apexDomain
                 });
-            } catch (error) {}
+            } catch (error) {
+                // Empty as domain creation error needs to be silent
+            }
         }
 
         try {
@@ -93,7 +95,9 @@
                 if (isCloud) {
                     try {
                         await sdk.forConsole.domains.updateNameservers({ domainId: domain.$id });
-                    } catch (error) {}
+                    } catch (error) {
+                        // Empty as domain update error needs to be silent
+                    }
                 }
             } else {
                 await goto(`${routeBase}/add-domain/verify-${domainName}?rule=${rule.$id}`);
diff --git a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
@@ -63,7 +63,9 @@
                                 'Domain verification failed. Please check your domain settings or try again later'
                             );
                         }
-                    } catch (error) {}
+                    } catch (error) {
+                        // Empty as domain creation error needs to be silent
+                    }
 
                     try {
                         const domain = data.domainsList.domains.find(
@@ -80,7 +82,9 @@
                                 );
                             }
                         }
-                    } catch (error) {}
+                    } catch (error) {
+                        // Empty as domain update error needs to be silent
+                    }
                 }
             }
 
diff --git a/src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/+page.svelte b/src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/+page.svelte
@@ -36,7 +36,9 @@
                     teamId: $project.teamId,
                     domain: apexDomain
                 });
-            } catch (error) {}
+            } catch (error) {
+                // Empty as domain creation error needs to be silent
+            }
         }
 
         try {
@@ -49,7 +51,9 @@
                 if (isCloud) {
                     try {
                         await sdk.forConsole.domains.updateNameservers({ domainId: domain.$id });
-                    } catch (error) {}
+                    } catch (error) {
+                        // Empty as domain update error needs to be silent
+                    }
                 }
             } else {
                 await goto(`${routeBase}/add-domain/verify-${domainName}?rule=${rule.$id}`);
diff --git a/src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte b/src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
@@ -65,7 +65,9 @@
                                 'Domain verification failed. Please check your domain settings or try again later'
                             );
                         }
-                    } catch (error) {}
+                    } catch (error) {
+                        // Empty as domain creation error needs to be silent
+                    }
 
                     try {
                         const domain = data.domainsList.domains.find(
@@ -82,7 +84,9 @@
                                 );
                             }
                         }
-                    } catch (error) {}
+                    } catch (error) {
+                        // Empty as domain update error needs to be silent
+                    }
                 }
             }
 
diff --git a/src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte b/src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte
@@ -66,7 +66,9 @@
                     teamId: $project.teamId,
                     domain: apexDomain
                 });
-            } catch (error) {}
+            } catch (error) {
+                // Empty as domain creation error needs to be silent
+            }
         }
 
         try {
@@ -103,7 +105,9 @@
                 if (isCloud) {
                     try {
                         await sdk.forConsole.domains.updateNameservers({ domainId: domain.$id });
-                    } catch (error) {}
+                    } catch (error) {
+                        // Empty as domain update error needs to be silent
+                    }
                 }
             } else {
                 await goto(`${routeBase}/add-domain/verify-${domainName}?rule=${rule.$id}`);
diff --git a/src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte b/src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
@@ -65,7 +65,9 @@
                                 'Domain verification failed. Please check your domain settings or try again later'
                             );
                         }
-                    } catch (error) {}
+                    } catch (error) {
+                        // Empty as domain creation error needs to be silent
+                    }
 
                     try {
                         const domain = data.domainsList.domains.find(
@@ -82,7 +84,9 @@
                                 );
                             }
                         }
-                    } catch (error) {}
+                    } catch (error) {
+                        // Empty as domain update error needs to be silent
+                    }
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,9 @@`
`63`	`63`	`'Domain verification failed. Please check your domain settings or try again later'`
`64`	`64`	`);`
`65`	`65`	`}`
`66`		`- } catch (error) {}`
	`66`	`+ } catch (error) {`
	`67`	`+ // Empty as domain creation error needs to be silent`
	`68`	`+ }`
`67`	`69`
`68`	`70`	`try {`
`69`	`71`	`const domain = data.domainsList.domains.find(`
`@@ -80,7 +82,9 @@`
`80`	`82`	`);`
`81`	`83`	`}`
`82`	`84`	`}`
`83`		`- } catch (error) {}`
	`85`	`+ } catch (error) {`
	`86`	`+ // Empty as domain update error needs to be silent`
	`87`	`+ }`
`84`	`88`	`}`
`85`	`89`	`}`
`86`	`90`
Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,9 @@`
`65`	`65`	`'Domain verification failed. Please check your domain settings or try again later'`
`66`	`66`	`);`
`67`	`67`	`}`
`68`		`- } catch (error) {}`
	`68`	`+ } catch (error) {`
	`69`	`+ // Empty as domain creation error needs to be silent`
	`70`	`+ }`
`69`	`71`
`70`	`72`	`try {`
`71`	`73`	`const domain = data.domainsList.domains.find(`
`@@ -82,7 +84,9 @@`
`82`	`84`	`);`
`83`	`85`	`}`
`84`	`86`	`}`
`85`		`- } catch (error) {}`
	`87`	`+ } catch (error) {`
	`88`	`+ // Empty as domain update error needs to be silent`
	`89`	`+ }`
`86`	`90`	`}`
`87`	`91`	`}`
`88`	`92`