Skip to content

Commit fac05fa

Browse files
committed
github: fix verify jobs to always report status
Fix verify-core and verify-format jobs that were causing GitHub PR status checks to get stuck with "Waiting for status to be reported". Both jobs now use 'if: always()' to ensure they run and report status regardless of dependency job outcomes. Signed-off-by: iabdalkader <[email protected]>
1 parent a26551e commit fac05fa

File tree

2 files changed

+17
-11
lines changed

2 files changed

+17
-11
lines changed

.github/workflows/format_check.yml

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,6 @@ on:
44
push:
55
branches:
66
- 'main'
7-
paths:
8-
- '**/*.c'
9-
- '**/*.cpp'
10-
- '**/*.h'
11-
- '**/*.hpp'
127

138
pull_request:
149
types:
@@ -18,11 +13,6 @@ on:
1813
- synchronize
1914
branches:
2015
- 'main'
21-
paths:
22-
- '**/*.c'
23-
- '**/*.cpp'
24-
- '**/*.h'
25-
- '**/*.hpp'
2616

2717
workflow_dispatch:
2818
inputs:
@@ -58,3 +48,20 @@ jobs:
5848
clang-format-version: '19'
5949
check-path: ${{ matrix.path['check'] }}
6050
exclude-regex: ${{ matrix.path['exclude'] }}
51+
52+
verify-format:
53+
name: verify-format
54+
runs-on: ubuntu-latest
55+
if: always()
56+
needs: format-check
57+
steps:
58+
- name: Check format results
59+
run: |
60+
if [[ "${{ needs.format-check.result }}" == "failure" ||
61+
"${{ needs.format-check.result }}" == "cancelled" ]]; then
62+
echo "Format check failed or was cancelled"
63+
exit 1
64+
else
65+
echo "Format check completed successfully or was skipped"
66+
fi
67+

.github/workflows/package_core.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,6 @@ jobs:
184184
failOnError: false
185185

186186
verify-core:
187-
name: Collect job errors
188187
runs-on: ubuntu-latest
189188
if: cancelled() || contains(needs.*.result, 'failure')
190189
needs:

0 commit comments

Comments
 (0)