Skip to content

Commit 7223866

Browse files
committed
Add blank lines to visually group shell command lines
The `run` keys of the steps in the GitHub Actions workflows contain complex shell command lines. The readability of this code is improved by selectively adding blank lines to separate it visually into logical groupings.
1 parent c5f6f07 commit 7223866

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

.github/workflows/check-general-formatting-task.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,13 +71,16 @@ jobs:
7171
- name: Install editorconfig-checker
7272
run: |
7373
cd "${{ env.EC_INSTALL_PATH }}"
74+
7475
tar \
7576
--extract \
7677
--file="${{ steps.download.outputs.name }}"
78+
7779
# Give the binary a standard name
7880
mv \
7981
"${{ env.EC_INSTALL_PATH }}/bin/ec-linux-amd64" \
8082
"${{ env.EC_INSTALL_PATH }}/bin/ec"
83+
8184
# Add installation to PATH:
8285
# See: https://docs.github.com/actions/using-workflows/workflow-commands-for-github-actions#adding-a-system-path
8386
echo "${{ env.EC_INSTALL_PATH }}/bin" >>"$GITHUB_PATH"

.github/workflows/release-go-crosscompile-task.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ jobs:
105105
run: |
106106
# See: https://docs.github.com/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#setting-an-environment-variable
107107
echo "BUILD_FOLDER=${{ env.PROJECT_NAME }}_osx_${{ matrix.build.folder-suffix }}" >>"$GITHUB_ENV"
108+
108109
TAG="${GITHUB_REF/refs\/tags\//}"
109110
echo "PACKAGE_FILENAME=${{ env.PROJECT_NAME }}_${TAG}_${{ matrix.build.package-suffix }}" >>$GITHUB_ENV
110111
@@ -125,21 +126,26 @@ jobs:
125126
KEYCHAIN_PASSWORD: keychainpassword
126127
run: |
127128
echo "${{ secrets.INSTALLER_CERT_MAC_P12 }}" | base64 --decode >"${{ env.INSTALLER_CERT_MAC_PATH }}"
129+
128130
security create-keychain \
129131
-p "${{ env.KEYCHAIN_PASSWORD }}" \
130132
"${{ env.KEYCHAIN }}"
133+
131134
security default-keychain \
132135
-s "${{ env.KEYCHAIN }}"
136+
133137
security unlock-keychain \
134138
-p "${{ env.KEYCHAIN_PASSWORD }}" \
135139
"${{ env.KEYCHAIN }}"
140+
136141
security import \
137142
"${{ env.INSTALLER_CERT_MAC_PATH }}" \
138143
-k "${{ env.KEYCHAIN }}" \
139144
-f pkcs12 \
140145
-A \
141146
-T "/usr/bin/codesign" \
142147
-P "${{ secrets.INSTALLER_CERT_MAC_PASSWORD }}"
148+
143149
security set-key-partition-list \
144150
-S apple-tool:,apple: \
145151
-s \
@@ -155,6 +161,7 @@ jobs:
155161
unzip \
156162
gon_macos.zip \
157163
-d /usr/local/bin
164+
158165
- name: Write gon config to file
159166
# gon does not allow env variables in config file (https://github.com/mitchellh/gon/issues/20)
160167
run: |
@@ -197,6 +204,7 @@ jobs:
197204
-czv \
198205
-f "${{ env.PACKAGE_FILENAME }}" \
199206
"${{ env.BUILD_FOLDER }}/"
207+
200208
- name: Replace artifact with notarized build
201209
uses: actions/upload-artifact@v4
202210
with:
@@ -237,12 +245,15 @@ jobs:
237245
unzip \
238246
-p /tmp/3.2.0.zip semver-tool-3.2.0/src/semver \
239247
>/tmp/semver
248+
240249
chmod \
241250
+x \
242251
/tmp/semver
252+
243253
if [[ "$(/tmp/semver get prerel "${GITHUB_REF/refs\/tags\//}")" ]]; then
244254
echo "IS_PRE=true" >>$GITHUB_OUTPUT
245255
fi
256+
246257
- name: Create Github Release and upload artifacts
247258
uses: ncipollo/release-action@v1
248259
with:

0 commit comments

Comments
 (0)