Skip to content

return dict_keys instead of KeysView for AsdfFile.keys #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

return dict_keys instead of KeysView for AsdfFile.keys #1927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions asdf/_asdf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,9 @@ def tree(self, tree):
self._tree = AsdfObject(tree)

def keys(self):
"""
Return view of top-level keys in the tree.
"""
return self.tree.keys()

def __getitem__(self, key):
Expand Down
5 changes: 4 additions & 1 deletion asdf/tags/core/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import collections
import functools

from .constant import Constant
from .external_reference import ExternalArrayReference
Expand All @@ -24,7 +25,9 @@
# to pass an isinstance(..., dict) check and to allow it to be "lazy"
# loaded when "lazy_tree=True".
class AsdfObject(collections.UserDict, dict):
pass
@functools.wraps(collections.UserDict.keys)
def keys(self):
return self.data.keys()


class Software(dict):
Expand Down
Loading