Adds TCPDispatch client #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attwad
requested changes
Oct 25, 2025
pythonosc/tcp_client.py
Outdated
|
|
||
| dispatcher = Dispatcher() | ||
|
|
||
| def handle_messages(self, timeout: int = 30) -> None: |
Owner
There was a problem hiding this comment.
please suffix the arg with the unit, it's not typed so it makes it explicit/easier on the clients to understand.
timeout_sec: int = 30
pythonosc/tcp_client.py
Outdated
| while r: | ||
| for m in r: | ||
| self.dispatcher.call_handlers_for_packet(m, (self.address, self.port)) | ||
| r = self.receive(timeout) |
Owner
There was a problem hiding this comment.
you shouldn't change r if you're looping over it already
Contributor
Author
There was a problem hiding this comment.
Yeah, bad tab placement, sorry, fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a TCPDispatch client to tcp_client.py follow the same concept of the DispatchClient that is already in udp_client.py. Currently, there is only an async version in tcp_client.py.