Skip to content

Commit a4dd6df

Browse files
authored
Add displayName param to passkey signUp (#11)
* Add displayName param to passkey signUp * wip
1 parent 681bf25 commit a4dd6df

File tree

7 files changed

+17
-8
lines changed

7 files changed

+17
-8
lines changed

android/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,8 @@ dependencies {
129129

130130
implementation "androidx.browser:browser:1.2.0"
131131

132-
implementation("com.authsignal:authsignal-push-android:0.2.3")
133-
implementation("com.authsignal:authsignal-passkey-android:0.1.3")
132+
implementation("com.authsignal:authsignal-push-android:0.2.6")
133+
implementation("com.authsignal:authsignal-passkey-android:0.1.6")
134134
}
135135

136136
if (isNewArchitectureEnabled()) {

android/src/main/java/com/authsignal/react/AuthsignalPasskeyModule.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,10 @@ public void initialize(String tenantID, String baseURL, Promise promise) {
5757
}
5858

5959
@ReactMethod
60-
public void signUp(String token, String userName, Promise promise) {
60+
public void signUp(String token, String userName, String displayName, Promise promise) {
6161
if (authsignalPasskey != null) {
6262
authsignalPasskey
63-
.signUpAsync(token, userName)
63+
.signUpAsync(token, userName, displayName)
6464
.thenAcceptAsync(response -> {
6565
if (response.getError() != null) {
6666
promise.reject("signUp error", response.getError());

ios/AuthsignalPasskeyModule.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ @interface RCT_EXTERN_MODULE(AuthsignalPasskeyModule, NSObject)
1010

1111
RCT_EXTERN_METHOD(signUp:(NSString)token
1212
withUserName:(NSString)userName
13+
withDisplayName:(NSString)displayName
1314
resolver:(RCTPromiseResolveBlock)resolve
1415
rejecter:(RCTPromiseRejectBlock)reject)
1516

ios/AuthsignalPasskeyModule.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ class AuthsignalPasskeyModule: NSObject {
2424
@objc func signUp(
2525
_ token: NSString,
2626
withUserName userName: NSString,
27+
withDisplayName displayName: NSString,
2728
resolver resolve: @escaping RCTPromiseResolveBlock,
2829
rejecter reject: @escaping RCTPromiseRejectBlock
2930
) -> Void {
@@ -34,9 +35,10 @@ class AuthsignalPasskeyModule: NSObject {
3435

3536
let tokenStr = token as String
3637
let userNameStr = userName as String?
38+
let displayNameStr = displayName as String?
3739

3840
Task.init {
39-
let response = await authsignal!.signUp(token: tokenStr, userName: userNameStr)
41+
let response = await authsignal!.signUp(token: tokenStr, userName: userNameStr, displayName: displayNameStr)
4042

4143
if (response.error != nil) {
4244
reject("signUp error", response.error, nil)

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-native-authsignal",
3-
"version": "0.3.3",
3+
"version": "0.3.4",
44
"description": "The official Authsignal React Native library.",
55
"main": "lib/commonjs/index",
66
"module": "lib/module/index",

react-native-authsignal.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Pod::Spec.new do |s|
1717
s.source_files = "ios/**/*.{h,m,mm,swift}"
1818

1919
s.dependency "React-Core"
20-
s.dependency 'Authsignal', '0.2.0'
20+
s.dependency 'Authsignal', '0.2.1'
2121

2222
# Don't install the dependencies when we run `pod install` in the old architecture.
2323
if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then

src/passkey.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ interface ConstructorArgs {
1111
interface PasskeySignUpInput {
1212
token: string;
1313
userName?: string;
14+
displayName?: string;
1415
}
1516

1617
interface PasskeySignInInput {
@@ -46,11 +47,16 @@ export class AuthsignalPasskey {
4647
async signUp({
4748
token,
4849
userName,
50+
displayName,
4951
}: PasskeySignUpInput): Promise<AuthsignalResponse<string>> {
5052
await this.ensureModuleIsInitialized();
5153

5254
try {
53-
const data = await AuthsignalPasskeyModule.signUp(token, userName);
55+
const data = await AuthsignalPasskeyModule.signUp(
56+
token,
57+
userName,
58+
displayName
59+
);
5460

5561
return { data };
5662
} catch (ex) {

0 commit comments

Comments
 (0)