Merge branch 'master' into powerslider/4368-migrate-stats-coreth

Author: powerslider

.github/CODEOWNERS

@@ -30,6 +30,7 @@
 /tests/*.md @joshua-kim @maru-ava @meaghanfitzgerald
 /tests/reexecute/ @aaronbuchwald
 /tools/* @joshua-kim @maru-ava
+/vms/evm/ @ARR4N @joshua-kim @StephenButtolph
 /x/blockdb @DracoLi
 /x/merkledb @joshua-kim @rrazvan1
 /x/sync @joshua-kim @rrazvan1

.github/actions/c-chain-reexecution-benchmark/action.yml

@@ -95,7 +95,8 @@ runs:
             LABELS=${{ env.LABELS }} \
             BENCHMARK_OUTPUT_FILE=${{ env.BENCHMARK_OUTPUT_FILE }} \
             RUNNER_NAME=${{ inputs.runner_name }} \
-            METRICS_ENABLED=true
+            METRICS_SERVER_ENABLED=true \
+            METRICS_COLLECTOR_ENABLED=true
         prometheus_url: ${{ inputs.prometheus-url }}
         prometheus_push_url: ${{ inputs.prometheus-push-url }}
         prometheus_username: ${{ inputs.prometheus-username }}

.golangci.yml

@@ -60,6 +60,7 @@ linters:
     - tagalign
     - testifylint
     - unconvert
+    - usetesting
     - unparam
     - unused
     - usestdlibvars
@@ -199,6 +200,14 @@ linters:
       disable:
         - go-require
         - float-compare
+    usetesting:
+      os-create-temp:     true # Disallow `os.CreateTemp("", ...)`
+      os-mkdir-temp:      true # Disallow `os.MkdirTemp()`
+      os-setenv:          true # Disallow `os.Setenv()`
+      os-temp-dir:        true # Disallow `os.TempDir()`
+      os-chdir:           true # Disallow `os.Chdir()`
+      context-background: true # Disallow `context.Background()`
+      context-todo:       true # Disallow `context.TODO()`
     unused:
       # Mark all struct fields that have been written to as used.
       # Default: true
@@ -216,6 +225,15 @@ linters:
       - common-false-positives
       - legacy
       - std-error-handling
+    rules:
+      # Exclude some linters from running on test files.
+      # 1. Exclude the top level tests/ directory.
+      # 2. Exclude any file prefixed with test_ in any directory.
+      # 3. Exclude any directory suffixed with test.
+      # 4. Exclude any file suffixed with _test.go.
+      - path: "(^tests/)|(^(.*/)*test_[^/]*\\.go$)|(.*test/.*)|(.*_test\\.go$)"
+        linters:
+          - prealloc
 formatters:
   enable:
     - gci

CONTRIBUTING.md

@@ -4,7 +4,7 @@
 
 To start developing on AvalancheGo, you'll need a few things installed.
 
-- Golang version >= 1.24.8
+- Golang version >= 1.24.9
 - gcc
 - g++
 
@@ -110,7 +110,7 @@ Mocks are auto-generated using [mockgen](https://pkg.go.dev/go.uber.org/mock/moc
 - Run the linter
 
 ```sh
-./scipts/run_task.sh lint
+./scripts/run_task.sh lint
 ```
 
 ### Continuous Integration (CI)

README.md

@@ -23,7 +23,7 @@ The minimum recommended hardware specification for nodes connected to Mainnet is
 
 If you plan to build AvalancheGo from source, you will also need the following software:
 
-- [Go](https://golang.org/doc/install) version >= 1.24.8
+- [Go](https://golang.org/doc/install) version >= 1.24.9
 - [gcc](https://gcc.gnu.org/)
 - g++
 

RELEASES.md

@@ -1,5 +1,11 @@
 # Release Notes
 
+## Pending
+
+### Configs
+
+- Changed default block delay for L1s (other than Primary Network) to 0.
+
 ## [v1.13.5](https://github.com/ava-labs/avalanchego/releases/tag/v1.13.5)
 
 This version is backwards compatible to [v1.13.0](https://github.com/ava-labs/avalanchego/releases/tag/v1.13.0). It is optional, but encouraged.

Taskfile.yml

@@ -170,6 +170,10 @@ tasks:
     desc: Runs static analysis tests of golang code
     cmd: ./scripts/lint.sh
 
+  lint-fix:
+    desc: Runs automated fixing for failing static analysis of golang code
+    cmd: ./scripts/run_tool.sh golangci-lint run --config .golangci.yml --fix
+
   lint-action:
     desc: Runs actionlint to check sanity of github action configuration
     cmd: ./scripts/actionlint.sh
@@ -203,7 +207,8 @@ tasks:
       END_BLOCK: '{{.END_BLOCK}}'
       LABELS: '{{.LABELS | default ""}}'
       BENCHMARK_OUTPUT_FILE: '{{.BENCHMARK_OUTPUT_FILE | default ""}}'
-      METRICS_ENABLED: '{{.METRICS_ENABLED | default "false"}}'
+      METRICS_SERVER_ENABLED: '{{.METRICS_SERVER_ENABLED | default "false"}}'
+      METRICS_COLLECTOR_ENABLED: '{{.METRICS_COLLECTOR_ENABLED | default "false"}}'
     cmd: |
       CURRENT_STATE_DIR={{.CURRENT_STATE_DIR}} \
       BLOCK_DIR={{.BLOCK_DIR}} \
@@ -213,7 +218,8 @@ tasks:
       END_BLOCK={{.END_BLOCK}} \
       LABELS={{.LABELS}} \
       BENCHMARK_OUTPUT_FILE={{.BENCHMARK_OUTPUT_FILE}} \
-      METRICS_ENABLED={{.METRICS_ENABLED}} \
+      METRICS_SERVER_ENABLED={{.METRICS_SERVER_ENABLED}} \
+      METRICS_COLLECTOR_ENABLED={{.METRICS_COLLECTOR_ENABLED}} \
       bash -x ./scripts/benchmark_cchain_range.sh
 
   reexecute-cchain-range-with-copied-data:
@@ -228,7 +234,8 @@ tasks:
       END_BLOCK: '{{.END_BLOCK | default "250000"}}'
       LABELS: '{{.LABELS | default ""}}'
       BENCHMARK_OUTPUT_FILE: '{{.BENCHMARK_OUTPUT_FILE | default ""}}'
-      METRICS_ENABLED: '{{.METRICS_ENABLED | default "false"}}'
+      METRICS_SERVER_ENABLED: '{{.METRICS_SERVER_ENABLED | default "false"}}'
+      METRICS_COLLECTOR_ENABLED: '{{.METRICS_COLLECTOR_ENABLED | default "false"}}'
     cmds:
       - task: import-cchain-reexecute-range
         vars:
@@ -245,7 +252,8 @@ tasks:
           END_BLOCK: '{{.END_BLOCK}}'
           LABELS: '{{.LABELS}}'
           BENCHMARK_OUTPUT_FILE: '{{.BENCHMARK_OUTPUT_FILE}}'
-          METRICS_ENABLED: '{{.METRICS_ENABLED}}'
+          METRICS_SERVER_ENABLED: '{{.METRICS_SERVER_ENABLED}}'
+          METRICS_COLLECTOR_ENABLED: '{{.METRICS_COLLECTOR_ENABLED}}'
 
   test-bootstrap-monitor-e2e:
     desc: Runs bootstrap monitor e2e tests

api/admin/client_test.go

@@ -78,7 +78,7 @@ func TestStartCPUProfiler(t *testing.T) {
 	for _, test := range SuccessResponseTests {
 		t.Run(test.name, func(t *testing.T) {
 			mockClient := Client{Requester: NewMockClient(&api.EmptyReply{}, test.expectedErr)}
-			err := mockClient.StartCPUProfiler(context.Background())
+			err := mockClient.StartCPUProfiler(t.Context())
 			require.ErrorIs(t, err, test.expectedErr)
 		})
 	}
@@ -88,7 +88,7 @@ func TestStopCPUProfiler(t *testing.T) {
 	for _, test := range SuccessResponseTests {
 		t.Run(test.name, func(t *testing.T) {
 			mockClient := Client{Requester: NewMockClient(&api.EmptyReply{}, test.expectedErr)}
-			err := mockClient.StopCPUProfiler(context.Background())
+			err := mockClient.StopCPUProfiler(t.Context())
 			require.ErrorIs(t, err, test.expectedErr)
 		})
 	}
@@ -98,7 +98,7 @@ func TestMemoryProfile(t *testing.T) {
 	for _, test := range SuccessResponseTests {
 		t.Run(test.name, func(t *testing.T) {
 			mockClient := Client{Requester: NewMockClient(&api.EmptyReply{}, test.expectedErr)}
-			err := mockClient.MemoryProfile(context.Background())
+			err := mockClient.MemoryProfile(t.Context())
 			require.ErrorIs(t, err, test.expectedErr)
 		})
 	}
@@ -108,7 +108,7 @@ func TestLockProfile(t *testing.T) {
 	for _, test := range SuccessResponseTests {
 		t.Run(test.name, func(t *testing.T) {
 			mockClient := Client{Requester: NewMockClient(&api.EmptyReply{}, test.expectedErr)}
-			err := mockClient.LockProfile(context.Background())
+			err := mockClient.LockProfile(t.Context())
 			require.ErrorIs(t, err, test.expectedErr)
 		})
 	}
@@ -118,7 +118,7 @@ func TestAlias(t *testing.T) {
 	for _, test := range SuccessResponseTests {
 		t.Run(test.name, func(t *testing.T) {
 			mockClient := Client{Requester: NewMockClient(&api.EmptyReply{}, test.expectedErr)}
-			err := mockClient.Alias(context.Background(), "alias", "alias2")
+			err := mockClient.Alias(t.Context(), "alias", "alias2")
 			require.ErrorIs(t, err, test.expectedErr)
 		})
 	}
@@ -128,7 +128,7 @@ func TestAliasChain(t *testing.T) {
 	for _, test := range SuccessResponseTests {
 		t.Run(test.name, func(t *testing.T) {
 			mockClient := Client{Requester: NewMockClient(&api.EmptyReply{}, test.expectedErr)}
-			err := mockClient.AliasChain(context.Background(), "chain", "chain-alias")
+			err := mockClient.AliasChain(t.Context(), "chain", "chain-alias")
 			require.ErrorIs(t, err, test.expectedErr)
 		})
 	}
@@ -143,14 +143,14 @@ func TestGetChainAliases(t *testing.T) {
 			Aliases: expectedReply,
 		}, nil)}
 
-		reply, err := mockClient.GetChainAliases(context.Background(), "chain")
+		reply, err := mockClient.GetChainAliases(t.Context(), "chain")
 		require.NoError(err)
 		require.Equal(expectedReply, reply)
 	})
 
 	t.Run("failure", func(t *testing.T) {
 		mockClient := Client{Requester: NewMockClient(&GetChainAliasesReply{}, errTest)}
-		_, err := mockClient.GetChainAliases(context.Background(), "chain")
+		_, err := mockClient.GetChainAliases(t.Context(), "chain")
 		require.ErrorIs(t, err, errTest)
 	})
 }
@@ -159,7 +159,7 @@ func TestStacktrace(t *testing.T) {
 	for _, test := range SuccessResponseTests {
 		t.Run(test.name, func(t *testing.T) {
 			mockClient := Client{Requester: NewMockClient(&api.EmptyReply{}, test.expectedErr)}
-			err := mockClient.Stacktrace(context.Background())
+			err := mockClient.Stacktrace(t.Context())
 			require.ErrorIs(t, err, test.expectedErr)
 		})
 	}
@@ -182,15 +182,15 @@ func TestReloadInstalledVMs(t *testing.T) {
 			FailedVMs: expectedFailedVMs,
 		}, nil)}
 
-		loadedVMs, failedVMs, err := mockClient.LoadVMs(context.Background())
+		loadedVMs, failedVMs, err := mockClient.LoadVMs(t.Context())
 		require.NoError(err)
 		require.Equal(expectedNewVMs, loadedVMs)
 		require.Equal(expectedFailedVMs, failedVMs)
 	})
 
 	t.Run("failure", func(t *testing.T) {
 		mockClient := Client{Requester: NewMockClient(&LoadVMsReply{}, errTest)}
-		_, _, err := mockClient.LoadVMs(context.Background())
+		_, _, err := mockClient.LoadVMs(t.Context())
 		require.ErrorIs(t, err, errTest)
 	})
 }
@@ -253,7 +253,7 @@ func TestSetLoggerLevel(t *testing.T) {
 				),
 			}
 			res, err := c.SetLoggerLevel(
-				context.Background(),
+				t.Context(),
 				"",
 				tt.logLevel,
 				tt.displayLevel,
@@ -306,7 +306,7 @@ func TestGetLoggerLevel(t *testing.T) {
 				),
 			}
 			res, err := c.GetLoggerLevel(
-				context.Background(),
+				t.Context(),
 				tt.loggerName,
 			)
 			require.ErrorIs(err, tt.clientErr)
@@ -347,7 +347,7 @@ func TestGetConfig(t *testing.T) {
 			c := Client{
 				Requester: NewMockClient(tt.expectedResponse, tt.serviceErr),
 			}
-			res, err := c.GetConfig(context.Background())
+			res, err := c.GetConfig(t.Context())
 			require.ErrorIs(err, tt.clientErr)
 			if tt.clientErr != nil {
 				return

api/health/client_test.go

@@ -48,33 +48,33 @@ func TestClient(t *testing.T) {
 	}
 
 	{
-		readiness, err := c.Readiness(context.Background(), nil)
+		readiness, err := c.Readiness(t.Context(), nil)
 		require.NoError(err)
 		require.True(readiness.Healthy)
 	}
 
 	{
-		health, err := c.Health(context.Background(), nil)
+		health, err := c.Health(t.Context(), nil)
 		require.NoError(err)
 		require.True(health.Healthy)
 	}
 
 	{
-		liveness, err := c.Liveness(context.Background(), nil)
+		liveness, err := c.Liveness(t.Context(), nil)
 		require.NoError(err)
 		require.True(liveness.Healthy)
 	}
 
 	{
-		ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second)
+		ctx, cancel := context.WithTimeout(t.Context(), 3*time.Second)
 		healthy, err := AwaitHealthy(ctx, c, time.Second, nil)
 		cancel()
 		require.NoError(err)
 		require.True(healthy)
 	}
 
 	{
-		ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second)
+		ctx, cancel := context.WithTimeout(t.Context(), 3*time.Second)
 		healthy, err := AwaitReady(ctx, c, time.Second, nil)
 		cancel()
 		require.NoError(err)
@@ -84,15 +84,15 @@ func TestClient(t *testing.T) {
 	mc.reply.Healthy = false
 
 	{
-		ctx, cancel := context.WithTimeout(context.Background(), 20*time.Microsecond)
+		ctx, cancel := context.WithTimeout(t.Context(), 20*time.Microsecond)
 		healthy, err := AwaitHealthy(ctx, c, time.Microsecond, nil)
 		cancel()
 		require.ErrorIs(err, context.DeadlineExceeded)
 		require.False(healthy)
 	}
 
 	{
-		ctx, cancel := context.WithTimeout(context.Background(), 20*time.Microsecond)
+		ctx, cancel := context.WithTimeout(t.Context(), 20*time.Microsecond)
 		healthy, err := AwaitReady(ctx, c, time.Microsecond, nil)
 		cancel()
 		require.ErrorIs(err, context.DeadlineExceeded)
@@ -104,14 +104,14 @@ func TestClient(t *testing.T) {
 	}
 
 	{
-		healthy, err := AwaitHealthy(context.Background(), c, time.Microsecond, nil)
+		healthy, err := AwaitHealthy(t.Context(), c, time.Microsecond, nil)
 		require.NoError(err)
 		require.True(healthy)
 	}
 
 	mc.reply.Healthy = false
 	{
-		healthy, err := AwaitReady(context.Background(), c, time.Microsecond, nil)
+		healthy, err := AwaitReady(t.Context(), c, time.Microsecond, nil)
 		require.NoError(err)
 		require.True(healthy)
 	}

api/health/health_test.go

@@ -125,7 +125,7 @@ func TestPassingChecks(t *testing.T) {
 	require.NoError(h.RegisterHealthCheck("check", check))
 	require.NoError(h.RegisterLivenessCheck("check", check))
 
-	h.Start(context.Background(), checkFreq)
+	h.Start(t.Context(), checkFreq)
 	defer h.Stop()
 
 	{
@@ -189,7 +189,7 @@ func TestPassingThenFailingChecks(t *testing.T) {
 	require.NoError(h.RegisterHealthCheck("check", check))
 	require.NoError(h.RegisterLivenessCheck("check", check))
 
-	h.Start(context.Background(), checkFreq)
+	h.Start(t.Context(), checkFreq)
 	defer h.Stop()
 
 	awaitReadiness(t, h, true)
@@ -240,7 +240,7 @@ func TestDeadlockRegression(t *testing.T) {
 		return "", nil
 	})
 
-	h.Start(context.Background(), time.Nanosecond)
+	h.Start(t.Context(), time.Nanosecond)
 	defer h.Stop()
 
 	for i := 0; i < 100; i++ {
@@ -307,7 +307,7 @@ func TestTags(t *testing.T) {
 		require.False(health)
 	}
 
-	h.Start(context.Background(), checkFreq)
+	h.Start(t.Context(), checkFreq)
 
 	awaitHealthy(t, h, true)