Errors caused by empty HTTP headers. Closes #8

Author: aw

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.1.16 (2015-04-29)
+
+  * Errors caused by empty HTTP headers. Fixes issue #8
+
 ## 0.1.15 (2015-04-29)
 
   * No max-stale = allow anything. Fixes issue #7

lib/formatting.rb

@@ -30,7 +30,7 @@ def format_key
   def clean
     ->(headers) {
       Array(headers).reject {|key, value|
-        HEADERS_NO_CACHE.include?(key) || helper_is_if_modified_error?(key, value)
+        HEADERS_NO_CACHE.include?(key) || helper_is_if_modified_error?(key, value) || value.nil? || value.empty?
       }
     }
   end

test/test_regressions.rb

@@ -35,4 +35,13 @@ def test_bugfix_7_invalid_validation_of_max_stale
 
     assert_kind_of TrueClass, no_max_stale
   end
+
+  # https://github.com/aw/CacheRules/issues/8
+  def test_bugfix_8_errors_caused_by_empty_http_headers
+    isnil   = CacheRules.clean.call({'Content-Type'=>nil})
+    isempty = CacheRules.clean.call({'Content-Type'=>''})
+
+    assert_equal isnil,   []
+    assert_equal isempty, []
+  end
 end