Use StorageMode value from API

[bkvaluemeal]

The default value set for spec.storageMode is null and not LOCAL

[ack-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bkvaluemeal
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ack-prow]

Hi @bkvaluemeal. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[a-hilaly]

Thank you for you PR @bkvaluemeal - according to the MSK API documentation StorageMode can be either LOCAL or TIERED https://docs.aws.amazon.com/MSK/2.0/APIReference/v2-clusters-clusterarn.html

Is there really a third mode where nil trigger a different behaviour?

[bkvaluemeal]

Thank you for your response @a-hilaly! It's been a few days since submitting this PR and, as I spool myself back up on events that led me to author the change, I wonder if this is a behavior only found in AWS US govcloud. I can confirm that the controller was in an infinite loop attempting to change nil to LOCAL only for the next reconciliation loop to discover another nil value because AWS treated it as a no-op. Would it be best to update the PR to conditionally use the API's response if and only if we are in a region like us-gov*?

[michaelhtm]

Hey @bkvaluemeal, it is possible to make operations possible depending on the region.
Can you share the logs of the how this looks like? maybe we can try to reproduce and fix it properly

[ack-bot]

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

[ack-bot]

Stale issues rot after 60d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 60d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle rotten