fix a few log statements from #164 (#169)

Co-authored-by: M00nF1sh <[email protected]>

Author: bigdefect

pkg/aws/cloudmap.go

@@ -167,6 +167,7 @@ func (c *Cloud) CloudMapGetService(ctx context.Context, serviceID string) (*Clou
 
 // RegisterInstance calls AWS ServiceDiscovery RegisterInstance API
 func (c *Cloud) RegisterInstance(ctx context.Context, instanceID string, pod *corev1.Pod, cloudmapConfig *appmesh.AwsCloudMapServiceDiscovery) error {
+	// FIXME we should only emit this if we're actually registering
 	begin := time.Now()
 	defer func() {
 		c.stats.RecordOperationDuration("cloudmap", "instance", "register", time.Since(begin))

pkg/controller/pod.go

@@ -247,7 +247,7 @@ func (c *Controller) syncPod(ctx context.Context, pod *corev1.Pod) error {
 				instanceID := awssdk.StringValue(instance.Id)
 				serviceName := awssdk.StringValue(instance.Attributes[ctrlaws.AttrK8sApp])
 
-				klog.V(4).Info("Pod: %s is currently registered with the service: %s", podName, serviceName)
+				klog.V(4).Infof("Pod: %s is currently registered with the service: %s", podName, serviceName)
 				serviceInstanceSummary[instanceID] = true
 			}
 
@@ -266,14 +266,15 @@ func (c *Controller) syncPod(ctx context.Context, pod *corev1.Pod) error {
 			serviceInstanceSummary = serviceItem.instanceSummary
 			serviceInstanceSummary[pod.Status.PodIP] = true
 		} else {
-			klog.V(4).Info("Instance already %s registered under service  %s", pod.Name, *cloudmapConfig.ServiceName)
+			klog.V(4).Infof("Instance already %s registered under service %s", pod.Name, *cloudmapConfig.ServiceName)
 			return nil
 		}
 	} else {
 		serviceInstanceSummary[pod.Status.PodIP] = true
 	}
 
-	klog.Info("Registering instance %s under service %s", pod.Name, *cloudmapConfig.ServiceName)
+	// FIXME emitting this log is confusing when we might short-circuit in RegisterInstance
+	klog.Infof("Registering instance %s under service %s", pod.Name, *cloudmapConfig.ServiceName)
 	err = c.cloud.RegisterInstance(ctx, instanceID, pod, cloudmapConfig)
 	if err != nil {
 		return err
@@ -298,7 +299,7 @@ func (c *Controller) getServiceInstancesFromCloudMap(ctx context.Context,
 		return instances, err
 	}
 
-	klog.V(4).Info("Reach out to CloudMap for service: %s. Current Instance Count: ",
+	klog.V(4).Infof("Reach out to CloudMap for service: %s. Current Instance Count: %d",
 		*appmeshCloudMapConfig.ServiceName, len(instances))
 	return instances, nil
 }