From 1d51f123887d288207865b4174caf284af96fcb3 Mon Sep 17 00:00:00 2001 From: joy-yu <775154773@qq.com> Date: Thu, 17 Jul 2025 15:46:49 +0800 Subject: [PATCH 1/2] feat(lib-storage): skip uploading parts if they are already listed in uploadedParts. --- lib/lib-storage/src/Upload.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/lib-storage/src/Upload.ts b/lib/lib-storage/src/Upload.ts index 06de3cccdaef..1b783afe7517 100644 --- a/lib/lib-storage/src/Upload.ts +++ b/lib/lib-storage/src/Upload.ts @@ -247,6 +247,11 @@ export class Upload extends EventEmitter { } } + // If the part is already uploaded, skip it. + if (this.uploadedParts.some((uploadedPart) => uploadedPart.PartNumber === dataPart.partNumber)) { + continue; + } + const partSize: number = byteLength(dataPart.data) || 0; const requestHandler = this.client.config.requestHandler; From f382db076e433f9281dc67d929b6932758b4d6b0 Mon Sep 17 00:00:00 2001 From: joy-yu <775154773@qq.com> Date: Fri, 8 Aug 2025 10:09:41 +0800 Subject: [PATCH 2/2] fix(lib-storage): adopt the suggested changes from the review --- lib/lib-storage/src/Upload.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/lib-storage/src/Upload.ts b/lib/lib-storage/src/Upload.ts index 1b783afe7517..9ae3a913aca4 100644 --- a/lib/lib-storage/src/Upload.ts +++ b/lib/lib-storage/src/Upload.ts @@ -247,10 +247,8 @@ export class Upload extends EventEmitter { } } - // If the part is already uploaded, skip it. - if (this.uploadedParts.some((uploadedPart) => uploadedPart.PartNumber === dataPart.partNumber)) { - continue; - } + // ✅ Suggestion: Use early continue with concise condition + if (this.uploadedParts.some(p => p.PartNumber === dataPart.partNumber)) continue; const partSize: number = byteLength(dataPart.data) || 0;