Skip to content

Commit 6a633c5

Browse files
authored
Merge pull request #39 from pintaoz-aws/fix_double_quotes
Fix dictionary type cluster parameters in k8s template yaml
2 parents 9a3ad87 + f047899 commit 6a633c5

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

launcher/nemo/stages.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
# Portions taken from https://github.com/NVIDIA/NeMo-Framework-Launcher, Copyright Nvidia Corporation
1414

1515

16+
from ast import literal_eval
1617
import logging
1718
import shutil
1819
from pathlib import Path
@@ -694,13 +695,13 @@ def generate_default_k8s_value_template(self, template_root, cluster_parameters,
694695
if cluster_parameters.get("namespace", None) is not None:
695696
values_template.trainingConfig.namespace = cluster_parameters["namespace"]
696697
if cluster_parameters.get("annotations", None) is not None:
697-
values_template.trainingConfig.annotations = cluster_parameters["annotations"]
698+
values_template.trainingConfig.annotations = literal_eval(cluster_parameters["annotations"])
698699
if cluster_parameters.get("priority_class_name", None) is not None:
699700
values_template.trainingConfig.priorityClassName = cluster_parameters["priority_class_name"]
700701
if cluster_parameters.get("service_account_name") is not None:
701702
values_template.trainingConfig.serviceAccountName = cluster_parameters["service_account_name"]
702703
if cluster_parameters.get("custom_labels", None) is not None:
703-
values_template.trainingConfig.customLabels = cluster_parameters["custom_labels"]
704+
values_template.trainingConfig.customLabels = literal_eval(cluster_parameters["custom_labels"])
704705
if cluster_parameters.get("label_selector", None) is not None:
705706
values_template.trainingConfig.labelSelector = cluster_parameters["label_selector"]
706707
values_template.trainingConfig.compile = OmegaConf.select(self.cfg, "recipes.run.compile", default=0)

0 commit comments

Comments
 (0)