fix(measure): fix port option (#192)

Almouro · web-flow · commit 1d8585f099b9 · 2024-01-18T11:46:53.000+01:00
When building the Flashlight CLI, for some reason the comment in the HTML file got removed
Actually it's unclear to me why it wasn't getting removed before, now at least we're sure that this will never get removed by parcel
diff --git a/packages/commands/measure/src/__tests__/server/ServerApp.test.ts b/packages/commands/measure/src/__tests__/server/ServerApp.test.ts
@@ -20,7 +20,9 @@ describe("ServerApp", () => {
   });
 
   beforeEach(() => {
-    (fs.promises.readFile as jest.Mock).mockResolvedValue("<html>/* %FLASHLIGHT_DATA% */</html>");
+    (fs.promises.readFile as jest.Mock).mockResolvedValue(
+      "<html><script>__FLASHLIGHT_DATA__;</script></html>"
+    );
 
     app = createExpressApp(injected);
   });
@@ -37,6 +39,6 @@ describe("ServerApp", () => {
   test("index.html contains the FlashlightData placeholder", async () => {
     const fsPromises = jest.requireActual("fs").promises;
     const fileContent = await fsPromises.readFile(`${__dirname}/../../webapp/index.html`, "utf8");
-    expect(fileContent).toContain("/* %FLASHLIGHT_DATA% */");
+    expect(fileContent).toContain("__FLASHLIGHT_DATA__;");
   });
 });
diff --git a/packages/commands/measure/src/server/ServerApp.tsx b/packages/commands/measure/src/server/ServerApp.tsx
@@ -25,7 +25,7 @@ export const createExpressApp = (injected: FlashlightData) => {
       const indexHtml = path.join(pathToDist, "index.html");
       let data = await fs.readFile(indexHtml, "utf8");
       data = data.replace(
-        "/* %FLASHLIGHT_DATA% */",
+        "__FLASHLIGHT_DATA__;",
         `window.__FLASHLIGHT_DATA__ = ${JSON.stringify(injected)};`
       );
       res.send(data);
diff --git a/packages/commands/measure/src/webapp/index.html b/packages/commands/measure/src/webapp/index.html
@@ -24,7 +24,7 @@
     <div id="app"></div>
     <script type="module" src="index.js"></script>
     <script>
-      /* %FLASHLIGHT_DATA% */
+      __FLASHLIGHT_DATA__;
     </script>
   </body>
 </html>
