Changed stream reading methods to be static extension methods of the StreamReader class

Author: basicx-StrgV

src/WGet.NET/Components/Internal/ProcessManager.cs

@@ -2,14 +2,12 @@
 // Created by basicx-StrgV                          //
 // https://github.com/basicx-StrgV/                 //
 //--------------------------------------------------//
-using System;
-using System.IO;
+using System.Diagnostics;
 using System.Text;
 using System.Threading;
-using System.Diagnostics;
 using System.Threading.Tasks;
-using WGetNET.Models;
 using WGetNET.Extensions;
+using WGetNET.Models;
 
 namespace WGetNET.Components.Internal
 {
@@ -114,7 +112,7 @@ private ProcessResult RunProcess(ProcessStartInfo processStartInfo)
             {
                 proc.Start();
 
-                result.Output = ReadSreamOutput(proc.StandardOutput);
+                result.Output = proc.StandardOutput.ReadSreamOutputByLine();
 
                 //Wait till end and get exit code
                 proc.WaitForExit();
@@ -153,7 +151,7 @@ private async Task<ProcessResult> RunProcessAsync(ProcessStartInfo processStartI
             {
                 proc.Start();
 
-                result.Output = await ReadSreamOutputAsync(proc.StandardOutput, cancellationToken);
+                result.Output = await proc.StandardOutput.ReadSreamOutputByLineAsync(cancellationToken);
 
                 // Kill the process and return, if the task is canceled
                 if (cancellationToken.IsCancellationRequested && !proc.HasExited)
@@ -179,71 +177,5 @@ private async Task<ProcessResult> RunProcessAsync(ProcessStartInfo processStartI
 
             return result;
         }
-
-        /// <summary>
-        /// Reads the data from the process output to a string array.
-        /// </summary>
-        /// <param name="output">
-        /// The <see cref="StreamReader"/> with the process output.
-        /// </param>
-        /// <returns>
-        /// A <see cref="string"/> array 
-        /// containing the process output stream content by lines.
-        /// </returns>
-        private string[] ReadSreamOutput(StreamReader output)
-        {
-            string[] outputArray = Array.Empty<string>();
-
-            //Read output to list
-            while (!output.EndOfStream)
-            {
-                string? outputLine = output.ReadLine();
-                if (outputLine is null)
-                {
-                    continue;
-                }
-
-                outputArray = outputArray.Add(outputLine);
-            }
-
-            return outputArray;
-        }
-
-        /// <summary>
-        /// Asynchronous reads the data from the process output to a string array.
-        /// </summary>
-        /// <param name="output">
-        /// The <see cref="System.IO.StreamReader"/> with the process output.
-        /// </param>
-        /// <param name="cancellationToken">
-        /// The <see cref="System.Threading.CancellationToken"/> for the <see cref="System.Threading.Tasks.Task"/>.
-        /// </param>
-        /// <returns>
-        /// A <see cref="string"/> array 
-        /// containing the process output stream content by lines.
-        /// </returns>
-        private async Task<string[]> ReadSreamOutputAsync(StreamReader output, CancellationToken cancellationToken = default)
-        {
-            string[] outputArray = Array.Empty<string>();
-
-            //Read output to list
-            while (!output.EndOfStream)
-            {
-                if (cancellationToken.IsCancellationRequested)
-                {
-                    break;
-                }
-
-                string? outputLine = await output.ReadLineAsync();
-                if (outputLine is null)
-                {
-                    continue;
-                }
-
-                outputArray = outputArray.Add(outputLine);
-            }
-
-            return outputArray;
-        }
     }
 }

src/WGet.NET/Extensions/StreamReaderExtensions.cs

@@ -0,0 +1,84 @@
+//--------------------------------------------------//
+// Created by basicx-StrgV                          //
+// https://github.com/basicx-StrgV/                 //
+//--------------------------------------------------//
+using System;
+using System.IO;
+using System.Threading;
+using System.Threading.Tasks;
+
+namespace WGetNET.Extensions
+{
+    /// <summary>
+    /// The <see langword="static"/> <see cref="StreamReaderExtensions"/> class,
+    /// provieds extension methods for the <see cref="System.IO.StringReader"/>.
+    /// </summary>
+    internal static class StreamReaderExtensions
+    {
+        /// <summary>
+        /// Reads the data from the process output to a string array.
+        /// </summary>
+        /// <param name="output">
+        /// The <see cref="StreamReader"/> with the process output.
+        /// </param>
+        /// <returns>
+        /// A <see cref="string"/> array 
+        /// containing the process output stream content by lines.
+        /// </returns>
+        public static string[] ReadSreamOutputByLine(this StreamReader output)
+        {
+            string[] outputArray = Array.Empty<string>();
+
+            //Read output to list
+            while (!output.EndOfStream)
+            {
+                string? outputLine = output.ReadLine();
+                if (outputLine is null)
+                {
+                    continue;
+                }
+
+                outputArray = outputArray.Add(outputLine);
+            }
+
+            return outputArray;
+        }
+
+        /// <summary>
+        /// Asynchronous reads the data from the process output to a string array.
+        /// </summary>
+        /// <param name="output">
+        /// The <see cref="System.IO.StreamReader"/> with the process output.
+        /// </param>
+        /// <param name="cancellationToken">
+        /// The <see cref="System.Threading.CancellationToken"/> for the <see cref="System.Threading.Tasks.Task"/>.
+        /// </param>
+        /// <returns>
+        /// A <see cref="string"/> array 
+        /// containing the process output stream content by lines.
+        /// </returns>
+        public static async Task<string[]> ReadSreamOutputByLineAsync(this StreamReader output, CancellationToken cancellationToken = default)
+        {
+            string[] outputArray = Array.Empty<string>();
+
+            //Read output to list
+            while (!output.EndOfStream)
+            {
+                if (cancellationToken.IsCancellationRequested)
+                {
+                    break;
+                }
+
+                string? outputLine = await output.ReadLineAsync();
+                if (outputLine is null)
+                {
+                    continue;
+                }
+
+                outputArray = outputArray.Add(outputLine);
+            }
+
+            return outputArray;
+        }
+    }
+}