refactor(payment): Moved BT Credit card payment strategy

Author: andriiVitvitskyi1990

packages/braintree-integration/src/braintree-credit-card/braintree-credit-card-payment-strategy.spec.ts

@@ -46,7 +46,7 @@ import PaymentRequestTransformer from '../../payment-request-transformer';
 
 import BraintreeCreditCardPaymentStrategy from './braintree-credit-card-payment-strategy';
 import { BraintreePaymentInitializeOptions } from './braintree-payment-options';
-import BraintreePaymentProcessor from './braintree-payment-processor';
+import BraintreePaymentProcessor from '../../../braintree-utils/src/braintree-payment-processor';
 import { getTokenizeResponseBody } from './braintree.mock';
 
 describe('BraintreeCreditCardPaymentStrategy', () => {

packages/braintree-integration/src/braintree-credit-card/braintree-credit-card-payment-strategy.ts

@@ -3,6 +3,7 @@ import { some } from 'lodash';
 import {
     BraintreeIntegrationService,
     isBraintreeAcceleratedCheckoutCustomer,
+    BraintreePaymentProcessor,
 } from '@bigcommerce/checkout-sdk/braintree-utils';
 import {
     Address,
@@ -62,9 +63,9 @@ export default class BraintreeCreditCardPaymentStrategy implements PaymentStrate
                 await this.braintreePaymentProcessor.initializeHostedForm(
                     braintree.form,
                     braintree.unsupportedCardBrands,
-                ); // TODO: FIX
+                );
                 this.isHostedFormInitialized =
-                    this.braintreePaymentProcessor.isInitializedHostedForm(); // TODO: FIX
+                    this.braintreePaymentProcessor.isInitializedHostedForm();
             }
 
             this.is3dsEnabled = this.paymentMethod.config.is3dsEnabled;
@@ -89,7 +90,7 @@ export default class BraintreeCreditCardPaymentStrategy implements PaymentStrate
         }
 
         if (this.isHostedFormInitialized) {
-            this.braintreePaymentProcessor.validateHostedForm(); // TODO: FIX
+            this.braintreePaymentProcessor.validateHostedForm();
         }
 
         await this.paymentIntegrationService.submitOrder();
@@ -117,14 +118,8 @@ export default class BraintreeCreditCardPaymentStrategy implements PaymentStrate
     async deinitialize(): Promise<void> {
         this.isHostedFormInitialized = false;
 
-        // await Promise.all([
-        //     // this.braintreePaymentProcessor.deinitialize(), //TODO: FIX
-        //     this.braintreeIntegrationService.teardown(),
-        //     this.braintreePaymentProcessor.deinitializeHostedForm(), //TODO: FIX
-        // ]);
-
-         await this.braintreeIntegrationService.teardown();
-         await this.braintreePaymentProcessor.deinitializeHostedForm(); //TODO: FIX
+        await this.braintreeIntegrationService.teardown();
+        await this.braintreePaymentProcessor.deinitializeHostedForm();
 
         return Promise.resolve();
     }
@@ -156,8 +151,8 @@ export default class BraintreeCreditCardPaymentStrategy implements PaymentStrate
             isHostedInstrumentLike(paymentData) ? paymentData : {};
 
         const { nonce } = this.shouldPerform3DSVerification(payment)
-            ? await this.braintreePaymentProcessor.verifyCard(payment, billingAddress, orderAmount) //TODO:FIX
-            : await this.braintreePaymentProcessor.tokenizeCard(payment, billingAddress); //TODO: FIX
+            ? await this.braintreePaymentProcessor.verifyCard(payment, billingAddress, orderAmount)
+            : await this.braintreePaymentProcessor.tokenizeCard(payment, billingAddress);
 
         return {
             ...commonPaymentData,
@@ -177,7 +172,7 @@ export default class BraintreeCreditCardPaymentStrategy implements PaymentStrate
 
         if (this.isSubmittingWithStoredCard(payment)) {
             const { nonce } =
-                await this.braintreePaymentProcessor.tokenizeHostedFormForStoredCardVerification(); //TODO: FIX
+                await this.braintreePaymentProcessor.tokenizeHostedFormForStoredCardVerification();
 
             return {
                 ...commonPaymentData,
@@ -190,11 +185,11 @@ export default class BraintreeCreditCardPaymentStrategy implements PaymentStrate
             isHostedInstrumentLike(paymentData) ? paymentData : {};
 
         const { nonce } = this.shouldPerform3DSVerification(payment)
-            ? await this.braintreePaymentProcessor.verifyCardWithHostedForm( //TODO: FIX
+            ? await this.braintreePaymentProcessor.verifyCardWithHostedForm(
                 billingAddress,
                 orderAmount,
             )
-            : await this.braintreePaymentProcessor.tokenizeHostedForm(billingAddress); //TODO: FIX
+            : await this.braintreePaymentProcessor.tokenizeHostedForm(billingAddress);
 
         return {
             ...commonPaymentData,
@@ -227,7 +222,7 @@ export default class BraintreeCreditCardPaymentStrategy implements PaymentStrate
             }
 
             const instrument = state.getCardInstrumentOrThrow(paymentData.instrumentId);
-            const { nonce } = await this.braintreePaymentProcessor.challenge3DSVerification( //TODO: FIX
+            const { nonce } = await this.braintreePaymentProcessor.challenge3DSVerification(
                 {
                     nonce: storedCreditCardNonce,
                     bin: instrument.iin,

packages/braintree-integration/src/braintree-credit-card/create-braintree-credit-card-payment-strategy.spec.ts

@@ -0,0 +1,19 @@
+import { PaymentIntegrationService } from '@bigcommerce/checkout-sdk/payment-integration-api';
+import { PaymentIntegrationServiceMock } from '@bigcommerce/checkout-sdk/payment-integrations-test-utils';
+
+import createBraintreeCreditCardPaymentStrategy from './create-braintree-credit-card-payment-strategy';
+import BraintreeCreditCardPaymentStrategy from './braintree-credit-card-payment-strategy';
+
+describe('createBraintreeCreditCardPaymentStrategy', () => {
+    let paymentIntegrationService: PaymentIntegrationService;
+
+    beforeEach(() => {
+        paymentIntegrationService = new PaymentIntegrationServiceMock();
+    });
+
+    it('instantiates braintree credit card payment strategy', () => {
+        const strategy = createBraintreeCreditCardPaymentStrategy(paymentIntegrationService);
+
+        expect(strategy).toBeInstanceOf(BraintreeCreditCardPaymentStrategy);
+    });
+});

packages/braintree-integration/src/braintree-credit-card/create-braintree-credit-card-payment-strategy.ts

@@ -0,0 +1,42 @@
+import { getScriptLoader } from '@bigcommerce/script-loader';
+
+import {
+    BraintreeHostWindow,
+    BraintreeIntegrationService,
+    BraintreePaymentProcessor,
+    BraintreeScriptLoader,
+} from '@bigcommerce/checkout-sdk/braintree-utils';
+import {
+    PaymentStrategyFactory,
+    toResolvableModule,
+} from '@bigcommerce/checkout-sdk/payment-integration-api';
+import BraintreeCreditCardPaymentStrategy from './braintree-credit-card-payment-strategy';
+import { BraintreeHostedForm } from '@bigcommerce/checkout-sdk/braintree-integration';
+
+const createBraintreeCreditCardPaymentStrategy: PaymentStrategyFactory<
+    BraintreeCreditCardPaymentStrategy
+> = (paymentIntegrationService) => {
+    const braintreeHostWindow: BraintreeHostWindow = window;
+    const braintreeIntegrationService = new BraintreeIntegrationService(
+        new BraintreeScriptLoader(getScriptLoader(), braintreeHostWindow),
+        braintreeHostWindow,
+    );
+    const braintreeHostedForm = new BraintreeHostedForm(
+        braintreeIntegrationService,
+        new BraintreeScriptLoader(getScriptLoader(), braintreeHostWindow),
+    );
+    const braintreePaymentProcessor = new BraintreePaymentProcessor(
+        braintreeIntegrationService,
+        braintreeHostedForm,
+    );
+
+    return new BraintreeCreditCardPaymentStrategy(
+        paymentIntegrationService,
+        braintreePaymentProcessor,
+        braintreeIntegrationService
+    );
+};
+
+export default toResolvableModule(createBraintreeCreditCardPaymentStrategy, [
+    { id: 'braintree' },
+]);