refactor(payment): Moved BT Credit card payment strategy

Author: andriiVitvitskyi1990

packages/braintree-integration/src/braintree-credit-card/braintree-credit-card-payment-strategy.spec.ts

@@ -13,7 +13,7 @@ import {
     BraintreeFastlane,
     BraintreeIntegrationService,
     BraintreePaymentProcessor,
-    BraintreeScriptLoader,
+    BraintreeScriptLoader, BraintreeSDKVersionManager,
     getBraintree,
     getFastlaneMock,
     getHostedFieldsMock,
@@ -40,6 +40,7 @@ describe('BraintreeCreditCardPaymentStrategy', () => {
     let braintreeHostedForm: BraintreeHostedForm;
     let paymentMethod: any; // TODO: FIX
     let braintreeFastlaneMock: BraintreeFastlane;
+    let braintreeSDKVersionManager: BraintreeSDKVersionManager;
 
     beforeEach(() => {
         const methodId = 'braintree';
@@ -51,7 +52,12 @@ describe('BraintreeCreditCardPaymentStrategy', () => {
                 shouldRunAcceleratedCheckout: true,
             },
         };
-        braintreeScriptLoader = new BraintreeScriptLoader(getScriptLoader(), window);
+        braintreeSDKVersionManager = new BraintreeSDKVersionManager(paymentIntegrationService);
+        braintreeScriptLoader = new BraintreeScriptLoader(
+            getScriptLoader(),
+            window,
+            braintreeSDKVersionManager,
+        );
         braintreeFastlaneMock = getFastlaneMock();
         paymentIntegrationService = new PaymentIntegrationServiceMock();
         braintreeIntegrationService = new BraintreeIntegrationService(

packages/braintree-integration/src/braintree-credit-card/create-braintree-credit-card-payment-strategy.ts

@@ -5,6 +5,7 @@ import {
     BraintreeIntegrationService,
     BraintreePaymentProcessor,
     BraintreeScriptLoader,
+    BraintreeSDKVersionManager,
 } from '@bigcommerce/checkout-sdk/braintree-utils';
 import {
     PaymentStrategyFactory,
@@ -17,13 +18,22 @@ const createBraintreeCreditCardPaymentStrategy: PaymentStrategyFactory<
     BraintreeCreditCardPaymentStrategy
 > = (paymentIntegrationService) => {
     const braintreeHostWindow: BraintreeHostWindow = window;
+    const braintreeSDKVersionManager = new BraintreeSDKVersionManager(paymentIntegrationService);
     const braintreeIntegrationService = new BraintreeIntegrationService(
-        new BraintreeScriptLoader(getScriptLoader(), braintreeHostWindow),
+        new BraintreeScriptLoader(
+            getScriptLoader(),
+            braintreeHostWindow,
+            braintreeSDKVersionManager,
+        ),
         braintreeHostWindow,
     );
     const braintreeHostedForm = new BraintreeHostedForm(
         braintreeIntegrationService,
-        new BraintreeScriptLoader(getScriptLoader(), braintreeHostWindow),
+        new BraintreeScriptLoader(
+            getScriptLoader(),
+            braintreeHostWindow,
+            braintreeSDKVersionManager,
+        ),
     );
     const braintreePaymentProcessor = new BraintreePaymentProcessor(
         braintreeIntegrationService,

packages/braintree-utils/src/mocks/braintree-modules.mock.ts

@@ -43,6 +43,7 @@ export function getModuleCreatorMock<T>(
  */
 export function getClientMock(): BraintreeClient {
     return {
+        getVersion: jest.fn,
         request: jest.fn(),
     };
 }

packages/payment-integration-api/src/payment/instrument.ts

@@ -1,10 +1,4 @@
-import { HostedInstrument, NonceInstrument } from './payment';
-
-type PaymentInstrument =
-    | CardInstrument
-    | AccountInstrument
-    | HostedInstrument
-    | NonceInstrument;
+type PaymentInstrument = | CardInstrument | AccountInstrument;
 
 export default PaymentInstrument;