fix(payment): PAYPAL-5925 fixed 3ds PPCP FL nonce (#3013)

Author: andriiVitvitskyi1990

packages/paypal-commerce-integration/src/paypal-commerce-fastlane/paypal-commerce-fastlane-payment-strategy.spec.ts

@@ -586,7 +586,7 @@ describe('PayPalCommerceFastlanePaymentStrategy', () => {
 
                 expect(paypalCommerceRequestSender.createOrder).toHaveBeenCalledWith(methodId, {
                     cartId: cart.id,
-                    fastlaneToken: 'paypal_fastlane_instrument_id_nonce',
+                    fastlaneToken: 'paypal_fastlane_instrument_id_nonce_3ds',
                 });
             });
 

packages/paypal-commerce-integration/src/paypal-commerce-fastlane/paypal-commerce-fastlane-payment-strategy.ts

@@ -448,26 +448,17 @@ export default class PaypalCommerceFastlanePaymentStrategy implements PaymentStr
 
             if (
                 liabilityShift === LiabilityShiftEnum.No ||
-                liabilityShift === LiabilityShiftEnum.Unknown
+                liabilityShift === LiabilityShiftEnum.Unknown ||
+                authenticationState === TDSecureAuthenticationState.Errored ||
+                authenticationState === TDSecureAuthenticationState.Cancelled
             ) {
                 throw new PaymentMethodInvalidError();
             }
 
-            await this.createOrder(paypalNonce);
-
             if (authenticationState === TDSecureAuthenticationState.Succeeded) {
+                await this.createOrder(nonce);
                 return nonce;
             }
-
-            // Cancelled or errored, merchant can choose to send the customer back to 3D Secure or submit a payment and or vault the payment token.
-            if (authenticationState === TDSecureAuthenticationState.Errored) {
-                throw new PaymentMethodInvalidError();
-            }
-
-            if (authenticationState === TDSecureAuthenticationState.Cancelled) {
-                console.error('3DS check was canceled');
-                throw new PaymentMethodInvalidError();
-            }
         }
 
         return paypalNonce;