[PM-25012] Add data field to Cipher type, and add functions for client-side parsing of the field. #517

nikwithak · 2025-10-17T20:27:53Z

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-25012

📔 Objective

This PR adds the data field to the Cipher struct, and adds a function for parsing that field into the appropriate CipherType (Identity, SshKey, Login, SecureNote, Card) on the client-side, rather than consuming the server-provided values.

The function sits unused - after #455 is merged, we should consider adding this to the CiphersClient::get and CipherClient::list functions behind a new feature flag.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

…ient::migrate

… vault/PM-25012/cipher_opaque_data

claude · 2025-10-17T20:28:14Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

github-actions · 2025-10-17T20:32:56Z

Checkmarx One – Scan Summary & Details – f05c7793-b79a-49c2-be9b-3af9fcb96f0d

Great job! No new security vulnerabilities introduced in this pull request

codecov · 2025-10-17T20:42:29Z

Codecov Report

❌ Patch coverage is 97.92208% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.96%. Comparing base (8ef7951) to head (0288979).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/bitwarden-vault/src/error.rs	0.00%	7 Missing ⚠️
crates/bitwarden-vault/src/cipher/cipher.rs	99.73%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
+ Coverage   78.70%   78.96%   +0.26%     
==========================================
  Files         296      296              
  Lines       30500    30884     +384     
==========================================
+ Hits        24005    24388     +383     
- Misses       6495     6496       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gbubemismith

This looks really good. I just have a few questions

crates/bitwarden-vault/src/cipher/cipher.rs

gbubemismith · 2025-10-22T17:16:11Z

@nikwithak I think we can target main directly

… vault/PM-25012/cipher_opaque_data

sonarqubecloud · 2025-10-22T21:51:45Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.2% Duplication on New Code

See analysis details on SonarQube Cloud

coroiu

I don't think platform owns any of this code anymore, but I'll approve anyways :)

…ta field to Cipher type, and add functions for client-side parsing of the field. (bitwarden/sdk-internal#517)

rishancmm-eng · 2025-11-01T14:12:29Z

Tracking
https://bitwarden.atlassian.net/browse/PM-258

📔 Objective

This PR adds the data field to the Cipher struct, and adds a function for parsing that field into the appropriate CipherType (Identity, SshKey, Login, SecureNote, Card) on the client-side, rather than consuming the server-provided values.

The function sits unused - after #455 is merged, we should consider adding this to the CiphersClient::get and CipherClient::list functions behind a new feature flag.

Reminders before review

Contributor guidelines followed

All formatters and local linters executed and passed

Written new unit and / or integration tests where applicable

Protected functional changes with optionality (feature flags)

Used internationalization (i18n) for all UI strings

CI builds passed

Communicated to DevOps any deployment requirements

Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changed

📝 (:memo:) or ℹ️ (:information_source:) for notes or general info

❓ (:question:) for questions

🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
issue and could potentially benefit from discussion

🎨 (:art:) for suggestions / improvements

❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention

🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt

⛏ (:pick:) for minor or nitpick changes

nikwithak added 11 commits October 15, 2025 17:09

Add data field to Cipher, and basic json deserialization in CiphersCl…

94b1ead

…ient::migrate

Consume exisiting migrate function, with ciphertype extractions

91e1e1e

Move extract_cipher_types to be a function on Cipher

7c14764

Extract cipher types for cipher.rs

b5f7869

Add tests for populate_cipher_types

fb4eef4

Fix clippy errors

7fb7cf3

Update Cipher::populate_cipher_types with better error handling.

3df87a1

Empty commit to update GH PR

17aee3a

Fix build issues from merge

7b3d952

Merge branch 'main' of https://github.com/bitwarden/sdk-internal into…

e283cf6

… vault/PM-25012/cipher_opaque_data

Cleanup: Remove commented code and move test constants to top of mod

15558fb

nikwithak requested a review from gbubemismith October 17, 2025 20:27

nikwithak marked this pull request as ready for review October 17, 2025 20:29

nikwithak requested review from a team as code owners October 17, 2025 20:29

gbubemismith reviewed Oct 20, 2025

View reviewed changes

crates/bitwarden-vault/src/cipher/cipher.rs Show resolved Hide resolved

crates/bitwarden-vault/src/cipher/cipher.rs Outdated Show resolved Hide resolved

crates/bitwarden-vault/src/cipher/cipher.rs Show resolved Hide resolved

nikwithak added 3 commits October 22, 2025 14:32

Merge branch 'main' of https://github.com/bitwarden/sdk-internal into…

4f4853d

… vault/PM-25012/cipher_opaque_data

Add comment for unused reason on populate_cipher_types

4424d5f

Add field to Cipher struct in missing files

02cdfa1

nikwithak requested a review from a team as a code owner October 22, 2025 21:45

nikwithak requested a review from coroiu October 22, 2025 21:45

nikwithak changed the base branch from vault/feature/cipher-versioning to main October 22, 2025 21:45

nikwithak requested a review from gbubemismith October 22, 2025 21:46

gbubemismith approved these changes Oct 23, 2025

View reviewed changes

coroiu approved these changes Oct 24, 2025

View reviewed changes

nikwithak added 2 commits October 28, 2025 10:39

Merge branch 'main' into vault/PM-25012/cipher_opaque_data

fae108f

Merge branch 'main' into vault/PM-25012/cipher_opaque_data

0288979

nikwithak merged commit 21432b5 into main Oct 31, 2025
52 of 53 checks passed

nikwithak deleted the vault/PM-25012/cipher_opaque_data branch October 31, 2025 21:37

bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Oct 31, 2025

bitwarden/sdk-internal@21432b5 1.0.0-2892-21432b5 - [PM-25012] Add da…

977e656

…ta field to Cipher type, and add functions for client-side parsing of the field. (bitwarden/sdk-internal#517)

This was referenced Oct 31, 2025

Updating SDK to 977e656 (1.0.0-2892-21432b5) bitwarden/ios#2058

Open

Update SDK to 1.0.0-3580-21432b51 bitwarden/android#6064

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[PM-25012] Add data field to Cipher type, and add functions for client-side parsing of the field. #517

[PM-25012] Add data field to Cipher type, and add functions for client-side parsing of the field. #517

Uh oh!

nikwithak commented Oct 17, 2025

Uh oh!

claude bot commented Oct 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 17, 2025 •

edited

Loading

Uh oh!

codecov bot commented Oct 17, 2025 •

edited

Loading

Uh oh!

gbubemismith left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gbubemismith commented Oct 22, 2025

Uh oh!

sonarqubecloud bot commented Oct 22, 2025

Uh oh!

coroiu left a comment

Uh oh!

Uh oh!

rishancmm-eng commented Nov 1, 2025

📔 Objective

Reminders before review

🦮 Reviewer guidelines

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[PM-25012] Add data field to Cipher type, and add functions for client-side parsing of the field. #517

[PM-25012] Add data field to Cipher type, and add functions for client-side parsing of the field. #517

Uh oh!

Conversation

nikwithak commented Oct 17, 2025

🎟️ Tracking

📔 Objective

⏰ Reminders before review

🦮 Reviewer guidelines

Uh oh!

claude bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Great job! No new security vulnerabilities introduced in this pull request

Uh oh!

codecov bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gbubemismith left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gbubemismith commented Oct 22, 2025

Uh oh!

sonarqubecloud bot commented Oct 22, 2025

Quality Gate passed

Uh oh!

coroiu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rishancmm-eng commented Nov 1, 2025

📔 Objective

Reminders before review

🦮 Reviewer guidelines

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

claude bot commented Oct 17, 2025 •

edited

Loading

github-actions bot commented Oct 17, 2025 •

edited

Loading

codecov bot commented Oct 17, 2025 •

edited

Loading