Skip to content

Commit c0d733d

Browse files
Run installer before instantiating runner (#1487)
1 parent 63cde1c commit c0d733d

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/main/java/com/blackduck/integration/detect/tool/signaturescanner/operation/CreateScanBatchRunnerWithBlackDuck.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
import com.blackduck.integration.blackduck.codelocation.signaturescanner.ScanBatchRunner;
1313
import com.blackduck.integration.blackduck.configuration.BlackDuckServerConfig;
14+
import com.blackduck.integration.blackduck.exception.BlackDuckIntegrationException;
1415
import com.blackduck.integration.blackduck.http.client.BlackDuckHttpClient;
1516
import com.blackduck.integration.blackduck.http.client.SignatureScannerClient;
1617
import com.blackduck.integration.blackduck.keystore.KeyStoreHelper;
@@ -35,7 +36,7 @@ public CreateScanBatchRunnerWithBlackDuck(IntEnvironmentVariables intEnvironment
3536
this.executorService = executorService;
3637
}
3738

38-
public ScanBatchRunner createScanBatchRunner(BlackDuckServerConfig blackDuckServerConfig, File installDirectory, Optional<BlackDuckVersion> blackDuckVersion) {
39+
public ScanBatchRunner createScanBatchRunner(BlackDuckServerConfig blackDuckServerConfig, File installDirectory, Optional<BlackDuckVersion> blackDuckVersion) throws BlackDuckIntegrationException {
3940
logger.debug("Signature scanner will use the Black Duck server to download/update the scanner - this is the most likely situation.");
4041
SignatureScannerLogger slf4jIntLogger = new SignatureScannerLogger(logger);
4142
ScanPathsUtility scanPathsUtility = new ScanPathsUtility(slf4jIntLogger, intEnvironmentVariables, operatingSystemType);
@@ -75,11 +76,12 @@ public ScanBatchRunner createScanBatchRunner(BlackDuckServerConfig blackDuckServ
7576
);
7677
}
7778

78-
return ScanBatchRunner.createComplete(intEnvironmentVariables, scanPathsUtility, scanCommandRunner, scannerInstallerVariant);
79+
File installedDir = scannerInstallerVariant.installOrUpdateScanner();
80+
81+
return ScanBatchRunner.createWithNoInstaller(intEnvironmentVariables, scanPathsUtility, scanCommandRunner, installedDir);
7982
}
8083

8184
private boolean shouldUseToolsApiScannerInstaller(Optional<BlackDuckVersion> blackDuckVersion) {
8285
return blackDuckVersion.isPresent() && blackDuckVersion.get().isAtLeast(MIN_BLACK_DUCK_VERSION);
8386
}
84-
8587
}

0 commit comments

Comments
 (0)