fix tests failing due to real RPC calls

Author: MMujtabaRoohani-BlockApex

.eslintrc.js

@@ -1,9 +1,10 @@
 const { fixupPluginRules } = require('@eslint/compat')
 const { FlatCompat } = require('@eslint/eslintrc')
 const js = require('@eslint/js')
-const typescriptEslintEslintPlugin = require('@typescript-eslint/eslint-plugin')
 const tsParser = require('@typescript-eslint/parser')
 const _import = require('eslint-plugin-import')
+const prettier = require('eslint-plugin-prettier')
+const prettierConfig = require('eslint-config-prettier')
 const globals = require('globals')
 
 const compat = new FlatCompat({
@@ -14,13 +15,14 @@ const compat = new FlatCompat({
 
 module.exports = [
   {
-    ignores: ['**/eslint.config.js'],
+    ignores: ['**/eslint.config.js', '**/dist/**', '**/node_modules/**'],
   },
-  ...compat.extends('plugin:@typescript-eslint/recommended', 'plugin:prettier/recommended'),
+  ...compat.extends('plugin:@typescript-eslint/recommended'),
+  prettierConfig,
   {
     plugins: {
-      '@typescript-eslint': typescriptEslintEslintPlugin,
       import: fixupPluginRules(_import),
+      prettier: fixupPluginRules(prettier),
     },
 
     languageOptions: {
@@ -30,7 +32,7 @@ module.exports = [
       },
 
       parser: tsParser,
-      ecmaVersion: 5,
+      ecmaVersion: 'latest',
       sourceType: 'module',
 
       parserOptions: {
@@ -43,14 +45,14 @@ module.exports = [
       '@typescript-eslint/explicit-function-return-type': 'off',
       '@typescript-eslint/explicit-module-boundary-types': 'off',
       '@typescript-eslint/no-explicit-any': 'off',
+      'prettier/prettier': 'error',
 
       'import/order': [
         'error',
         {
           alphabetize: {
             order: 'asc',
           },
-
           groups: [
             ['builtin', 'external'],
             ['internal', 'parent', 'sibling', 'index'],

eslint.config.js

@@ -16,7 +16,7 @@
     "format": "prettier --write \"src/**/*.ts\"",
     "lint": "eslint \"{src,apps,libs,test,__tests__}/**/*.ts\" --fix",
     "lint:ci": "eslint \"{src,apps,libs,test,__tests__}/**/*.ts\"",
-    "test": "tap test/*.spec.ts",
+    "test": "tap --passes test/*.spec.ts",
     "test:cov": "tap test/*.spec.ts --coverage-report=text-summary --coverage-report=lcovonly --allow-incomplete-coverage",
     "prepublishOnly": "npm run lint:ci && npm run test"
   },
@@ -67,11 +67,11 @@
   },
   "peerDependencies": {
     "@nestjs/common": "^10.2.7",
-    "ethers": "^6.8.0"
+    "ethers": "^6.15.0"
   },
   "tap": {
     "diag": true,
-    "bail": false,
+    "bail": true,
     "comments": true,
     "timeout": 40000
   }

package.json

@@ -5,11 +5,15 @@ import t from 'tap'
 import * as ABI from './utils/ABI.json'
 import { appRequest } from './utils/appRequest'
 import { ETHERS_ADDRESS, ETHERS_PRIVATE_KEY } from './utils/constants'
+import { nockAllRPCRequests } from './utils/mockResponses'
 import { platforms } from './utils/platforms'
 import { EthersContract, EthersModule, EthersSigner, InjectContractProvider, InjectSignerProvider } from '../src'
 
 t.test('EthersContract', (t) => {
-  t.beforeEach(() => nock.cleanAll())
+  t.beforeEach(() => {
+    nock.cleanAll()
+    nockAllRPCRequests()
+  })
 
   t.before(() => {
     if (!nock.isActive()) {
@@ -37,7 +41,7 @@ t.test('EthersContract', (t) => {
               async someMethod(): Promise<string> {
                 const contract: Contract = this.contract.create(ETHERS_ADDRESS, ABI)
 
-                if (!contract?.runner) {
+                if (!(await contract?.runner?.provider?.getNetwork())) {
                   throw new Error('No provider injected')
                 }
 
@@ -84,7 +88,7 @@ t.test('EthersContract', (t) => {
               const wallet = this.signer.createWallet(ETHERS_PRIVATE_KEY)
               const contract: Contract = this.contract.create(ETHERS_ADDRESS, ABI, wallet)
 
-              if (!contract?.runner) {
+              if (!(await contract?.runner?.provider?.getNetwork())) {
                 throw new Error('No provider injected')
               }
 
@@ -133,7 +137,7 @@ t.test('EthersContract', (t) => {
               async someMethod(): Promise<string> {
                 const contract: Contract = this.contract.create(ETHERS_ADDRESS, ABI)
 
-                if (!contract?.runner) {
+                if (!(await contract?.runner?.provider?.getNetwork())) {
                   throw new Error('No provider injected')
                 }
 
@@ -188,7 +192,7 @@ t.test('EthersContract', (t) => {
               const wallet = this.signer.createWallet(ETHERS_PRIVATE_KEY)
               const contract: Contract = this.contract.create(ETHERS_ADDRESS, ABI, wallet)
 
-              if (!contract?.runner) {
+              if (!(await contract?.runner?.provider?.getNetwork())) {
                 throw new Error('No provider injected')
               }
 

test/ethers.contract.spec.ts

@@ -3,14 +3,12 @@ import { NestFactory } from '@nestjs/core'
 import {
   AbstractProvider,
   AlchemyProvider,
-  encodeBase64,
   EtherscanProvider,
   FallbackProvider,
   FeeData,
   JsonRpcProvider,
   Network,
   PocketProvider,
-  toUtf8Bytes,
 } from 'ethers'
 import * as nock from 'nock'
 import t from 'tap'
@@ -40,7 +38,13 @@ import {
   POLYGON_TESTNET_GASSTATION_URL,
   TESTNET_BSCPOCKET_URL,
 } from './utils/constants'
-import { GAS_STATION_RESPONSE, generateMethodQuery, matchResponses, RPC_RESPONSES } from './utils/mockResponses'
+import {
+  GAS_STATION_RESPONSE,
+  generateMethodQuery,
+  matchResponses,
+  nockAllRPCRequests,
+  RPC_RESPONSES,
+} from './utils/mockResponses'
 import { platforms } from './utils/platforms'
 import {
   BINANCE_NETWORK,
@@ -73,6 +77,8 @@ t.test('Ethers Module Initialization', (t) => {
     t.test(PlatformAdapter.name, (t) => {
       t.test('forRoot', (t) => {
         t.test('should compile without options', async (t) => {
+          nockAllRPCRequests()
+
           @Controller('/')
           class TestController {
             constructor(
@@ -140,10 +146,7 @@ t.test('Ethers Module Initialization', (t) => {
           nock(GOERLI_POCKET_URL)
             .persist()
             .post(`/${GOERLI_POKT_API_KEY.applicationId}`)
-            .matchHeader(
-              'authorization',
-              'Basic ' + encodeBase64(toUtf8Bytes(`:${GOERLI_POKT_API_KEY.applicationSecretKey}`)),
-            )
+            .basicAuth({ user: '', pass: GOERLI_POKT_API_KEY.applicationSecretKey })
             .reply(200, matchResponses)
 
           @Controller('/')
@@ -287,10 +290,7 @@ t.test('Ethers Module Initialization', (t) => {
           nock(BSC_POCKET_URL)
             .persist()
             .post(`/${GOERLI_POKT_API_KEY.applicationId}`)
-            .matchHeader(
-              'authorization',
-              'Basic ' + encodeBase64(toUtf8Bytes(`:${GOERLI_POKT_API_KEY.applicationSecretKey}`)),
-            )
+            .basicAuth({ user: '', pass: GOERLI_POKT_API_KEY.applicationSecretKey })
             .reply(200, matchResponses)
 
           @Controller('/')
@@ -326,6 +326,7 @@ t.test('Ethers Module Initialization', (t) => {
         })
 
         t.test('should compile with network option as number', async (t) => {
+          nockAllRPCRequests()
           @Controller('/')
           class TestController {
             constructor(
@@ -356,6 +357,7 @@ t.test('Ethers Module Initialization', (t) => {
         })
 
         t.test('should compile with network option as string', async (t) => {
+          nockAllRPCRequests()
           @Controller('/')
           class TestController {
             constructor(
@@ -1110,6 +1112,8 @@ t.test('Ethers Module Initialization', (t) => {
         })
 
         t.test('should compile with network option as number', async (t) => {
+          nockAllRPCRequests()
+
           @Controller('/')
           class TestController {
             constructor(
@@ -1155,6 +1159,7 @@ t.test('Ethers Module Initialization', (t) => {
         })
 
         t.test('should compile with network option as string', async (t) => {
+          nockAllRPCRequests()
           @Controller('/')
           class TestController {
             constructor(