fix: Don not rely on possibly incorrect data TABLE_ROWS

For InnoDB tables the value of TABLE_ROWS may be wrong in some situations

Author: pl-github

src/Schema/Strategy/MysqlBasedSchemaStrategy.php

@@ -53,7 +53,7 @@ public function applySchema(SchemaBuilder $schemaBuilder, Connection $connection
     public function deleteData(Connection $connection): void
     {
         $tablesWithRows = $connection->executeQuery(
-            'SELECT `TABLE_NAME` FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_SCHEMA = :table AND `TABLE_ROWS` > 0',
+            'SELECT `TABLE_NAME` FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_SCHEMA = :table',
             ['table' => $connection->getDatabase()],
         )->fetchFirstColumn();
 

tests/Schema/Strategy/MysqlBasedSchemaStrategyTest.php

@@ -206,7 +206,7 @@ static function () use ($queryLog, $connection) {
                     $result = [];
 
                     // phpcs:ignore Generic.Files.LineLength.TooLong
-                    if ($query === 'SELECT `TABLE_NAME` FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_SCHEMA = :table AND `TABLE_ROWS` > 0') {
+                    if ($query === 'SELECT `TABLE_NAME` FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_SCHEMA = :table') {
                         $result = [['TABLE_NAME' => 'foo']];
                     }
 

tests/Schema/Strategy/__snapshots__/mysql_based_schema_strategy_delete_data.json

@@ -1,6 +1,6 @@
 [
     {
-        "query": "SELECT `TABLE_NAME` FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_SCHEMA = :table AND `TABLE_ROWS` > 0",
+        "query": "SELECT `TABLE_NAME` FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_SCHEMA = :table",
         "parameters": {
             "table": "database_name"
         },
@@ -19,4 +19,4 @@
     {
         "statement": "SET foreign_key_checks = 1"
     }
-]
+]