Skip to content

Commit 0974e0a

Browse files
committed
update assertions with patchy coverage
1 parent be45b49 commit 0974e0a

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

test/browser/features/resource-load-spans.feature

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,18 @@ Feature: Resource Load Spans
2525
And the trace payload field "resourceSpans.0.scopeSpans.0.spans.1" string attribute "http.url" matches the regex "^http:\/\/.*:[0-9]{4}\/favicon\.png\?height=100&width=100$"
2626
And the trace payload field "resourceSpans.0.scopeSpans.0.spans.1" string attribute "http.flavor" equals "1.1"
2727

28-
# Image status code and body size have very patchy browser coverage
29-
And if present, the trace payload field "resourceSpans.0.scopeSpans.0.spans.1" integer attribute "http.status_code" equals 200
30-
And if present, the trace payload field "resourceSpans.0.scopeSpans.0.spans.1" integer attribute "http.response_content_length" equals 2202
31-
And if present, the trace payload field "resourceSpans.0.scopeSpans.0.spans.1" integer attribute "http.response_content_length_uncompressed" equals 2202
28+
# Image status code and body size have patchy browser coverage
29+
And on Chrome versions >= 109:
30+
"""
31+
the trace payload field "resourceSpans.0.scopeSpans.0.spans.1" integer attribute "http.status_code" equals 200
32+
"""
33+
34+
# Actually Safari 16.4 but our test devices currently use 16.3, this can be dropped to 16 when the devices update
35+
And on Chrome versions >= 54, Android versions >= 54, Safari versions >= 17, iOS versions >= 17, Firefox versions >= 45, Edge versions >= 17:
36+
"""
37+
the trace payload field "resourceSpans.0.scopeSpans.0.spans.1" integer attribute "http.response_content_length" equals 2202
38+
the trace payload field "resourceSpans.0.scopeSpans.0.spans.1" integer attribute "http.response_content_length_uncompressed" equals 2202
39+
"""
3240

3341
@skip_on_npm_build
3442
@requires_resource_load_spans

0 commit comments

Comments
 (0)