Fixes reporting issues without priority to console (#1254)

Author: pascalberger

src/Cake.Issues.Reporting.Console.Tests/ConsoleIssueReportGeneratorTests.cs

@@ -192,6 +192,67 @@ public void Should_Not_Filter_Issues_With_Existing_File()
                 // Then
                 fixture.Log.Entries.ShouldContain(x => x.Message == "0 issue(s) were filtered because they either don't belong to a file or the file does not exist.");
             }
+
+            [Fact]
+            public void Should_Work_Without_Priority()
+            {
+                // Given
+                using var tempSourceFile = new TemporarySourceFile("Testfiles.TestFile.txt");
+                var filePath = tempSourceFile.FilePath;
+                output.WriteLine($"File path: {filePath}");
+                var directory = Path.GetDirectoryName(filePath)!;
+                var fileName = Path.GetFileName(filePath);
+                var fixture = new ConsoleIssueReportFixture
+                {
+                    ConsoleIssueReportFormatSettings =
+                    {
+                        ShowDiagnostics = true
+                    }
+                };
+                var issues =
+                    new List<IIssue>
+                    {
+                    IssueBuilder
+                        .NewIssue("Message Foo", "ProviderType Foo", "ProviderName Foo")
+                        .InFile(fileName, 1, 1)
+                        .Create(),
+                    };
+                // When
+                _ = fixture.CreateReport(issues, directory);
+
+                // Then
+            }
+
+            [Fact]
+            public void Should_Work_With_Priority()
+            {
+                // Given
+                using var tempSourceFile = new TemporarySourceFile("Testfiles.TestFile.txt");
+                var filePath = tempSourceFile.FilePath;
+                output.WriteLine($"File path: {filePath}");
+                var directory = Path.GetDirectoryName(filePath)!;
+                var fileName = Path.GetFileName(filePath);
+                var fixture = new ConsoleIssueReportFixture
+                {
+                    ConsoleIssueReportFormatSettings =
+                    {
+                        ShowDiagnostics = true
+                    }
+                };
+                var issues =
+                    new List<IIssue>
+                    {
+                    IssueBuilder
+                        .NewIssue("Message Foo", "ProviderType Foo", "ProviderName Foo")
+                        .InFile(fileName, 1, 1)
+                        .WithPriority(IssuePriority.Error)
+                        .Create(),
+                    };
+                // When
+                _ = fixture.CreateReport(issues, directory);
+
+                // Then
+            }
         }
     }
 }

src/Cake.Issues.Reporting.Console/IssueDiagnostic.cs

@@ -42,7 +42,7 @@ public IssueDiagnostic(IEnumerable<IIssue> issues)
                 (int)IssuePriority.Warning => Color.Yellow,
                 (int)IssuePriority.Suggestion => Color.Blue,
                 (int)IssuePriority.Hint => Color.LightSkyBlue1,
-                _ => throw new Exception(),
+                _ => this.Color,
             };
 
         var noteComponents = new List<string>();
@@ -108,7 +108,7 @@ private void CreateLabels()
             (int)IssuePriority.Error => Color.Red,
             (int)IssuePriority.Warning => Color.Yellow,
             (int)IssuePriority.Suggestion or (int)IssuePriority.Hint => Color.Blue,
-            _ => throw new Exception(),
+            _ => Color.White,
         };
 
         foreach (var issue in this.issues)