Fix "label column cannot start at the end of the line" error

Co-authored-by: pascalberger <[email protected]>

Author: Copilot

src/Cake.Issues.Reporting.Console.Tests/ConsoleIssueReportGeneratorTests.cs

@@ -102,5 +102,67 @@ public void Should_Generate_Report_With_No_Issues(
 
             // Then
         }
+
+        [Fact]
+        public void Should_Handle_Issue_At_End_Of_Line()
+        {
+            // Given
+            var fixture = new ConsoleIssueReportFixture
+            {
+                ConsoleIssueReportFormatSettings =
+                {
+                    ShowDiagnostics = true
+                }
+            };
+
+            // Create an issue at the end of a line (column equals line length)
+            var issues = new[]
+            {
+                IssueBuilder
+                    .NewIssue("SA1629", "StyleCop", "StyleCopAnalyzers")
+                    .InFile("src/MyProject/MyFile.cs", 20, 119) // Column 119 which matches the error scenario
+                    .OfRule("SA1629")
+                    .WithPriority(IssuePriority.Warning)
+                    .Create()
+            };
+
+            // When - This should not throw an exception
+            var exception = Record.Exception(() =>
+                fixture.CreateReport(issues, @"c:\Source\Cake.Issues.Reporting.Console"));
+
+            // Then
+            exception.ShouldBeNull();
+        }
+
+        [Fact]
+        public void Should_Handle_Issue_With_End_Column_At_End_Of_Line()
+        {
+            // Given
+            var fixture = new ConsoleIssueReportFixture
+            {
+                ConsoleIssueReportFormatSettings =
+                {
+                    ShowDiagnostics = true
+                }
+            };
+
+            // Create an issue with EndColumn at the end of a line
+            var issues = new[]
+            {
+                IssueBuilder
+                    .NewIssue("Test issue with end column at line end", "TestProvider", "TestProvider")
+                    .InFile("TestFile.cs", 10, null, 110, 119) // Line 10, Column 110-119 with EndColumn at end of line
+                    .OfRule("TestRule")
+                    .WithPriority(IssuePriority.Error)
+                    .Create()
+            };
+
+            // When - This should not throw an exception
+            var exception = Record.Exception(() =>
+                fixture.CreateReport(issues, @"c:\Source\Cake.Issues.Reporting.Console"));
+
+            // Then
+            exception.ShouldBeNull();
+        }
     }
 }

src/Cake.Issues.Reporting.Console.Tests/IssueDiagnosticTests.cs

@@ -91,5 +91,25 @@ public void Should_Not_Include_Project_When_Not_Available()
                 Assert.Fail("Note should not be null when rule URL is provided");
             }
         }
+
+        [Fact]
+        public void Should_Handle_Issue_At_End_Of_Line()
+        {
+            // Given
+            // Create an issue where the column is at the end of the line
+            // This scenario previously caused "label column cannot start at the end of the line" error
+            var issue = IssueBuilder
+                .NewIssue("Test message at end of line", "TestProvider", "TestProviderName")
+                .InFile("test.cs", 10, 119) // Column 119 which could be at end of line
+                .OfRule("TestRule")
+                .WithPriority(IssuePriority.Warning)
+                .Create();
+
+            // When
+            var exception = Record.Exception(() => new IssueDiagnostic(issue));
+
+            // Then
+            exception.ShouldBeNull();
+        }
     }
 }

src/Cake.Issues.Reporting.Console/IssueDiagnostic.cs

@@ -93,6 +93,12 @@ private static (Location Location, int Lenght) GetLocation(IIssue issue)
         if (issue.EndColumn.HasValue)
         {
             length = issue.EndColumn.Value - issue.Column.Value;
+
+            // Ensure length is not negative
+            if (length < 0)
+            {
+                length = 0;
+            }
         }
 
         return (location, length);
@@ -114,19 +120,36 @@ private void CreateLabels()
         foreach (var issue in this.issues)
         {
             var (location, length) = GetLocation(issue);
-            var label =
-                new Label(
-                    issue.AffectedFileRelativePath.FullPath,
-                    location,
-                    issue.Message(IssueCommentFormat.PlainText))
-                .WithColor(color);
 
-            if (length > 0)
+            try
             {
-                label = label.WithLength(length);
+                var label =
+                    new Label(
+                        issue.AffectedFileRelativePath.FullPath,
+                        location,
+                        issue.Message(IssueCommentFormat.PlainText))
+                    .WithColor(color);
+
+                if (length > 0)
+                {
+                    label = label.WithLength(length);
+                }
+
+                this.Labels.Add(label);
             }
+            catch (ArgumentException ex) when (ex.Message.Contains("label column cannot start at the end of the line"))
+            {
+                // If Errata throws an error because the column is at the end of the line,
+                // create a label at the beginning of the line instead so the issue is still reported
+                var fallbackLocation = new Location(issue.Line.Value, 1);
+                var labelWithFallbackLocation = new Label(
+                    issue.AffectedFileRelativePath.FullPath,
+                    fallbackLocation,
+                    issue.Message(IssueCommentFormat.PlainText))
+                    .WithColor(color);
 
-            this.Labels.Add(label);
+                this.Labels.Add(labelWithFallbackLocation);
+            }
         }
     }
 }