Skip to content

Updated adapter to use latest stable version of Casbin.NET (2.16.0) a… #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Updated adapter to use latest stable version of Casbin.NET (2.16.0) a… #82

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f6dc05
Updated adapter to use latest stable version of Casbin.NET (2.16.0) a…
stewartmcguire Oct 3, 2025
21108f2
Removed commented out line.
stewartmcguire Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Casbin.Persist.Adapter.EFCore.UnitTest/SpecialPolicyTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using Casbin.Persist.Adapter.EFCore.Entities;
using Casbin.Persist.Adapter.EFCore.UnitTest.Fixtures;
using Xunit;
using System;

namespace Casbin.Persist.Adapter.EFCore.UnitTest
{
Expand Down Expand Up @@ -40,7 +41,9 @@ public void TestCommaPolicy()
m = eval(p.rule)
"""
), adapter);
enforcer.AddFunction("equal", (a1, a2) => a1 == a2);

enforcer.AddFunction<Func<object, object, bool>>("equal", (a1, a2) => a1 == a2);
// enforcer.AddFunction("equal", (a1, a2) => a1 == a2);

enforcer.AddPolicy("equal(p.a1, p.a2)", "a1", "a1");
Assert.True(enforcer.Enforce("_"));
Expand Down
2 changes: 1 addition & 1 deletion Casbin.Persist.Adapter.EFCore/Casbin.Persist.Adapter.EFCore.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Casbin.NET" Version="2.7.0" />
<PackageReference Include="Casbin.NET" Version="2.16.0" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net9.0'">
Expand Down
2 changes: 2 additions & 0 deletions Casbin.Persist.Adapter.EFCore/DefaultPersistPolicyEntityTypeConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ public virtual void Configure(EntityTypeBuilder<EFCorePersistPolicy<TKey>> build
builder.Ignore(p => p.Value10);
builder.Ignore(p => p.Value11);
builder.Ignore(p => p.Value12);
builder.Ignore(p => p.Value13);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These properties need be added to PersistPolicy and IPersistPolicy at Casbin.NET

Copy link
Author

@stewartmcguire stewartmcguire Oct 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They already exist in the 2.16.0 release of Casbin.NET which I indicated I updated the Casbin.NET library reference to.

builder.Ignore(p => p.Value14);

builder.HasIndex(p => p.Type);
builder.HasIndex(p => p.Value1);
Expand Down
Loading