Replies: 1 comment
-
|
Your welcome to submit a PR. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
CefCertificateCallbackWrapper.h compares the serialNumbers of the certificates to determine the selected one.
CefSharp/CefSharp.Core.Runtime/Internals/CefCertificateCallbackWrapper.h
Line 86 in 24b1a89
This seems problematic because although the CA should set a unique serial number for each certificate, there is no guarantee that they are.
I wanted to select a specific certificate by implementing
OnSelectClientCertificatebut because multiple certificates have the same serial number, it always selects the first one in the list.In my opinion it would be better to compare the certificate thumbprints. If it's ok, I will create a PR to change this behaviour.
Beta Was this translation helpful? Give feedback.
All reactions