edit: modules ceph_crush_rule and ceph_crush_rule_info #19
Conversation
|
@castorsky Hi! I need to fix the CI before going any further. I didn't notice the Actions were failing for quite some time. BTW all commits have to be signed-off. Could you do it to all your PR? Thx |
@asm0deuz Hi! I'll definitely sign my commits within a week or so. |
castorsky
force-pushed
the
edit_ceph_crush_rule_module
branch
from
d1f2878 to
d656026
Compare
|
Hi, @asm0deuz! I have signed off all my pull requests. |
|
@castorsky sorry to bother you again but I finally fixed the CI, would you mind pushing all your PR once more. Thx |
castorsky
force-pushed
the
edit_ceph_crush_rule_module
branch
from
d656026 to
c5d9375
Compare
Hi! No problem, pushed all PRs again. Will fix failed tests. |
|
Regarding changelog issue please create a new yml file in /changelogs/fragments following the documentation with the correct section depending on the PR content? We are using the same github actions as the Ansible project does which can be quite annoying |
|
That's totally fine. It will took about two weeks (I have no time right now, will be able to fix after Oct/10) |
Modules refactored to use `cephadm shell` command. Module ceph_crush_rule_common.py dropped as redundant. Functionality for updating CRUSH rules was added to the ceph_crush_rule module. Signed-off-by: Castor Sky <[email protected]>
Signed-off-by: Castor Sky <[email protected]>
castorsky
force-pushed
the
edit_ceph_crush_rule_module
branch
from
c5d9375 to
77e64c8
Compare
2 participants
Modules refactored to use
cephadm shellcommand.Module
ceph_crush_rule_common.pydropped as redundant.Functionality for updating CRUSH rules was added to the
ceph_crush_rulemodule.