pycriu `check` always errors

[herheliuk]

Trying to use pycriu:

sudo criu service &

from pycriu import criu as pycriu_criu

criu = pycriu_criu()

criu.use_sk('criu_service.socket')

criu.check()

But I get the following error:

pycriu.criu.CRIUExceptionExternal: CHECK failed: Error(0): Unknown

Output from criu service:

(13.259281) Connected.
(13.259432) Waiting for connection...
(13.259533) CRIU run id = 7ae68e84-7a16-4271-bb4b-fe017c9ff8e1
(13.313752) Worker(pid 1791) exited with 0

I tested this on an Ubuntu Server virtual machines for both x86_64 and aarch64.

[adrianreber]

As a reference look at https://github.com/checkpoint-restore/criu/tree/criu-dev/test/others/rpc

There it is used during test runs. Maybe that helps.

[herheliuk]

I've made a fix! here's the output now:

google.protobuf.message.EncodeError: Message criu_req is missing required fields: opts.images_dir_fd

pycriu.criu.CRIUExceptionInternal: CHECK failed with internal error: Message criu_req is missing required fields: opts.images_dir_fd

[herheliuk]

Created a pull request! #2759

[herheliuk]

New Python code:

#!/usr/bin/env python3

from pycriu import criu as pycriu_criu
from os import (
    open as os_open,
    close as os_close,
    O_DIRECTORY as os_O_DIRECTORY
)
from contextlib import contextmanager
from pathlib import Path

_service_socket = './criu_service.socket'

@contextmanager
def open_directory_fd(dir_path: str):
    file_descriptor = os_open(dir_path, os_O_DIRECTORY)
    try:
        yield file_descriptor
    finally:
        os_close(file_descriptor)

criu = pycriu_criu()
criu.use_sk(_service_socket)

current_directory = Path.cwd()

with open_directory_fd(current_directory) as fd:
    criu.opts.images_dir_fd = fd
    criu.check()

[avagin]

pycriu.criu.CRIUExceptionInternal: CHECK failed with internal error: Message criu_req is missing required fields: opts.images_dir_fd

images_dir_fd is -1 by default, do I miss something?

criu/images/rpc.proto

Line 64 in d25d829

required int32 images_dir_fd = 1 [default = -1];