Skip to content

Commit 4f2c3ef

Browse files
committed
Remove unused helper fn and fix black formatting
1 parent 65ba4a9 commit 4f2c3ef

File tree

5 files changed

+19
-277
lines changed

5 files changed

+19
-277
lines changed

src/registrar/services/cloudflare_service.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,7 @@ def create_dns_record(self, zone_id, record_data):
7373
def get_page_accounts(self, page, per_page):
7474
"""Gets all accounts under specified tenant. Must include pagination paramenters"""
7575
appended_url = f"/tenants/{self.tenant_id}/accounts"
76-
params={
77-
"page": page,
78-
"per_page": per_page
79-
}
76+
params = {"page": page, "per_page": per_page}
8077
try:
8178
logger.info(f"Getting all tenant accounts on page {page}")
8279
resp = self.client.get(appended_url, params=params)

src/registrar/tests/services/test_cloudflare_service.py

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ def setUp(self):
1414
mock_client.post = Mock()
1515
mock_client.get = Mock()
1616
self.service = CloudflareService(client=mock_client)
17-
1817

1918
# @patch("registrar.services.cloudflare_service.CloudflareService.client.post")
2019
def test_create_account_success(self):
@@ -25,7 +24,7 @@ def test_create_account_success(self):
2524
mock_response.status_code = 200
2625
mock_response.raise_for_status.return_value = None
2726
self.service.client.post.return_value = mock_response
28-
27+
2928
resp = self.service.create_account(account_name)
3029
self.assertEqual(resp["result"]["name"], account_name)
3130

@@ -95,14 +94,14 @@ def test_create_dns_record_success(self):
9594
mock_response.status_code = 200
9695
mock_response.raise_for_status.return_value = None
9796
mock_response.json.return_value = {
98-
"result": {
99-
"content": "198.51.100.4",
100-
"name": "democracy.gov",
101-
"proxied": False,
102-
"type": "A",
103-
"comment": "Test domain name",
104-
"ttl": 3600,
105-
}
97+
"result": {
98+
"content": "198.51.100.4",
99+
"name": "democracy.gov",
100+
"proxied": False,
101+
"type": "A",
102+
"comment": "Test domain name",
103+
"ttl": 3600,
104+
}
106105
}
107106

108107
self.service.client.post.return_value = mock_response
@@ -133,7 +132,9 @@ def test_create_dns_record_failure(self):
133132
}
134133
mock_response = Mock()
135134
mock_response.status_code = 400
136-
http_error = HTTPStatusError(request="something", response="400 Server Error", message="Error creating DNS record")
135+
http_error = HTTPStatusError(
136+
request="something", response="400 Server Error", message="Error creating DNS record"
137+
)
137138
http_error.response = mock_response
138139
self.service.client.post.return_value = mock_response
139140
mock_response.raise_for_status.side_effect = http_error
@@ -175,7 +176,9 @@ def test_get_page_accounts_failure(self):
175176

176177
mock_response = Mock()
177178
mock_response.status_code = 400
178-
http_error = HTTPStatusError(request="something", response="400 Server Error", message="Error fetching accounts")
179+
http_error = HTTPStatusError(
180+
request="something", response="400 Server Error", message="Error fetching accounts"
181+
)
179182
http_error.response = mock_response
180183
self.service.client.get.return_value = mock_response
181184
mock_response.raise_for_status.side_effect = http_error
@@ -251,7 +254,9 @@ def test_get_dns_record_failure(self):
251254

252255
mock_response = Mock()
253256
mock_response.status_code = 400
254-
http_error = HTTPStatusError(request="something", response="400 Server Error", message="Error fetching dns record")
257+
http_error = HTTPStatusError(
258+
request="something", response="400 Server Error", message="Error fetching dns record"
259+
)
255260
http_error.response = mock_response
256261
self.service.client.get.return_value = mock_response
257262
mock_response.raise_for_status.side_effect = http_error

src/registrar/tests/test_api_helpers.py

Lines changed: 0 additions & 150 deletions
This file was deleted.

src/registrar/utility/api_helpers.py

Lines changed: 0 additions & 109 deletions
This file was deleted.

src/registrar/views/domain.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -713,7 +713,6 @@ class PrototypeDomainDNSRecordView(DomainFormBaseView):
713713
template_name = "prototype_domain_dns.html"
714714
form_class = PrototypeDomainDNSRecordForm
715715
valid_domains = ["igorville.gov", "domainops.gov", "dns.gov", "chance-especially.gov", "coach-whether-allow.gov"]
716-
717716

718717
def __init__(self):
719718
self.dns_record = None

0 commit comments

Comments
 (0)