Fix #97: Better error handling on spotify not installed

- Use method from ios sdk to check if spotify is installed
- update for better error message
- cleanup commented code

Author: cjam

ios/RNSpotifyRemoteAppRemote.m

@@ -150,12 +150,12 @@ - (void)appRemote:(nonnull SPTAppRemote *)appRemote didDisconnectWithError:(null
 }
 
 - (void)appRemote:(nonnull SPTAppRemote *)appRemote didFailConnectionAttemptWithError:(nullable NSError *)error {
-        // Check if spotify is installed
-        if(![RCTSharedApplication() canOpenURL:[NSURL URLWithString:@"spotify://https://open.spotify.com/track/2FhN2KhUvT91Q3Er4v9Qpd?si=6TZmH5MTRpqozJmvRUD_4Q"]] ){
-             [RNSpotifyRemotePromise rejectCompletions:_appRemoteCallbacks error:[RNSpotifyRemoteError errorWithCodeObj:RNSpotifyRemoteErrorCode.SpotifyNotInstalled ]];
-        }else{
+    // Check if spotify is installed
+    if(![RNSpotifyRemoteAuth.sharedInstance isSpotifyInstalled]){
+        [RNSpotifyRemotePromise rejectCompletions:_appRemoteCallbacks error:[RNSpotifyRemoteError errorWithCodeObj:RNSpotifyRemoteErrorCode.SpotifyNotInstalled ]];
+    }else{
             [RNSpotifyRemotePromise rejectCompletions:_appRemoteCallbacks error:[RNSpotifyRemoteError errorWithNSError:error]];
-        };
+    };
 }
 
 - (void)appRemoteDidEstablishConnection:(nonnull SPTAppRemote *)connectedRemote {

ios/RNSpotifyRemoteAuth.h

@@ -16,7 +16,7 @@
 -(void)authorize:(NSDictionary*)options resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject;
 -(void)endSession:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject;
 -(void)getSession:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject;
-
+-(BOOL)isSpotifyInstalled;
 
 -(SPTConfiguration*) configuration;
 -(NSString*) accessToken;

ios/RNSpotifyRemoteAuth.m

@@ -71,6 +71,10 @@ -(id)init
     return sharedInstance;
 }
 
+-(BOOL)isSpotifyInstalled{
+    return _sessionManager != nil && _sessionManager.spotifyAppInstalled;
+}
+
 #pragma mark URL handling
 
 - (BOOL)application:(UIApplication *)application openURL:(NSURL *)URL options:(NSDictionary<UIApplicationOpenURLOptionsKey, id> *)options

ios/RNSpotifyRemoteConvert.h

@@ -1,8 +1,5 @@
 
 #import <Foundation/Foundation.h>
-//#import <SpotifyAuthentication/SpotifyAuthentication.h>
-//#import <SpotifyMetadata/SpotifyMetadata.h>
-//#import <SpotifyAudioPlayback/SpotifyAudioPlayback.h>
 #import <SpotifyiOS.h>
 #import "RNSpotifyRemoteError.h"
 

ios/RNSpotifyRemoteError.m

@@ -39,7 +39,7 @@ +(RNSpotifyRemoteErrorCode*)errorName { \
 DEFINE_SPOTIFY_ERROR_CODE(SessionClosed, @"Session has been closed")
 DEFINE_SPOTIFY_ERROR_CODE(AppRemoteDisconnected, @"App Remote is not connected")
 DEFINE_SPOTIFY_ERROR_CODE(UnknownResponse, @"Spotify returned an unknown response")
-DEFINE_SPOTIFY_ERROR_CODE(SpotifyNotInstalled, @"Spotify does not appear to be installed")
+DEFINE_SPOTIFY_ERROR_CODE(SpotifyNotInstalled, @"Spotify does not appear to be installed. Note: You must whitelist the 'spotify' URL scheme in your info.plist.")
 
 #undef DEFINE_SPOTIFY_ERROR_CODE