Skip to content

Commit f038050

Browse files
committed
Change DefaultUserCreateMixin -> DefaultCreatedByMixin
1 parent 22e551b commit f038050

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ class LineItemUpdateSerializer(serializers.ModelSerializer):
6969
7070
7171
72-
#### `DefaultUserCreateMixin` for `ModelSerializers`
72+
#### `DefaultCreatedByMixin` for `ModelSerializers`
7373
7474
This will automatically set `YourModel.created_by` to `request.user`. To override which
7575
attribute the user is written to, add a `user_field` to your classes Meta information
@@ -79,7 +79,7 @@ class YourModel(models.Model):
7979
created_by = models.ForeignKey(User, on_delete=models.CASCADE)
8080
8181
82-
class MySerializer(DefaultUserCreateMixin, ModelSerializer):
82+
class MySerializer(DefaultCreatedByMixin, ModelSerializer):
8383
class Meta:
8484
model = YourModel
8585
```

ckc/serializers.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
class DefaultUserCreateMixin:
1+
class DefaultCreatedByMixin:
22
"""This will automatically set `YourModel.created_by` to `request.user`. To override which
33
attribute the user is written to, add a `user_field` to your classes Meta information
44
Example:
55
class YourModel(models.Model):
66
owner = models.ForeignKey(User, on_delete=models.CASCADE)
77
8-
class MySerializer(DefaultUserCreateMixin, ModelSerializer):
8+
class MySerializer(DefaultCreatedByMixin, ModelSerializer):
99
class Meta:
1010
model = YourModel
1111
# YourModel.owner = a foreign key to request.user which differs from the
@@ -17,7 +17,7 @@ def create(self, validated_data):
1717
user_field = getattr(self.Meta, 'user_field', 'created_by')
1818

1919
assert hasattr(self.Meta.model, user_field), f"{self.Meta.model} needs to have field {user_field} so " \
20-
f"DefaultUserCreateMixin can write to it"
20+
f"DefaultCreatedByMixin can write to it"
2121

2222
if user_field not in validated_data:
2323
if 'request' not in self.context:

testproject/testapp/serializers.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
from rest_framework.serializers import ModelSerializer
22

33
from ckc.fields import PrimaryKeyWriteSerializerReadField
4-
from ckc.serializers import DefaultUserCreateMixin
4+
from ckc.serializers import DefaultCreatedByMixin
55
from testapp.models import ModelWithACreator, ModelWithADifferentNamedCreator, AModel, BModel
66

77

8-
class TestModelWithACreatorSerializer(DefaultUserCreateMixin, ModelSerializer):
8+
class TestModelWithACreatorSerializer(DefaultCreatedByMixin, ModelSerializer):
99
class Meta:
1010
model = ModelWithACreator
1111
fields = []
1212

1313

14-
class TestModelWithADifferentNamedCreatorSerializer(DefaultUserCreateMixin, ModelSerializer):
14+
class TestModelWithADifferentNamedCreatorSerializer(DefaultCreatedByMixin, ModelSerializer):
1515
class Meta:
1616
model = ModelWithADifferentNamedCreator
1717
fields = []

tests/integration/test_default_user_create_mixin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
User = get_user_model()
88

99

10-
class TestDefaultUserCreateMixin(APITestCase):
10+
class TestDefaultCreatedByMixin(APITestCase):
1111

1212
def setUp(self):
1313
self.user = User.objects.create_user(username="test", password="test")

tests/integration/test_primary_key_write_serializer_read_field.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
User = get_user_model()
88

99

10-
class TestDefaultUserCreateMixin(APITestCase):
10+
class TestDefaultCreatedByMixin(APITestCase):
1111
TEST_TITLE_1 = 'test_title_1'
1212
TEST_TITLE_2 = 'test_title_2'
1313

0 commit comments

Comments
 (0)