Skip to content

Commit 3040915

Browse files
authored
Update integration-testing.yml
1 parent 49f07ed commit 3040915

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

.github/workflows/integration-testing.yml

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,30 +27,28 @@ jobs:
2727
with:
2828
repository: googleapis/python-bigquery-magics
2929
path: python-bigquery-magics
30-
30+
3131
- name: Install and test
3232
run: |
3333
set -e
3434
python -m venv venv
3535
. venv/bin/activate
3636
pip install pytest
3737
38-
# Step 1: Explicitly install the spanner-graph-notebook wheel from the 'dist' directory.
39-
# This is the most direct way to ensure the local version from your PR is used.
40-
pip install dist/*.whl
38+
# Install spanner-graph-notebook in "editable" mode from its source directory.
39+
# This makes the source code directly importable by other packages in the same
40+
# environment, which is the standard way to handle local dependencies in CI.
41+
# This will also install all of its dependencies like 'portpicker'.
42+
pip install -e .
4143

42-
# Step 2: Install python-bigquery-magics from its local directory.
43-
# We DO NOT use the [spanner-graph-notebook] extra because the dependency has already
44-
# been satisfied in the previous step.
44+
# Now, install python-bigquery-magics. Since spanner-graph-notebook is already
45+
# available in the environment, pip will not try to download it again.
4546
pip install ./python-bigquery-magics
4647

47-
# Clean up the source directory to prevent potential import path conflicts during testing.
48-
rm -rf spanner_graphs
49-
5048
pip install google-cloud-testutils
5149

5250
# Change directory into the bigquery-magics checkout to run its tests.
5351
cd python-bigquery-magics
5452

55-
# Run the tests. They should now find the correct spanner-graph-notebook package.
53+
# Run the tests. They should now be able to import spanner_graphs correctly.
5654
pytest -v tests/unit/test_graph_server.py tests/unit/bigquery/test_bigquery.py

0 commit comments

Comments
 (0)