Assorted fixes post HGCAL test beam #49148

pfs · 2025-10-13T15:37:11Z

PR description:

Post HGCAL test beam we have tested more extensively some parts of the code using the orbit accumulated data. This PR patches different pieces of the existing code on the following aspects

Module locator
- there was a confusion between the module type index (typically 0-54) and module count (typically 1-500 within a FED). We have introduced an explicit method to decouple the two and start using explicitly module count
- enabled unit tests for module locator which were otherwise ran by hand locally
Data formats
- missing the generation of dictionaries for new TPG SoAs, added in this PR
- add estimated rec hit noise level (from pedestal runs)
Unpacker
- missing decompression of 10b to 12b measurement of time-over-threshold energy measurement
ESProducer
- use FileInPath starting at cfg level
RecHit calibration kernels
- introduce cut as multiple of noise instead of absolute energy
- corrected application of local e.m. and dE/dx corrections
"Workflow 77" configuration update
- propagate usage of FileInPath and use selection of hits >5σ

PR validation:

Tested with test beam data and workflow 77 in 16_0_0_pre1 with:

runTheMatrix.py -w standard --ibeos -l 77

FYI @Lourda @cramonal @yulunmiao @IzaakWN @stahlleiton

cmsbuild · 2025-10-13T15:37:42Z

cms-bot internal usage

pfs · 2025-10-13T15:38:14Z

assign hgcal-dpg

cmsbuild · 2025-10-13T15:39:08Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49148/46436

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49148/46436/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49148/46436/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2025-10-14T06:57:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49148/46442

cmsbuild · 2025-10-14T06:57:41Z

New categories assigned: hgcal-dpg

@cseez,@felicepantaleo,@pfs,@rovere you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild · 2025-10-14T06:57:43Z

A new Pull Request was created by @pfs for master.

It involves the following packages:

CondFormats/HGCalObjects (alca, db)
DataFormats/HGCalDigi (simulation)
EventFilter/HGCalRawToDigi (reconstruction)
Geometry/HGCalMapping (geometry)
RecoLocalCalo/Configuration (reconstruction)
RecoLocalCalo/HGCalRecAlgos (reconstruction)

@Dr15Jones, @arunhep, @atpathak, @bsunanda, @civanch, @cmsbuild, @cseez, @felicepantaleo, @francescobrivio, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @perrotta, @pfs, @rovere can you please review it and eventually sign? Thanks.
@IzaakWN, @JanChyczynski, @Martin-Grunewald, @PonIlya, @ReyerBand, @apsallid, @argiro, @bsunanda, @cseez, @denizsun, @edjtscott, @fabiocos, @felicepantaleo, @hatakeyamak, @lgray, @martinamalberti, @missirol, @mmusich, @rchatter, @rovere, @rsreds, @salimcerci, @sameasy, @seemasharmafnal, @sethzenz, @thomreis, @tocheng, @vandreev11, @wang0jin, @youyingli, @yuanchao this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

pfs · 2025-10-14T07:06:33Z

test parameters:

enable = gpu
workflow = 77.0
workflow_gpu = 77.0
workflow_options_gpu = -w standard,gpu

pfs · 2025-10-14T07:06:53Z

please test

cmsbuild · 2025-10-14T09:23:02Z

-1

Failed Tests: UnitTests RelVals RelVals-AMD_MI300X RelVals-AMD_W7900 RelVals-NVIDIA_H100 RelVals-NVIDIA_L40S RelVals-NVIDIA_T4
Size: This PR adds an extra 72KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6f1b9/48654/summary.html
COMMIT: 6e07df5
CMSSW: CMSSW_16_0_X_2025-10-13-2300/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49148/48654/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test testMappingModIndexer_10degCassette had ERRORS
---> test testMappingModIndexer_TB2024 had ERRORS

RelVals

77.0

----- Begin Fatal Exception 14-Oct-2025 10:01:31 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step1_NONE.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
Path /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/77.0_HGCal_TestBeam/local_daq/ramdisk/run20000000/config_feds_v1.json is not in the local release area /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49148/48654/CMSSW_16_0_X_2025-10-13-2300


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02911/el8_amd64_gcc13/cms/cmssw/CMSSW_16_0_X_2025-10-13-1600/src/FWCore/ParameterSet/python/Types.py(1050): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02911/el8_amd64_gcc13/cms/cmssw/CMSSW_16_0_X_2025-10-13-1600/src/FWCore/ParameterSet/python/Mixins.py(398): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02911/el8_amd64_gcc13/cms/cmssw/CMSSW_16_0_X_2025-10-13-1600/src/FWCore/ParameterSet/python/Mixins.py(533): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02911/el8_amd64_gcc13/cms/cmssw/CMSSW_16_0_X_2025-10-13-1600/src/FWCore/ParameterSet/python/Config.py(1120): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02911/el8_amd64_gcc13/cms/cmssw/CMSSW_16_0_X_2025-10-13-1600/src/FWCore/ParameterSet/python/Config.py(1346): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

RelVals-AMD_MI300X

77.077.0_HGCal_TestBeam/step1_HGCal_TestBeam.log

RelVals-AMD_W7900

77.077.0_HGCal_TestBeam/step1_HGCal_TestBeam.log

RelVals-NVIDIA_H100

77.077.0_HGCal_TestBeam/step1_HGCal_TestBeam.log

RelVals-NVIDIA_L40S

77.077.0_HGCal_TestBeam/step1_HGCal_TestBeam.log

RelVals-NVIDIA_T4

77.077.0_HGCal_TestBeam/step1_HGCal_TestBeam.log

fwyzard · 2025-10-30T11:21:12Z

The T4 machines seems to be fine, and we haven't see failures in other workflows (recently).

pfs · 2025-10-30T13:09:29Z

ok thanks. What I meant is that the failure is not specifically bound to this PR. It is a failure in a workflow which doesn't use this code, in the DIGI step

perrotta · 2025-10-30T13:40:22Z

+alca

fwyzard · 2025-10-30T14:06:51Z

I see - ok, let me rerun the test just on the T4

fwyzard · 2025-10-30T14:07:18Z

test parameters:

enable = gpu
gpu = nvidia_t4
workflow = 77.0
workflow_gpu = 77.0
workflow_options_gpu = -w standard,gpu

fwyzard · 2025-10-30T14:07:56Z

please test

fwyzard · 2025-10-30T14:08:26Z

For comparison, #49267 is also running the tests on the T4, without any changes to the current IB.

fwyzard · 2025-10-30T18:09:45Z

OK, the T4 failure is independent, it shows up also without these changes (see #49267).

fwyzard · 2025-10-30T18:09:49Z

+heterogeneous

cmsbuild · 2025-10-30T20:35:06Z

-1

Failed Tests: RelVals RelVals-NVIDIA_T4
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6f1b9/49104/summary.html
COMMIT: 37810b5
CMSSW: CMSSW_16_0_X_2025-10-30-1100/el8_amd64_gcc13
Additional Tests: GPU,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49148/49104/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

77.0

----- Begin Fatal Exception 30-Oct-2025 16:03:17 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step1_NONE.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoLocalCalo/HGCalRecProducers/data/testbeam/config_feds_v1.json anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49148/49104/CMSSW_16_0_X_2025-10-30-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49148/49104/CMSSW_16_0_X_2025-10-30-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49148/49104/CMSSW_16_0_X_2025-10-30-1100/external/el8_amd64_gcc13/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02913/el8_amd64_gcc13/cms/cmssw-patch/CMSSW_16_0_X_2025-10-30-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02913/el8_amd64_gcc13/cms/cmssw-patch/CMSSW_16_0_X_2025-10-30-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02913/el8_amd64_gcc13/cms/cmssw-patch/CMSSW_16_0_X_2025-10-30-1100/external/el8_amd64_gcc13/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/77.0_HGCal_TestBeam


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02913/el8_amd64_gcc13/cms/cmssw/CMSSW_16_0_X_2025-10-29-1100/src/FWCore/ParameterSet/python/Types.py(1050): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02913/el8_amd64_gcc13/cms/cmssw/CMSSW_16_0_X_2025-10-29-1100/src/FWCore/ParameterSet/python/Mixins.py(398): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02913/el8_amd64_gcc13/cms/cmssw/CMSSW_16_0_X_2025-10-29-1100/src/FWCore/ParameterSet/python/Mixins.py(533): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02913/el8_amd64_gcc13/cms/cmssw/CMSSW_16_0_X_2025-10-29-1100/src/FWCore/ParameterSet/python/Config.py(1120): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02913/el8_amd64_gcc13/cms/cmssw/CMSSW_16_0_X_2025-10-29-1100/src/FWCore/ParameterSet/python/Config.py(1346): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

RelVals-NVIDIA_T4

29834.70429834.704_TTbar_14TeV+Run4D110PU_lstOnGPUIters01TrackingOnly/step2_TTbar_14TeV+Run4D110PU_lstOnGPUIters01TrackingOnly.log
77.077.0_HGCal_TestBeam/step1_HGCal_TestBeam.log

perrotta · 2025-10-31T09:36:02Z

+db

pfs · 2025-10-31T10:12:16Z

+1

jfernan2 · 2025-10-31T11:05:21Z

+1

cmsbuild added this to the CMSSW_16_0_X milestone Oct 13, 2025

cmsbuild added reconstruction-pending simulation-pending alca-pending db-pending geometry-pending pending-signatures tests-pending orp-pending code-checks-pending changes-dataformats labels Oct 13, 2025

cmsbuild added the hgcal-dpg-pending label Oct 13, 2025

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Oct 13, 2025

pfs force-pushed the dev/fix_modmix branch from a00c2a4 to 6e07df5 Compare October 14, 2025 06:55

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 14, 2025

cmsbuild added tests-started and removed tests-pending labels Oct 14, 2025

cmsbuild added tests-rejected and removed tests-started labels Oct 30, 2025

cmsbuild added alca-approved and removed alca-pending labels Oct 30, 2025

cmsbuild removed the requires-external label Oct 30, 2025

cmsbuild added tests-started and removed tests-rejected labels Oct 30, 2025

cmsbuild added heterogeneous-approved and removed heterogeneous-pending labels Oct 30, 2025

cmsbuild added tests-rejected and removed tests-started labels Oct 30, 2025

cmsbuild added db-approved and removed db-pending labels Oct 31, 2025

cmsbuild added hgcal-dpg-approved and removed hgcal-dpg-pending labels Oct 31, 2025

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Oct 31, 2025

Assorted fixes post HGCAL test beam #49148

Are you sure you want to change the base?

Assorted fixes post HGCAL test beam #49148

Uh oh!

Conversation

pfs commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pfs commented Oct 13, 2025

Uh oh!

cmsbuild commented Oct 13, 2025

Uh oh!

cmsbuild commented Oct 14, 2025

Uh oh!

cmsbuild commented Oct 14, 2025

Uh oh!

cmsbuild commented Oct 14, 2025

Uh oh!

pfs commented Oct 14, 2025

Uh oh!

pfs commented Oct 14, 2025

Uh oh!

cmsbuild commented Oct 14, 2025

Unit Tests

RelVals

RelVals-AMD_MI300X

RelVals-AMD_W7900

RelVals-NVIDIA_H100

RelVals-NVIDIA_L40S

RelVals-NVIDIA_T4

Uh oh!

fwyzard commented Oct 30, 2025

Uh oh!

pfs commented Oct 30, 2025

Uh oh!

perrotta commented Oct 30, 2025

Uh oh!

fwyzard commented Oct 30, 2025

Uh oh!

fwyzard commented Oct 30, 2025

Uh oh!

fwyzard commented Oct 30, 2025

Uh oh!

fwyzard commented Oct 30, 2025

Uh oh!

fwyzard commented Oct 30, 2025

Uh oh!

fwyzard commented Oct 30, 2025

Uh oh!

cmsbuild commented Oct 30, 2025

RelVals

RelVals-NVIDIA_T4

Uh oh!

perrotta commented Oct 31, 2025

Uh oh!

pfs commented Oct 31, 2025

Uh oh!

jfernan2 commented Oct 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pfs commented Oct 13, 2025 •

edited

Loading

cmsbuild commented Oct 13, 2025 •

edited

Loading