Skip to content

Commit 4b18f7f

Browse files
committed
Less explicit panics
1 parent fe94db2 commit 4b18f7f

File tree

1 file changed

+6
-18
lines changed

1 file changed

+6
-18
lines changed

parquet-variant/src/to_json.rs

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -980,9 +980,7 @@ mod tests {
980980
// Parse the JSON to verify structure - handle JSON parsing errors manually
981981
let parsed: Value = serde_json::from_str(&json)
982982
.map_err(|e| ArrowError::ParseError(format!("JSON parse error: {}", e)))?;
983-
let Value::Object(obj) = parsed else {
984-
panic!("Expected JSON object");
985-
};
983+
let obj = parsed.as_object().expect("expected JSON object");
986984
assert_eq!(obj.get("name"), Some(&Value::String("Alice".to_string())));
987985
assert_eq!(obj.get("age"), Some(&Value::Number(30.into())));
988986
assert_eq!(obj.get("active"), Some(&Value::Bool(true)));
@@ -1071,9 +1069,7 @@ mod tests {
10711069
assert_eq!(json, "[1,2,3,4,5]");
10721070

10731071
let json_value = variant_to_json_value(&variant)?;
1074-
let Value::Array(arr) = json_value else {
1075-
panic!("Expected JSON array");
1076-
};
1072+
let arr = json_value.as_array().expect("expected JSON array");
10771073
assert_eq!(arr.len(), 5);
10781074
assert_eq!(arr[0], Value::Number(1.into()));
10791075
assert_eq!(arr[4], Value::Number(5.into()));
@@ -1125,9 +1121,7 @@ mod tests {
11251121

11261122
let parsed: Value = serde_json::from_str(&json)
11271123
.map_err(|e| ArrowError::ParseError(format!("JSON parse error: {}", e)))?;
1128-
let Value::Array(arr) = parsed else {
1129-
panic!("Expected JSON array");
1130-
};
1124+
let arr = parsed.as_array().expect("expected JSON array");
11311125
assert_eq!(arr.len(), 5);
11321126
assert_eq!(arr[0], Value::String("hello".to_string()));
11331127
assert_eq!(arr[1], Value::Number(42.into()));
@@ -1160,9 +1154,7 @@ mod tests {
11601154
// Parse and verify all fields are present
11611155
let parsed: Value = serde_json::from_str(&json)
11621156
.map_err(|e| ArrowError::ParseError(format!("JSON parse error: {}", e)))?;
1163-
let Value::Object(obj) = parsed else {
1164-
panic!("Expected JSON object");
1165-
};
1157+
let obj = parsed.as_object().expect("expected JSON object");
11661158
assert_eq!(obj.len(), 3);
11671159
assert_eq!(obj.get("alpha"), Some(&Value::String("first".to_string())));
11681160
assert_eq!(obj.get("beta"), Some(&Value::String("second".to_string())));
@@ -1195,9 +1187,7 @@ mod tests {
11951187

11961188
let parsed: Value = serde_json::from_str(&json)
11971189
.map_err(|e| ArrowError::ParseError(format!("JSON parse error: {}", e)))?;
1198-
let Value::Array(arr) = parsed else {
1199-
panic!("Expected JSON array");
1200-
};
1190+
let arr = parsed.as_array().expect("expected JSON array");
12011191
assert_eq!(arr.len(), 7);
12021192
assert_eq!(arr[0], Value::String("string_value".to_string()));
12031193
assert_eq!(arr[1], Value::Number(42.into()));
@@ -1233,9 +1223,7 @@ mod tests {
12331223

12341224
let parsed: Value = serde_json::from_str(&json)
12351225
.map_err(|e| ArrowError::ParseError(format!("JSON parse error: {}", e)))?;
1236-
let Value::Object(obj) = parsed else {
1237-
panic!("Expected JSON object");
1238-
};
1226+
let obj = parsed.as_object().expect("expected JSON object");
12391227
assert_eq!(obj.len(), 6);
12401228
assert_eq!(
12411229
obj.get("string_field"),

0 commit comments

Comments
 (0)